Maven 2 & 3

Make dependencies of test-jars transitive

Details

  • Complexity:
    Intermediate
  • Number of attachments :
    1

Description

test-jar transitive dependencies are calculated as per compile scope rather than test scope.

The situation is demonstrated nicely in it0077:

  • module sub1 has a test-scoped dependency of commons-lang
  • module sub2 has a test-scoped dependency of sub1 test-jar

sub2 tests should inherit the commons-lang transitive dependency. For example:

Index: maven-core-it/it0077/sub2/src/test/java/org/apache/maven/it0077/PersonTwoTest.java
===================================================================
— maven-core-it/it0077/sub2/src/test/java/org/apache/maven/it0077/PersonTwoTest.java (revision
328307)
+++ maven-core-it/it0077/sub2/src/test/java/org/apache/maven/it0077/PersonTwoTest.java (working
copy)
@@ -1,6 +1,7 @@
package org.apache.maven.it0077;

import junit.framework.TestCase;
+import org.apache.commons.lang.BooleanUtils;

public class PersonTwoTest
extends PersonTest

Results in:

[INFO] ----------------------------------------------------------------------------
[ERROR] BUILD FAILURE
[INFO] ----------------------------------------------------------------------------
[INFO] Compilation failure

c:\maven-components\maven-core-it\it0077\sub2\src\test\java\org\apache\maven\it0077\PersonTwoTest.java:[4,31]
package org.apache.commons.lang does not exist

Issue Links

is depended upon by

Bug - A problem which impairs or prevents the functions of the product. MNG-1823 dependencies with classifier mask transitive dependencies of same dependency without classifier

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
is duplicated by

Bug - A problem which impairs or prevents the functions of the product. MNG-1921 test scope in dependencyManagement does not appear to be transitive to dependent subProjects

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

New Feature - A new feature of the product, which has yet to be developed. MNG-2035 Add transitive dependencies with test scope when depending on a test-jar type dependency

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
is related to

Wish - General wishlist item MNG-1971 Transitive dependencies not following attached tests.

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
relates to

Bug - A problem which impairs or prevents the functions of the product. MNG-1571 Wrong calculation of transient dependecies if artifact is referenced from different scopes

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Carlos Sanchez added a comment -

Set a better title. The problem here is that by design test dependencies are not transitive

Show
Carlos Sanchez added a comment - Set a better title. The problem here is that by design test dependencies are not transitive
Hide
Permalink
Kenney Westerhof added a comment -

changed the title as 'Make test dependencies transitive' is incorrect. Test dependencies
are dependencies with scope test. test-jar dependencies are something totally different,
and they can have scope compile.

Show
Kenney Westerhof added a comment - changed the title as 'Make test dependencies transitive' is incorrect. Test dependencies are dependencies with scope test. test-jar dependencies are something totally different, and they can have scope compile.
Hide
Permalink
Lukas Theussl added a comment -

Attaching a simple test project as I just came across this. It doesn't cover all possible manifestations but is the simplest self-contained example that I could come up with. Running test in impl fails, uncommenting the util dependency (non test-jar) in impl's pom makes it pass. In practice I guess this bug is often masked by the fact that you also have a dependency on the corresponding main jar anyway.

Show
Lukas Theussl added a comment - Attaching a simple test project as I just came across this. It doesn't cover all possible manifestations but is the simplest self-contained example that I could come up with. Running test in impl fails, uncommenting the util dependency (non test-jar) in impl's pom makes it pass. In practice I guess this bug is often masked by the fact that you also have a dependency on the corresponding main jar anyway.
Hide
Permalink
Ittay Dror added a comment -

is there a workaround? right now this means I have to copy&paste all test dependencies. (I can't separate to an independent module since test-jar depends on classes in the module and the module's test depend on the test-jar)

Show
Ittay Dror added a comment - is there a workaround? right now this means I have to copy&paste all test dependencies. (I can't separate to an independent module since test-jar depends on classes in the module and the module's test depend on the test-jar)
Hide
Permalink
Didier Loiseau added a comment -

Any progress on this issue? As of 2.2.1 it does not seem to be fixed …
I have exactly the same use case than Ittay and this is very annoying as the test-jar dependencies evolve.

Show
Didier Loiseau added a comment - Any progress on this issue? As of 2.2.1 it does not seem to be fixed … I have exactly the same use case than Ittay and this is very annoying as the test-jar dependencies evolve.
Hide
Permalink
William Ghelfi added a comment -

I have a (not so) slightly different use case and really would like to see this issue fixed...

Show
William Ghelfi added a comment - I have a (not so) slightly different use case and really would like to see this issue fixed...
Hide
Permalink
Alex Heneveld added a comment -

+1

Naively I expected that a dependency which is both test-scoped and test-jar-classified would pull in test-scoped transitive dependencies, ie given

proj1 pom:
<dependency>
  <artifactId>support</artifactId>
  <scope>test</scope>
</dependency>

proj2 pom:
<dependency>
  <artifactId>proj1</artifactId>
  <classifer>test-jar</classifier>
  <scope>test</scope>
</dependency>

Like others I'd like proj2 to see support without having to explicitly re-list it.

If I haven't declared classifier test-jar then it's fair enough not to pull in transitive test-scoped dependencies. I guess the problem is that classifier namespace isn't as formalised as scopes, and making dependency resolution itself dependent on the classifier name could get complicated?

Would a new tag <importScope>test</importScope> be a good solution?

(Although a part of me worries we this starts down a slippery slope, next wanting to introduce test-runtime and test-compile scopes...)

Show
Alex Heneveld added a comment - +1 Naively I expected that a dependency which is both test-scoped and test-jar-classified would pull in test-scoped transitive dependencies, ie given proj1 pom: <dependency> <artifactId>support</artifactId> <scope>test</scope> </dependency> proj2 pom: <dependency> <artifactId>proj1</artifactId> <classifer>test-jar</classifier> <scope>test</scope> </dependency> Like others I'd like proj2 to see support without having to explicitly re-list it. If I haven't declared classifier test-jar then it's fair enough not to pull in transitive test-scoped dependencies. I guess the problem is that classifier namespace isn't as formalised as scopes, and making dependency resolution itself dependent on the classifier name could get complicated? Would a new tag <importScope>test</importScope> be a good solution? (Although a part of me worries we this starts down a slippery slope, next wanting to introduce test-runtime and test-compile scopes...)
Hide
Permalink
Tomasz Szuba added a comment -

What is the status of this issue?
Is it even considered to implement this feature?

Show
Tomasz Szuba added a comment - What is the status of this issue? Is it even considered to implement this feature?
Hide
Permalink
Joshua Pollak added a comment -

I'm amazed this issue has been open 7 years, it seems so basic.

Show
Joshua Pollak added a comment - I'm amazed this issue has been open 7 years, it seems so basic.
Hide
Permalink
Karl M. Davis added a comment -

For those still waiting on this, I recommend adopting the OSGi approach: separate test-only modules/projects. It's adds noise to the project structure, but is a cleaner separation. It has the added advantage of de-cluttering your project POMs and working around this issue.

Show
Karl M. Davis added a comment - For those still waiting on this, I recommend adopting the OSGi approach: separate test-only modules/projects. It's adds noise to the project structure, but is a cleaner separation. It has the added advantage of de-cluttering your project POMs and working around this issue.

People

  • Assignee:
    Unassigned
    Reporter:
    Mark Hobson
Vote (62)
Watch (62)

Dates

  • Created:
    Updated: