Maven
  1. Maven
  2. MNG-1353

Allow creating POJO config classes anywhere without requiring the plugin user to specify an implementation element

    Details

    • Type: Task Task
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Won't Fix
    • Affects Version/s: 2.0
    • Fix Version/s: None
    • Component/s: Plugins and Lifecycle
    • Labels:
      None
    • Complexity:
      Intermediate
    • Number of attachments :
      0

      Description

      This is really important for several reasons:

      • I don't like to clutter my main plugin package with POJO classes. For the Cargo m2 plugin I have 7-8 POJO classes and I'd like to move them to a different package
      • I need to reuse existing POJOs from another jar and it's just too stupid to have to duplicate all the code or write wrapper classes with only getter/setters.

      I think the best solution would be to accept @implementation javadoc tags that would map a parameter to an implementation. This would need to work not only for Mojo classes but also for POJO classes being used for configuration.

        Activity

        Hide
        Vincent Massol added a comment -

        Actually It would be even better to offer a mapping file for this. The reason is that I would like to reuse POJOs from an external jar but I don't want to add @implementation tags to the java of this external jar... At least it should be an option I think...

        Show
        Vincent Massol added a comment - Actually It would be even better to offer a mapping file for this. The reason is that I would like to reuse POJOs from an external jar but I don't want to add @implementation tags to the java of this external jar... At least it should be an option I think...
        Hide
        Stéphane Nicoll added a comment -

        my +1 on that ; I think also it would be very useful.

        Show
        Stéphane Nicoll added a comment - my +1 on that ; I think also it would be very useful.
        Hide
        Brett Porter added a comment -

        I assume this @implementation tag is only needed for lists/maps?

        For example, <archive> JAR seems to meet all your requirements already.

        Show
        Brett Porter added a comment - I assume this @implementation tag is only needed for lists/maps? For example, <archive> JAR seems to meet all your requirements already.
        Brett Porter made changes -
        Field Original Value New Value
        Environment
        Fix Version/s 2.1 [ 11704 ]
        Description This is really important for several reasons:

        * I don't like to clutter my main plugin package with POJO classes. For the Cargo m2 plugin I have 7-8 POJO classes and I'd like to move them to a different package
        * I need to reuse existing POJOs from another jar and it's just too stupid to have to duplicate all the code or write wrapper classes with only getter/setters.

        I think the best solution would be to accept @implementation javadoc tags that would map a parameter to an implementation. This would need to work not only for Mojo classes but also for POJO classes being used for configuration.


        This is really important for several reasons:

        * I don't like to clutter my main plugin package with POJO classes. For the Cargo m2 plugin I have 7-8 POJO classes and I'd like to move them to a different package
        * I need to reuse existing POJOs from another jar and it's just too stupid to have to duplicate all the code or write wrapper classes with only getter/setters.

        I think the best solution would be to accept @implementation javadoc tags that would map a parameter to an implementation. This would need to work not only for Mojo classes but also for POJO classes being used for configuration.


        Hide
        Vincent Massol added a comment -

        Brett,this would be needed for any parameter.

        The goal is to move the config POJO out of the directory where the mojos are so that they can be placed anywhere.

        Show
        Vincent Massol added a comment - Brett,this would be needed for any parameter. The goal is to move the config POJO out of the directory where the mojos are so that they can be placed anywhere.
        Vincent Massol made changes -
        Workflow Maven [ 41127 ] Maven New [ 48087 ]
        Jason van Zyl made changes -
        Fix Version/s 2.1.x [ 13142 ]
        Fix Version/s 2.1 [ 11704 ]
        Jason van Zyl made changes -
        Fix Version/s 3.x [ 13145 ]
        Fix Version/s 3.0 [ 13142 ]
        Jason van Zyl made changes -
        Resolution Won't Fix [ 2 ]
        Status Open [ 1 ] Closed [ 6 ]
        Hide
        Jason van Zyl added a comment -

        After 10 years, I don't think we're going to do this

        Show
        Jason van Zyl added a comment - After 10 years, I don't think we're going to do this
        Paul Benedict made changes -
        Fix Version/s Issues to be reviewed for 3.x [ 13145 ]

          People

          • Assignee:
            Jason van Zyl
            Reporter:
            Vincent Massol
          • Votes:
            3 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: