Maven 2 & 3

MavenEmbedder.writeModel( w, model) should allow to preserve xml formatting

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Critical Critical
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 3.0-alpha-1
  • Component/s: Embedding
  • Labels:
    None
  • Complexity:
    Intermediate
  • Number of attachments :
    0

Description

Currently MavenEmbedder.writeModel( w, model) method does not take into account formatting of the existing pom.xml. This is critical limitation from an end-user prospective.

Issue Links

is depended upon by

Bug - A problem which impairs or prevents the functions of the product. MNGECLIPSE-13 adding dependency to pom.xml changes its formating

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
relates to

Improvement - An improvement or enhancement to an existing feature or task. MNG-4 MavenXpp3Writer improvement

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Milos Kleint added a comment -

actually this one is probably a duplicate on an ancient bug file by Gilles Dodinet.
IMHO a showstopper for any automated modifications from the IDE.

Show
Milos Kleint added a comment - actually this one is probably a duplicate on an ancient bug file by Gilles Dodinet. IMHO a showstopper for any automated modifications from the IDE.
Hide
Permalink
John Casey added a comment -

we're going to be doing a lot of work on encoding and other things related to parsing the POM in 2.1, including switching off of the xpp3 API altogether. Also, we'll be able to merge in the new incarnation of the embedder then. FWIW, I think this bug should wait for those changes, otherwise we risk re-solving this problem later.

Show
John Casey added a comment - we're going to be doing a lot of work on encoding and other things related to parsing the POM in 2.1, including switching off of the xpp3 API altogether. Also, we'll be able to merge in the new incarnation of the embedder then. FWIW, I think this bug should wait for those changes, otherwise we risk re-solving this problem later.
Hide
Permalink
Jason van Zyl added a comment -

The WriterUtils are now being used and this is the best we have right now for preserving the format.

Show
Jason van Zyl added a comment - The WriterUtils are now being used and this is the best we have right now for preserving the format.

People

  • Assignee:
    Jason van Zyl
    Reporter:
    Eugene Kuleshov
Vote (14)
Watch (9)

Dates

  • Created:
    Updated:
    Resolved: