Maven 2.x JBoss Plugin

not runnable run.bat generated on windows

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.4.1
  • Fix Version/s: 1.5.0
  • Labels:
    None
  • Environment:
    Windows XP, Java 1.6 Maven 3.0
  • Number of attachments :
    0

Description

running mvn jboss:configure generates this line inside the bin/run.bat

@set JAVA_OPTS=" -Djboss.server.home.dir=d:\jboss_server\all" "-Djboss.server.home.url=file:d:\jboss_server\all"

the problem are the positions of the ". this can't be exceuted by windows cmd. It need's to be changed into:

@set "JAVA_OPTS= -Djboss.server.home.dir=d:\jboss_server\all -Djboss.server.home.url=file:d:\jboss_server\all"

The other issue is the $

{options}

@call d:\smc_sdk\jboss\bin\run.bat -c all ${options}

If options are not set the $

{options}

should be removed.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Paul Gier added a comment -

Fixed in r13289.

Show
Paul Gier added a comment - Fixed in r13289 .
Hide
Permalink
Jochen Stiepel added a comment -

I'm not sure if the fix is correct.
http://fisheye.codehaus.org/changelog/mojo/trunk/mojo/jboss-maven-plugin?cs=13289

If you run this on windows with the cmd:
set test1="AB AB"
set "test2=AC AC"

a final "set" will show you this:

test1="AB AB"
test2=AC AC

As far as I know the "test2" is the correct way.

Show
Jochen Stiepel added a comment - I'm not sure if the fix is correct. http://fisheye.codehaus.org/changelog/mojo/trunk/mojo/jboss-maven-plugin?cs=13289 If you run this on windows with the cmd: set test1="AB AB" set "test2=AC AC" a final "set" will show you this: test1="AB AB" test2=AC AC As far as I know the "test2" is the correct way.
Hide
Permalink
Paul Gier added a comment -

Ok, I thought that looked weird, but I guess it's correct.
Fixed in r13290.

Show
Paul Gier added a comment - Ok, I thought that looked weird, but I guess it's correct. Fixed in r13290 .

People

  • Assignee:
    Paul Gier
    Reporter:
    Jochen Stiepel
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: