Maven Javadoc Plugin
  1. Maven Javadoc Plugin
  2. MJAVADOC-326

docletPath configuration parameter is concatenated incorrectly

    Details

    • Type: Bug Bug
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.8
    • Fix Version/s: 2.8.1
    • Labels:
      None
    • Number of attachments :
      0

      Description

      No separator is added between path induced from docletArtifacts and docletPath. This makes the docletPath parameter useless.

      Here's a patch (svn diff):

      Index: src/main/java/org/apache/maven/plugin/javadoc/AbstractJavadocMojo.java
      ===================================================================
      — src/main/java/org/apache/maven/plugin/javadoc/AbstractJavadocMojo.java (revision 1170063)
      +++ src/main/java/org/apache/maven/plugin/javadoc/AbstractJavadocMojo.java (working copy)
      @@ -2728,6 +2728,9 @@

      if ( !StringUtils.isEmpty( docletPath ) )

      { + char tail = path.charAt(path.length()-1); + if( tail != ':' || tail != ';') + path.append(":"); path.append( JavadocUtil.unifyPathSeparator( docletPath ) ); }

        Activity

        Hide
        Erik added a comment - - edited

        I suck at jira, apparently.. Here's the svn diff again.

        Index: src/main/java/org/apache/maven/plugin/javadoc/AbstractJavadocMojo.java
        ===================================================================
        --- src/main/java/org/apache/maven/plugin/javadoc/AbstractJavadocMojo.java	(revision 1170063)
        +++ src/main/java/org/apache/maven/plugin/javadoc/AbstractJavadocMojo.java	(working copy)
        @@ -2728,6 +2728,9 @@
         
                 if ( !StringUtils.isEmpty( docletPath ) )
                 {
        +            char tail = path.charAt(path.length()-1);
        +            if( tail != ':' || tail != ';')
        +                path.append(":");
                     path.append( JavadocUtil.unifyPathSeparator( docletPath ) );
                 }
        
        Show
        Erik added a comment - - edited I suck at jira, apparently.. Here's the svn diff again. Index: src/main/java/org/apache/maven/plugin/javadoc/AbstractJavadocMojo.java =================================================================== --- src/main/java/org/apache/maven/plugin/javadoc/AbstractJavadocMojo.java (revision 1170063) +++ src/main/java/org/apache/maven/plugin/javadoc/AbstractJavadocMojo.java (working copy) @@ -2728,6 +2728,9 @@ if ( !StringUtils.isEmpty( docletPath ) ) { + char tail = path.charAt(path.length()-1); + if ( tail != ':' || tail != ';') + path.append( ":" ); path.append( JavadocUtil.unifyPathSeparator( docletPath ) ); }
        Hide
        Herve Boutemy added a comment -

        fixed in r1170082

        I added a configuration in ITs to see the bug then bugfix in action, even if I didn't update corresponding verify.bsh scripts to automate the check

        thanks for the report

        Show
        Herve Boutemy added a comment - fixed in r1170082 I added a configuration in ITs to see the bug then bugfix in action, even if I didn't update corresponding verify.bsh scripts to automate the check thanks for the report

          People

          • Assignee:
            Herve Boutemy
            Reporter:
            Erik
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: