[#MJAVADOC-326] docletPath configuration parameter is concatenated incorrectly - jira.codehaus.org

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 2.8
Fix Version/s: 2.8.1
Labels:
None

Number of attachments :
0

Description

No separator is added between path induced from docletArtifacts and docletPath. This makes the docletPath parameter useless.

Here's a patch (svn diff):

Index: src/main/java/org/apache/maven/plugin/javadoc/AbstractJavadocMojo.java
===================================================================
— src/main/java/org/apache/maven/plugin/javadoc/AbstractJavadocMojo.java (revision 1170063)
+++ src/main/java/org/apache/maven/plugin/javadoc/AbstractJavadocMojo.java (working copy)
@@ -2728,6 +2728,9 @@

if ( !StringUtils.isEmpty( docletPath ) )

{ + char tail = path.charAt(path.length()-1); + if( tail != ':' || tail != ';') + path.append(":"); path.append( JavadocUtil.unifyPathSeparator( docletPath ) ); }

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Erik added a comment - 13/Sep/11 2:48 AM - edited

I suck at jira, apparently.. Here's the svn diff again.

Index: src/main/java/org/apache/maven/plugin/javadoc/AbstractJavadocMojo.java
===================================================================
--- src/main/java/org/apache/maven/plugin/javadoc/AbstractJavadocMojo.java	(revision 1170063)
+++ src/main/java/org/apache/maven/plugin/javadoc/AbstractJavadocMojo.java	(working copy)
@@ -2728,6 +2728,9 @@
 
         if ( !StringUtils.isEmpty( docletPath ) )
         {
+            char tail = path.charAt(path.length()-1);
+            if( tail != ':' || tail != ';')
+                path.append(":");
             path.append( JavadocUtil.unifyPathSeparator( docletPath ) );
         }

Show

Erik added a comment - 13/Sep/11 2:48 AM - edited I suck at jira, apparently.. Here's the svn diff again. Index: src/main/java/org/apache/maven/plugin/javadoc/AbstractJavadocMojo.java =================================================================== --- src/main/java/org/apache/maven/plugin/javadoc/AbstractJavadocMojo.java (revision 1170063) +++ src/main/java/org/apache/maven/plugin/javadoc/AbstractJavadocMojo.java (working copy) @@ -2728,6 +2728,9 @@ if ( !StringUtils.isEmpty( docletPath ) ) { + char tail = path.charAt(path.length()-1); + if ( tail != ':' || tail != ';') + path.append( ":" ); path.append( JavadocUtil.unifyPathSeparator( docletPath ) ); }

Hide

Permalink

Herve Boutemy added a comment - 13/Sep/11 3:31 AM

fixed in r1170082

I added a configuration in ITs to see the bug then bugfix in action, even if I didn't update corresponding verify.bsh scripts to automate the check

thanks for the report

Show

Herve Boutemy added a comment - 13/Sep/11 3:31 AM fixed in r1170082 I added a configuration in ITs to see the bug then bugfix in action, even if I didn't update corresponding verify.bsh scripts to automate the check thanks for the report

docletPath configuration parameter is concatenated incorrectly

Details

Description

Activity

People

Dates