Maven 2.x Javadoc Plugin

performance problem in AbstractJavadocMojo.getModulesLinks()

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Critical Critical
  • Resolution: Fixed
  • Affects Version/s: 2.6
  • Fix Version/s: 2.6.1
  • Labels:
    None
  • Environment:
  • Patch Submitted:
    Yes
  • Number of attachments :
    1

Description

The getModulesLinks() method is unacceptably slow under certain conditions:
1. project's url is defined
2. one or more projects in reactor do not have any java sources and are not of "pom" packaging.
For such projects the apidocs/ output folder is never created resulting in repeated invokation of a forked javadoc goal. It's more severe with high number of modules in reactor and high number of modules without any java sources.

as an example checkout "hg clone https://hg.kenai.com/hg/forceten~src"

The immediate problem is in the apidocsFile.exists() condition that re-triggers the forked invokation. The attached patch fixes that. However it looks suspicitions that the method is being called repeatedly for each module at all. Maybe the aborting condition at the start of the method body is wrong (I was not able to decypher that)

workaround is to use 2.5 or not to specify the url in pom.xml or set the detectOfflineLinks parameter to "false".

Issue Links

is related to

Bug - A problem which impairs or prevents the functions of the product. MJAVADOC-286 Version 2.7 in Maven Reactor may cause infinite recursion, symptoms similar to MJAVADOC-268

  • Critical - Crashes, loss of data, severe memory leak.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Bug - A problem which impairs or prevents the functions of the product. MJAVADOC-284 detectOfflineLinks sets off extra spurious executions of javadoc

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Milos Kleint added a comment -

originally reported at http://forums.netbeans.org/topic18558.html

Show
Milos Kleint added a comment - originally reported at http://forums.netbeans.org/topic18558.html
Hide
Permalink
Fabrizio Giudici added a comment -

I'm the author of forceten - please use "hg up -C 65db9b4e5077" to get a version with the 2.6, as I'm temporarily reverting the project to use 2.5.

Show
Fabrizio Giudici added a comment - I'm the author of forceten - please use "hg up -C 65db9b4e5077" to get a version with the 2.6, as I'm temporarily reverting the project to use 2.5.
Hide
Permalink
Vincent Siveton added a comment -

Patch applied in r827951, snapshot deployed.

Show
Vincent Siveton added a comment - Patch applied in r827951 , snapshot deployed.
Vincent Siveton made changes -
Field Original Value New Value
Status Open [ 1 ] Closed [ 6 ]
Resolution Fixed [ 1 ]
Fix Version/s 2.6.1 [ 14533 ]
Assignee Vincent Siveton [ siveton ]
Hide
Permalink
Francis De Brabandere added a comment -

I seem to still have this problem with 2.6.1

Show
Francis De Brabandere added a comment - I seem to still have this problem with 2.6.1
Hide
Permalink
David MARTIN added a comment -

Are you sure it's really fixed ?

Version 2.6 lets appear some messages like 'goal [...] has not be previously called for the project ...', but version 2.6.1 doesn't work at all with multi-module release (through maven release plugin).

Show
David MARTIN added a comment - Are you sure it's really fixed ? Version 2.6 lets appear some messages like 'goal [...] has not be previously called for the project ...', but version 2.6.1 doesn't work at all with multi-module release (through maven release plugin).
Hide
Permalink
Parag Mehta added a comment -

The issue still exists in 2.7 and does not seem to be fixed. When running in a reactor, this problem causes maven to infinitely recurse. 2.5 seems to work ok though.

Show
Parag Mehta added a comment - The issue still exists in 2.7 and does not seem to be fixed. When running in a reactor, this problem causes maven to infinitely recurse. 2.5 seems to work ok though.
Hide
Permalink
Erik Brakkee added a comment -

I can also confirm it still exists in version 2.7. Reverting back to 2.5 solves the problem, however with only drawback which is that there is no multi-module javadoc available for the overall site. At least my site generation time reduces now from 45 minutes to about 7.

Show
Erik Brakkee added a comment - I can also confirm it still exists in version 2.7. Reverting back to 2.5 solves the problem, however with only drawback which is that there is no multi-module javadoc available for the overall site. At least my site generation time reduces now from 45 minutes to about 7.
Hide
Permalink
Paul Nyheim added a comment -

I can confirm this is NOT fixed for 2.7. Is it possible to reopen this Issue, or do we need to resubmit a new one?

Show
Paul Nyheim added a comment - I can confirm this is NOT fixed for 2.7. Is it possible to reopen this Issue, or do we need to resubmit a new one?
Herve Boutemy made changes -
Link This issue is related to MJAVADOC-286 [ MJAVADOC-286 ]
Herve Boutemy made changes -
Link This issue is related to MJAVADOC-284 [ MJAVADOC-284 ]
Hide
Permalink
Julio Argüello Fernández added a comment -

I agree, I think this issue should be reopened. It's indeed an important thing.

Hoping to find a solution, thank you very much!

Show
Julio Argüello Fernández added a comment - I agree, I think this issue should be reopened. It's indeed an important thing. Hoping to find a solution, thank you very much!
Hide
Permalink
Paul Nyheim added a comment -

Ah - just noticed that it has been linked to MJAVADOC-286 which is still Open and Unresolved. So we could all go over there and vote for that issue.

Show
Paul Nyheim added a comment - Ah - just noticed that it has been linked to MJAVADOC-286 which is still Open and Unresolved. So we could all go over there and vote for that issue.

People

  • Assignee:
    Vincent Siveton
    Reporter:
    Milos Kleint
Vote (0)
Watch (8)

Dates

  • Created:
    Updated:
    Resolved: