jira.codehaus.org

  • Log In Access more options
    • Online Help
    • Keyboard Shortcuts
    • About JIRA
    • JIRA Credits
    • What?s New
  • Dashboards Access more options (Alt+d)
  • Projects Access more options (Alt+p)
  • Issues Access more options (Alt+i)
  • Maven 2.x Javadoc Plugin
  • MJAVADOC-238

No timeout set for URLConnection which can cause build to get stuck

  • Log In
  • Views
    • XML
    • Word
    • Printable

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.5
  • Fix Version/s: 2.6
  • Labels:
    None

Description

I encountered a release build getting stuck. Stack trace revealed that the culprit was an infinite default timeout in URLConnection.

[INFO] at java.net.URL.openStream(URL.java:1007)
[INFO] at org.apache.maven.plugin.javadoc.JavadocUtil.fetchURL(JavadocUtil.java:742)
[INFO] at org.apache.maven.plugin.javadoc.AbstractJavadocMojo.addLinkArguments(AbstractJavadocMojo.java:2982)
[INFO] at org.apache.maven.plugin.javadoc.AbstractJavadocMojo.addStandardDocletOptions(AbstractJavadocMojo.java:3667)
[INFO] at org.apache.maven.plugin.javadoc.AbstractJavadocMojo.executeReport(AbstractJavadocMojo.java:1548)
[INFO] at org.apache.maven.plugin.javadoc.JavadocJar.execute(JavadocJar.java:182)
[INFO] at org.apache.maven.plugin.DefaultPluginManager.executeMojo(DefaultPluginManager.java:483)

The simple fix is to call setConnectTimeout and setReadTimeout with some sensible default value (jdk 1.5 methods, so might need to use reflection to preseve jdk 1.4 compatibility).

Activity

Ascending order - Click to sort in descending order
  • All
  • Comments
  • Work Log
  • History
  • Activity
Hide
Permalink
Vincent Siveton added a comment - 14/Jul/09 6:19 AM

Fixed in r793854, snapshot deployed
Please test it so I could close it.

Show
Vincent Siveton added a comment - 14/Jul/09 6:19 AM Fixed in r793854, snapshot deployed Please test it so I could close it.
Hide
Permalink
Vincent Siveton added a comment - 25/Jul/09 6:23 AM

I added more tests in r797750. All sounds good.

Show
Vincent Siveton added a comment - 25/Jul/09 6:23 AM I added more tests in r797750. All sounds good.

People

  • Assignee:
    Vincent Siveton
    Reporter:
    Sei Syvalta
Vote (0)
Watch (1)

Dates

  • Created:
    26/Jun/09 5:00 AM
    Updated:
    25/Jul/09 6:23 AM
    Resolved:
    25/Jul/09 6:23 AM
  • Atlassian JIRA (v5.0.4#731-sha1:3aa7374)
  • Report a problem
  • Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.