jira.codehaus.org

  • Log In Access more options
    • Online Help
    • Keyboard Shortcuts
    • About JIRA
    • JIRA Credits
    • What?s New
  • Dashboards Access more options (Alt+d)
  • Projects Access more options (Alt+p)
  • Issues Access more options (Alt+i)
Signup
Maven 2.x Javadoc Plugin
  • Maven 2.x Javadoc Plugin
  • MJAVADOC-162

javadocExecutable unusable

  • Log In
  • Views
    • XML
    • Word
    • Printable

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.3
  • Fix Version/s: 2.5
  • Labels:
    None
  • Environment:
    Windows XP and non-Windows
  • Number of attachments :
    1

Description

AbstractJavadocMojo tries to be smart by seeing if the file indicated by javadocExecutable exists, but this is actually quite problematic. If you put the following in your config:

<javadocExecutable>blahblahblah$

{file.separator}

javadoc</javadocExecutable>

then you'll get an error on Windows since the file is actually javadoc.exe, which is a pain since it's perfectly acceptable to omit the .exe when executing a command.

If you put .exe in the config, then it won't work on non-Windows platforms since the files doesn't have .exe.

Forcing users to add hackery to their POMs to add .exe in some cases and leave it off in others is onerous.

Methinks it's much preferable to simply use the path provided by the config. If it doesn't exist, let CommandLineUtils.executeCommandLine (or something else) throw an exception.

  • Options
    • Sort By Name
    • Sort By Date
    • Ascending
    • Descending
    • Download All

Attachments

  1. Text File
    javadoc-executable.patch
    08/Mar/08 7:23 AM
    1 kB
    Benjamin Bentmann

Activity

Ascending order - Click to sort in descending order
  • All
  • Comments
  • Work Log
  • History
  • Activity
Hide
Permalink
Wendy Smoak added a comment - 05/Mar/08 8:40 PM

Vincent, you marked this for 2.4 back in January. Are you planning to work on it, or should we bump it to 2.5? I'd like to stage 2.4 this weekend.

Show
Wendy Smoak added a comment - 05/Mar/08 8:40 PM Vincent, you marked this for 2.4 back in January. Are you planning to work on it, or should we bump it to 2.5? I'd like to stage 2.4 this weekend.
Hide
Permalink
Benjamin Bentmann added a comment - 08/Mar/08 7:23 AM

Patch attached. The logic has been extended to accept "<snip>/javadoc" on all platforms by appending ".exe" automatically on Windows boxes.

Besides the fix, I made the parameter accept a mere directory spec, too, as a matter of convenience.

Show
Benjamin Bentmann added a comment - 08/Mar/08 7:23 AM Patch attached. The logic has been extended to accept "<snip>/javadoc" on all platforms by appending ".exe" automatically on Windows boxes. Besides the fix, I made the parameter accept a mere directory spec, too, as a matter of convenience.
Hide
Permalink
Benjamin Bentmann added a comment - 18/Apr/08 10:56 AM

Fixed in r649582.

Show
Benjamin Bentmann added a comment - 18/Apr/08 10:56 AM Fixed in r649582 .

People

  • Assignee:
    Benjamin Bentmann
    Reporter:
    Greg Thompson
Vote (1)
Watch (0)

Dates

  • Created:
    16/Nov/07 1:35 PM
    Updated:
    18/Apr/08 10:56 AM
    Resolved:
    18/Apr/08 10:56 AM
  • Atlassian JIRA (v5.2.7#850-sha1:b2af0c8)
  • Report a problem
  • Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.