Details

    • Type: Bug Bug
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.5
    • Labels:
      None
    • Environment:
      Windows XP and non-Windows
    • Number of attachments :
      1

      Description

      AbstractJavadocMojo tries to be smart by seeing if the file indicated by javadocExecutable exists, but this is actually quite problematic. If you put the following in your config:

      <javadocExecutable>blahblahblah$

      {file.separator}

      javadoc</javadocExecutable>

      then you'll get an error on Windows since the file is actually javadoc.exe, which is a pain since it's perfectly acceptable to omit the .exe when executing a command.

      If you put .exe in the config, then it won't work on non-Windows platforms since the files doesn't have .exe.

      Forcing users to add hackery to their POMs to add .exe in some cases and leave it off in others is onerous.

      Methinks it's much preferable to simply use the path provided by the config. If it doesn't exist, let CommandLineUtils.executeCommandLine (or something else) throw an exception.

        Activity

        Hide
        Wendy Smoak added a comment -

        Vincent, you marked this for 2.4 back in January. Are you planning to work on it, or should we bump it to 2.5? I'd like to stage 2.4 this weekend.

        Show
        Wendy Smoak added a comment - Vincent, you marked this for 2.4 back in January. Are you planning to work on it, or should we bump it to 2.5? I'd like to stage 2.4 this weekend.
        Hide
        Benjamin Bentmann added a comment -

        Patch attached. The logic has been extended to accept "<snip>/javadoc" on all platforms by appending ".exe" automatically on Windows boxes.

        Besides the fix, I made the parameter accept a mere directory spec, too, as a matter of convenience.

        Show
        Benjamin Bentmann added a comment - Patch attached. The logic has been extended to accept "<snip>/javadoc" on all platforms by appending ".exe" automatically on Windows boxes. Besides the fix, I made the parameter accept a mere directory spec, too, as a matter of convenience.
        Hide
        Benjamin Bentmann added a comment -

        Fixed in r649582.

        Show
        Benjamin Bentmann added a comment - Fixed in r649582 .

          People

          • Assignee:
            Benjamin Bentmann
            Reporter:
            Greg Thompson
          • Votes:
            1 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: