Maven 2.x JavaCC Plugin

Custom sources get re-generated

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.1
  • Fix Version/s: 2.2
  • Component/s: None
  • Labels:
    None
  • Number of attachments :
    1

Description

It is sometimes required that custom implementations of certain .java files be provided (as is done in the javacc examples). For instance, custom Token.java for the Java 5 grammar. Also custom AST node implementations can be used for some, but not all jjtree nodes.

When running javacc from the command line, it will not output a file if something with that name already exists. It is desireable that this or a similar functionality be provided by the plugin.

Either copy all .java files from the input directory (e.g. src/main/javacc) to the output directory, check the existing compile source paths to see if certain classes already exist before adding them to the generated output directory.

Issue Links

relates to

Improvement - An improvement or enhancement to an existing feature or task. MJAVACC-87 Allow customized parser sources to reside in src/main/java

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Julien HENRY added a comment -

This patch make javacc plugin copy all .java file from inputDirectory to outputDirectory before executing javacc.

Show
Julien HENRY added a comment - This patch make javacc plugin copy all .java file from inputDirectory to outputDirectory before executing javacc.
Hide
Permalink
Julien HENRY added a comment -

Please apply this patch and deploy a new snapshot.

Thanks

Show
Julien HENRY added a comment - Please apply this patch and deploy a new snapshot. Thanks
Hide
Permalink
Jesse McConnell added a comment -

applied and snapshot generated

Show
Jesse McConnell added a comment - applied and snapshot generated
Hide
Permalink
Tim Pizey added a comment -

Have I misunderstood?

This patch does not seem to be a solution.

You now get compilation errors as there are two copies of the source file, one in the source-directory and one in the
generated files directory., yes they are the same file, but java does not know that

It looks like we need to delete them afterwards too, so might as well let javacc/jjtree generate them and
then delete them .

Show
Tim Pizey added a comment - Have I misunderstood? This patch does not seem to be a solution. You now get compilation errors as there are two copies of the source file, one in the source-directory and one in the generated files directory., yes they are the same file, but java does not know that It looks like we need to delete them afterwards too, so might as well let javacc/jjtree generate them and then delete them .
Hide
Permalink
Tim Pizey added a comment -

OK, think I have got there: modified generated files should be put in the grammar source tree not the main source tree.

Will update the docs to reflect.

Show
Tim Pizey added a comment - OK, think I have got there: modified generated files should be put in the grammar source tree not the main source tree. Will update the docs to reflect.
Hide
Permalink
Julien HENRY added a comment -

Yes, modified generated files should be put in src/main/javacc, not in src/main/java.

Show
Julien HENRY added a comment - Yes, modified generated files should be put in src/main/javacc, not in src/main/java.

People

  • Assignee:
    Jesse McConnell
    Reporter:
    Adam Lewis
Vote (5)
Watch (3)

Dates

  • Created:
    Updated:
    Resolved: