Maven 2.x JAR Plugin

addClasspath is not respected for runtime dependencies

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.1, 2.2
  • Fix Version/s: 2.2
  • Component/s: None
  • Labels:
    None
  • Number of attachments :
    2

Description

maven-jar-plugin does not resolve dependencies itself, so specifying

	<configuration>
		<archive>
			<manifest>
				<addClasspath>true</addClasspath>
			</manifest>
		</archive>
	</configuration>

will add no dependencies for 

	mvn jar:jar

And even

	mvn compiler:compile jar:jar

will only add compile time dependencies, not runtime dependencies, presumably because the maven-compiler-plugin causes resolution of the compile time dependencies.

See the attached POM.
There is no manifest classpath generated by

	mvn jar:jar

The manifest classpath generated by

	mvn compiler:compile jar:jar

only contains commons-codec which is the compile time dependency.

There needs to be a way to add runtime dependences to the manifest classpath of the jar.
And preferably not requiring some other plugin to resolve the dependencies first.

  1. Text File
    patch.txt
    03/Sep/07 10:29 PM
    2 kB
    William Ferguson
  2. XML File
    pom.xml
    03/Sep/07 7:57 PM
    2 kB
    William Ferguson

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
William Ferguson added a comment -

The workaround for this is to

  • List all deps with a scope of compile
  • Execute mvn compiler:compile jar:jar

Neither of is nice and both of which is required.

NB I forgot to say why we need to create a Jar with no content other than a manifest classpath.
Its because the Windows line length limit precludes classpaths that are too long, so we generate a Jar with a manifest classpath that includes all the target libraries and just include it.

But its seems like a problem in the general sense in any case.

Show
William Ferguson added a comment - The workaround for this is to List all deps with a scope of compile Execute mvn compiler:compile jar:jar Neither of is nice and both of which is required. NB I forgot to say why we need to create a Jar with no content other than a manifest classpath. Its because the Windows line length limit precludes classpaths that are too long, so we generate a Jar with a manifest classpath that includes all the target libraries and just include it. But its seems like a problem in the general sense in any case.
Hide
Permalink
William Ferguson added a comment - - edited

The patch adds @requiresDependencyResolution tags of runtime to

  • JarMojo
  • JarSignMojo
  • JarSignVerifyMojo

And a @requiresDependencyResolution tag of test to

  • TestJarMojo

I tried to put together a test case, but the existing test cases were not particualrly helpful as a starting point. To test you need to ensure that with the dependency list shown below, only commons-code and commons-io appear in the manifest classpath for jar:jar etc.

<dependencies>
		
	<dependency>
		<groupId>commons-codec</groupId>
		<artifactId>commons-codec</artifactId>
		<scope>compile</scope>
		<version>1.3</version>
	</dependency>
		
	<dependency>
		<groupId>commons-io</groupId>
		<artifactId>commons-io</artifactId>
		<scope>runtime</scope>
		<version>1.2</version>
	</dependency>
		
	<dependency>
		<groupId>commons-lang</groupId>
		<artifactId>commons-lang</artifactId>
		<scope>provided</scope>
		<version>2.1</version>
	</dependency>
		
	<dependency>
		<groupId>commons-logging</groupId>
		<artifactId>commons-logging</artifactId>
		<scope>test</scope>
		<version>1.0.4</version>
	</dependency>
		
</dependencies>
Show
William Ferguson added a comment - - edited The patch adds @requiresDependencyResolution tags of runtime to JarMojo JarSignMojo JarSignVerifyMojo And a @requiresDependencyResolution tag of test to TestJarMojo I tried to put together a test case, but the existing test cases were not particualrly helpful as a starting point. To test you need to ensure that with the dependency list shown below, only commons-code and commons-io appear in the manifest classpath for jar:jar etc. <dependencies> <dependency> <groupId>commons-codec</groupId> <artifactId>commons-codec</artifactId> <scope>compile</scope> <version>1.3</version> </dependency> <dependency> <groupId>commons-io</groupId> <artifactId>commons-io</artifactId> <scope>runtime</scope> <version>1.2</version> </dependency> <dependency> <groupId>commons-lang</groupId> <artifactId>commons-lang</artifactId> <scope>provided</scope> <version>2.1</version> </dependency> <dependency> <groupId>commons-logging</groupId> <artifactId>commons-logging</artifactId> <scope>test</scope> <version>1.0.4</version> </dependency> </dependencies>
William Ferguson made changes -
Field Original Value New Value
Attachment patch.txt [ 29272 ]
Mauro Talevi made changes -
Assignee Mauro Talevi [ maurotalevi ]
Hide
Permalink
Mauro Talevi added a comment -

Applied - thanks.

Show
Mauro Talevi added a comment - Applied - thanks.
Mauro Talevi made changes -
Status Open [ 1 ] Closed [ 6 ]
Fix Version/s 2.2 [ 12878 ]
Resolution Fixed [ 1 ]
Hide
Permalink
William Ferguson added a comment -

Thanks Mauro, the maven-jar-plugin-2.2-20071013.140436-2 snapshot works like dream.

Show
William Ferguson added a comment - Thanks Mauro, the maven-jar-plugin-2.2-20071013.140436-2 snapshot works like dream.

People

  • Assignee:
    Mauro Talevi
    Reporter:
    William Ferguson
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: