Maven 2.x JAR Plugin

[PATCH] Wrong artifact type attached to the project by the test-jar goal

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Critical Critical
  • Resolution: Fixed
  • Affects Version/s: 2.0, 2.1, 2.2
  • Fix Version/s: 2.2
  • Component/s: None
  • Labels:
    None
  • Environment:
    All
  • Testcase included:
    yes
  • Patch Submitted:
    Yes
  • Number of attachments :
    2

Description

The test-jar goal attaches to the project "org.apache.maven.its.it0121:model:jar" such a artifact:

  • org.apache.maven.its.it0121:model:jar:tests
    It should attach such an artifact:
  • org.apache.maven.its.it0121:model:test-jar:tests

The wrong artifacts "naming" leads to MNG-2871 problem:
The code does not work (because the strings are different:
-----------------MavenProject: replaceWithActiveArtifact(...)--------------------------------------------
....
Iterator itr = ref.getAttachedArtifacts().iterator();
while(itr.hasNext()) {
Artifact attached = (Artifact) itr.next();
if( attached.getDependencyConflictId().equals(pluginArtifact.getDependencyConflictId()) )

{ ... (resolve as active's project) ... }

...
-------------------------------------------------------------------------------------------------------------------------------------------
pluginArtifact.getDependencyConflictId() is : org.apache.maven.its.it0121:model:test-jar:tests
attached.getDependencyConflictId() is : org.apache.maven.its.it0121:model:jar:tests

For test-case: look at test (it121) attached to: http://jira.codehaus.org/browse/MNG-2871

Issue Links

is depended upon by

Bug - A problem which impairs or prevents the functions of the product. MRELEASE-285 Unresolved test-jar dependency during release

  • Major - Major loss of function.
  • Reopened - This issue was once resolved, but the resolution was deemed incorrect. From here issues are either marked assigned or resolved.

Bug - A problem which impairs or prevents the functions of the product. MNG-2045 Maven can't compile against sibling test-jar dependency in multiproject (Test Attached)

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Bug - A problem which impairs or prevents the functions of the product. MNG-2871 Subartifact (ejb-client, test-jar etc.) are not reselved as active project artifacts in build phases prior to package

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Bug - A problem which impairs or prevents the functions of the product. MNG-3043 Allow 'mvn test' to work with test-jar dependencies in a reactor

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Bug - A problem which impairs or prevents the functions of the product. MNG-3076 Dependency on test-jar is not resolved with 'package' target, must use 'install'

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Bug - A problem which impairs or prevents the functions of the product. MNG-4248 CLONE -Maven can't compile against sibling test-jar dependency in multiproject (Test Attached)

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Piotr Tabor added a comment -

Patch

Show
Piotr Tabor added a comment - Patch
Piotr Tabor made changes -
Field Original Value New Value
Attachment maven-jar-plugin-MJAR-75.diff [ 27857 ]
Piotr Tabor made changes -
Link This issue is depended upon by MNG-2871 [ MNG-2871 ]
Piotr Tabor made changes -
Link This issue is depended upon by MNG-3043 [ MNG-3043 ]
Jason van Zyl made changes -
Assignee Jason van Zyl [ jason ]
Hide
Permalink
Piotr Tabor added a comment -

Dedicated IT for this issue attached.

Show
Piotr Tabor added a comment - Dedicated IT for this issue attached.
Piotr Tabor made changes -
Attachment MJAR-75-core-integration-testing.diff [ 28916 ]
John Casey made changes -
Assignee Jason van Zyl [ jason ] John Casey [ jdcasey ]
Hide
Permalink
John Casey added a comment -

Applied, thanks.

Show
John Casey added a comment - Applied, thanks.
John Casey made changes -
Resolution Fixed [ 1 ]
Status Open [ 1 ] Closed [ 6 ]
Fix Version/s 2.2 [ 12878 ]
Piotr Tabor made changes -
Link This issue is depended upon by MNG-2045 [ MNG-2045 ]
Paul Gier made changes -
Link This issue is depended upon by MRELEASE-285 [ MRELEASE-285 ]
Ceki Gulcu made changes -
Link This issue is depended upon by MNG-3804 [ MNG-3804 ]
Brian Fox made changes -
Link This issue is depended upon by MNG-3804 [ MNG-3804 ]
Benjamin Bentmann made changes -
Link This issue is depended upon by MNG-3076 [ MNG-3076 ]
Obi Ezechukwu made changes -
Link This issue is depended upon by MNG-4248 [ MNG-4248 ]

People

  • Assignee:
    John Casey
    Reporter:
    Piotr Tabor
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: