Details
-
Type:
New Feature
-
Status:
Open
-
Priority:
Major
-
Resolution: Unresolved
-
Affects Version/s: 1.2.1
-
Fix Version/s: None
-
Component/s: None
-
Labels:None
-
Number of attachments :
Description
Many pre-/post-build hook scripts share very similar patterns to check for existence/absence of files, JAR entries etc. Those scripts could be greatly condensed if the Invoker Plugin provided a Verifier-like component to perform these common assertions using dedicated methods. In detail, offer Verifier.assert*() for the scripts.
Issue Links
| This issue relates to: | ||||
| MINVOKER-113 | update to Groovy 1.7.5 (from 1.5.6) |
|
|
|
Activity
Hide
Benjamin Bentmann
added a comment -
Not sure whether we need those. I currently have a simple/lightweight POJO class in mind (i.e. not a component in the Plexus sense) that just has some constructors for initialization and that's it. The dispose() is intended to release resources like file handles on archives. However, it's not fully thought up (at least on my side 
).
To further illustrate the intended usage:
In the Invoker Plugin
// setup the asserter for the current IT Asserter asserter = new Asserter(); asserter.setCurrentDirectory( basedir ); // pass it on to the script interpreter as a global variable runHookScript( ..., asserter ); // tidy up asserter.dispose();
In the Hook Script
asserter.assertFile( "target/foo-1.0.jar" ); asserter.setCurrentDirectory( "target/exploded" ); asserter.assertFile( "WEB-INF/lib/bar-1.0.jar" );
Show
Benjamin Bentmann
added a comment - Not sure whether we need those. I currently have a simple/lightweight POJO class in mind (i.e. not a component in the Plexus sense) that just has some constructors for initialization and that's it. The dispose() is intended to release resources like file handles on archives. However, it's not fully thought up (at least on my side ).
To further illustrate the intended usage:
).
To further illustrate the intended usage:
In the Invoker Plugin
// setup the asserter for the current IT Asserter asserter = new Asserter(); asserter.setCurrentDirectory( basedir ); // pass it on to the script interpreter as a global variable runHookScript( ..., asserter ); // tidy up asserter.dispose();
In the Hook Script
asserter.assertFile( "target/foo-1.0.jar" ); asserter.setCurrentDirectory( "target/exploded" ); asserter.assertFile( "WEB-INF/lib/bar-1.0.jar" );
Some first thoughts on the API of this Asserter component:
The archive assertions should be reviewed to support nested archives.
- dispose()
The archive assertions should be reviewed to support nested archives.