Maven 2.x Invoker Plugin

Allow to configure file encoding for verifications scripts

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.1
  • Fix Version/s: 1.2
  • Labels:
    None
  • Patch Submitted:
    Yes
  • Number of attachments :
    1

Description

Right now, the verify.bsh is read using the platform's default encoding, making the tests platform-dependent. We should enrich the plugin configuration to allow the user to lock down the encoding and ensure reproducible tests.

The same applies to the goals.txt and profiles.txt.

Issue Links

is depended upon by

Improvement - An improvement or enhancement to an existing feature or task. MINVOKER-34 Warn about usage of platform encoding

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
is related to

Improvement - An improvement or enhancement to an existing feature or task. MNG-2216 Add default encodings section to POM

  • Major - Major loss of function.
  • Open - The issue is open and ready for the assignee to start work on it.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Benjamin Bentmann added a comment -

Here is the proposed patch, following our current proposal about source file encoding.

Show
Benjamin Bentmann added a comment - Here is the proposed patch, following our current proposal about source file encoding .
Hide
Permalink
Benjamin Bentmann added a comment -

Committed in r649475.

Show
Benjamin Bentmann added a comment - Committed in r649475 .
Hide
Permalink
Benjamin Bentmann added a comment -

Defaults needs to be changed to platform encoding.

Show
Benjamin Bentmann added a comment - Defaults needs to be changed to platform encoding.
Hide
Permalink
Benjamin Bentmann added a comment -

Done in r653017.

Show
Benjamin Bentmann added a comment - Done in r653017 .

People

  • Assignee:
    Benjamin Bentmann
    Reporter:
    Benjamin Bentmann
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: