Maven Invoker Plugin
  1. Maven Invoker Plugin
  2. MINVOKER-30

Allow to configure file encoding for verifications scripts

    Details

    • Type: Improvement Improvement
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.1
    • Fix Version/s: 1.2
    • Labels:
      None
    • Patch Submitted:
      Yes
    • Number of attachments :
      1

      Description

      Right now, the verify.bsh is read using the platform's default encoding, making the tests platform-dependent. We should enrich the plugin configuration to allow the user to lock down the encoding and ensure reproducible tests.

      The same applies to the goals.txt and profiles.txt.

        Issue Links

          Activity

          Hide
          Benjamin Bentmann added a comment -

          Here is the proposed patch, following our current proposal about source file encoding.

          Show
          Benjamin Bentmann added a comment - Here is the proposed patch, following our current proposal about source file encoding .
          Hide
          Benjamin Bentmann added a comment -

          Committed in r649475.

          Show
          Benjamin Bentmann added a comment - Committed in r649475 .
          Hide
          Benjamin Bentmann added a comment -

          Defaults needs to be changed to platform encoding.

          Show
          Benjamin Bentmann added a comment - Defaults needs to be changed to platform encoding.
          Hide
          Benjamin Bentmann added a comment -

          Done in r653017.

          Show
          Benjamin Bentmann added a comment - Done in r653017 .

            People

            • Assignee:
              Benjamin Bentmann
              Reporter:
              Benjamin Bentmann
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: