jira.codehaus.org

  • Log In Access more options
    • Online Help
    • Keyboard Shortcuts
    • About JIRA
    • JIRA Credits
    • What?s New
  • Dashboards Access more options (Alt+d)
  • Projects Access more options (Alt+p)
  • Issues Access more options (Alt+i)
Signup
Maven 2.x CORBA IDL Compiler Plugin
  • Maven 2.x CORBA IDL Compiler Plugin
  • MIDLJ-15

idlj-maven-plugin cannot failed

  • Log In
  • Views
    • XML
    • Word
    • Printable

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.1.1
  • Fix Version/s: 1.2
  • Labels:
    None
  • Number of attachments :
    2

Description

I have an Idl that contains an error (bad type) see attached file "myIdl.idl"
when I execute maven using the attached pom.xml.
Then I can see an error form the idl compiler:

[ERROR] E:\temp\mvn-idlj-pb\src\main\idl\myIdl.idl (line 5): 
UnknownReturnType is an undeclared type.
	UnknownReturnType testFailed();
                  ^

But maven says it is a success (BUILD SUCCESS)
I have tried with parameter failOnError to true but still the same behaviour

The issue comes from the idlj compiler from sun that doesn't return an error code.
But the idlj maven plugin can easily improve this bad behaviour in classe "org.codehaus.mojo.idlj.IdljTranslator" at the end of the method "invokeCompiler":

        if ( isFailOnError() && ( exitCode != 0 || err.toString().contains( "Invalid argument" ) ) )
        {
            throw new MojoExecutionException( "IDL compilation failed" );
        }

I think if the error stream contains information that's means there is at least one error (not sure if it can contains warnings...)

  • Options
    • Sort By Name
    • Sort By Date
    • Ascending
    • Descending
    • Download All

Attachments

  1. File
    myIdl.idl
    14/Jun/12 2:35 AM
    0.1 kB
    Yann Albou
  2. XML File
    pom.xml
    14/Jun/12 2:35 AM
    1 kB
    Yann Albou

Activity

Ascending order - Click to sort in descending order
  • All
  • Comments
  • Work Log
  • History
  • Activity
Hide
Permalink
Russell Gold added a comment - 14/Jun/12 5:43 AM

I have confirmed this behavior, and verified that testing for a non-empty error output appears to resolve it. I need to do more testing to check that it does not introduce new problems.

Show
Russell Gold added a comment - 14/Jun/12 5:43 AM I have confirmed this behavior, and verified that testing for a non-empty error output appears to resolve it. I need to do more testing to check that it does not introduce new problems.
Hide
Permalink
Russell Gold added a comment - 14/Jun/12 10:46 AM

1.1.2-SNAPSHOT containing this fix has been uploaded to https://nexus.codehaus.org/content/repositories/snapshots/

Show
Russell Gold added a comment - 14/Jun/12 10:46 AM 1.1.2-SNAPSHOT containing this fix has been uploaded to https://nexus.codehaus.org/content/repositories/snapshots/
Hide
Permalink
Russell Gold added a comment - 20/Jun/12 8:34 AM

Will be included in the next release

Show
Russell Gold added a comment - 20/Jun/12 8:34 AM Will be included in the next release

People

  • Assignee:
    Russell Gold
    Reporter:
    Yann Albou
Vote (0)
Watch (2)

Dates

  • Created:
    14/Jun/12 2:35 AM
    Updated:
    17/Jul/12 8:12 AM
    Resolved:
    20/Jun/12 8:34 AM
  • Atlassian JIRA (v5.2.7#850-sha1:b2af0c8)
  • Report a problem
  • Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.