Maven GWT Plugin

Resource Filtering, does not filter all copy's of the resources.

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.2
  • Fix Version/s: 2.1.0-1
  • Labels:
    None
  • Number of attachments :
    0

Description

About

When applying maven resource filtering (http://maven.apache.org/plugins/maven-resources-plugin/examples/filter.html) only partial support is encountered.

Example:

My 'com.acme.gwtproject.GwtProject' uses the standard gwt-maven directory layout, consequently my html is located at...

./src/main/resources/com/acme/gwtproject/public/GwtProject.html

If GwtProject.html contains a token say $

{project.version} I want to see this in the released artifacts, released sources artifacts and in dev mode. But the build lifecycle only seems to filter/replace one copy of the file, that strangely end's up @ ./war/WEB-INF/classes/GwtProject.html <--- weird location!

NOTE: I don't believe that this has anything todo with the bug, but my project is <packaging>jar</packaging>

h1. Reproduce

To reproduce this, and the following to a pom.
	<build>
	...
		<resources>
			<resource>
				<directory>src/main/java</directory>
			</resource>
			<resource>
				<directory>src/main/resources</directory>
				<filtering>true</filtering>
			</resource>
		</resources>
	...
	<build>


Then add a token to your project's html file...
${project.version}

Try 'gwt:run', look at the html source and see it has not been filtered.
Also try 'install' to build the war/jar and take a look at it's contents, the html file would not have been filtered within these artifacts.

Issue Links

is duplicated by

Bug - A problem which impairs or prevents the functions of the product. MGWT-222 Maven resource filtering should work for resources used by the GWT plugin

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Sean Flanigan added a comment -

The same applies to property expansion in a GWT module descriptor (MyApp.gwt.xml). It looks to me like the original, unfiltered directory "src/main/resources" is added to the GWT compiler's classpath ahead of "target/classes". So even if the Resources plugin has done the filtering, GWT ignores it.

Show
Sean Flanigan added a comment - The same applies to property expansion in a GWT module descriptor (MyApp.gwt.xml). It looks to me like the original, unfiltered directory "src/main/resources" is added to the GWT compiler's classpath ahead of "target/classes". So even if the Resources plugin has done the filtering, GWT ignores it.
Hide
Permalink
Olivier Lamy added a comment -

can you try with the trunk and using the copyWebapp mojo parameter ? (or -Dgwt.copyWebapp=true)

Show
Olivier Lamy added a comment - can you try with the trunk and using the copyWebapp mojo parameter ? (or -Dgwt.copyWebapp=true)
Hide
Permalink
Geoffrey De Smet added a comment -

Can't test on trunk because trunk doesn't work for us. We had to fork it due to MGWT-219

Show
Geoffrey De Smet added a comment - Can't test on trunk because trunk doesn't work for us. We had to fork it due to MGWT-219
Hide
Permalink
Olivier Lamy added a comment -

release starting so mark this as fixed.
If not please open a new issue.

Show
Olivier Lamy added a comment - release starting so mark this as fixed. If not please open a new issue.
Hide
Permalink
Benjamin Peter added a comment -

Created MGWT-285 please vote and comment there if you have the same problem.

Show
Benjamin Peter added a comment - Created MGWT-285 please vote and comment there if you have the same problem.
Hide
Permalink
Andrew Hughes added a comment - - edited

Tested with 2.2.0 and maven 3.0.2. The html page and WEB-INF/web.xml located in src/main/webapp - this is the maven default location for such content in 2.1+ and also is used in the archetype (the issue was raised in 2.0 and the location was different, as described in the issue description).

Repeating the Test

Added the following to the pom.xml

	<build>
		<resources>
			<resource>
				<directory>src/main/webapp</directory>
				<filtering>true</filtering>
			</resource>
		</resources>
	        ...
	<build>

Add the following to src/main/webapp/TheAppsPage.html

...
<title>${project.artifactId}</title>
...

Sorry to report...

Filtering did not work with this configuration as desired.

I would kindly request that if this is closed, could you please provide some documentation (either here or even better, on the gwt-maven-plugins maven site). No doubt that this was not closed accidently, does it have anything todo with this http://mojo.codehaus.org/gwt-maven-plugin/resources-mojo.html ?

Any help would be great

Show
Andrew Hughes added a comment - - edited Tested with 2.2.0 and maven 3.0.2. The html page and WEB-INF/web.xml located in src/main/webapp - this is the maven default location for such content in 2.1+ and also is used in the archetype (the issue was raised in 2.0 and the location was different, as described in the issue description). Repeating the Test Added the following to the pom.xml <build> <resources> <resource> <directory>src/main/webapp</directory> <filtering>true</filtering> </resource> </resources> ... <build> Add the following to src/main/webapp/TheAppsPage.html ... <title>${project.artifactId}</title> ... Sorry to report... Filtering did not work with this configuration as desired. I would kindly request that if this is closed, could you please provide some documentation (either here or even better, on the gwt-maven-plugins maven site). No doubt that this was not closed accidently, does it have anything todo with this http://mojo.codehaus.org/gwt-maven-plugin/resources-mojo.html ? Any help would be great

People

  • Assignee:
    Olivier Lamy
    Reporter:
    Andrew Hughes
Vote (2)
Watch (5)

Dates

  • Created:
    Updated:
    Resolved: