Details
-
Type:
Improvement
-
Status:
Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 2.1.0
-
Fix Version/s: 1.2
-
Labels:None
-
Patch Submitted:Yes
Description
The Util class created during the generateAsync goal causes a lot of warnings for common static code analysis tools like Checkstyle, FindBugs, and PMD. Attached is a patch against r10656 which cleans up this utility class a bit. There still is work to be done where we are redundantly setting the service target if the service class already codes a @RemoteServiceRelativePath.
Your patch changes the initialisation principle to preemptively setup the RPC proxy before any call to getInstance.
Not sure this is a best practice : this may slow down the webUI initialization time with unecessary setup code execution
also, your patch makes the Util package visible, how can you use it from other code if not plublic ?
Anyway, you should configure your code analysis tools to exclude generated code (this plugin or any other). What if you don't use maven code style convention ?