Maven 2.x Enforcer Plugin

Review evaluation of version ranges with regard to inclusion of snapshots

Details

  • Type: Task Task
  • Status: Open Open
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: 1.0-beta-1
  • Fix Version/s: None
  • Component/s: Standard Rules
  • Labels:
    None
  • Number of attachments :
    0

Description

The fix for MNG-3092 affects also certain Enforcer rules that deal with version ranges. We need to review which rules are intended to match core's dependency resolution semantics and which rules deliberately want to include snapshots in version ranges. For instance, the rule RequireMavenVersion in combination with a range like [2.0.9,) now fails when run with Maven 3.0-SNAPSHOT which is counter-intuitive in this case.

Issue Links

is related to

Bug - A problem which impairs or prevents the functions of the product. MRELEASE-216 Release plugin should ignore SNAPSHOTS that are not specified in the POM

  • Major - Major loss of function.
  • Open - The issue is open and ready for the assignee to start work on it.

Bug - A problem which impairs or prevents the functions of the product. MNG-3092 Version ranges with non-snapshot bounds can contain snapshot versions

  • Major - Major loss of function.
  • Reopened - This issue was once resolved, but the resolution was deemed incorrect. From here issues are either marked assigned or resolved.

Bug - A problem which impairs or prevents the functions of the product. MENFORCER-101 Enforcer does not allow to restrict based on SNAPSHOT version as version comparison uses artifact.getVersion() instead of artifact.getBaseVersion()

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
relates to

Bug - A problem which impairs or prevents the functions of the product. MNG-4751 Snapshot version not resolved for version range

  • Blocker - Blocks development and/or testing work, production could not run
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Benjamin Bentmann made changes -
Field Original Value New Value
Link This issue is related to MNG-3092 [ MNG-3092 ]
Herve Boutemy made changes -
Link This issue relates to MNG-4751 [ MNG-4751 ]
Hide
Permalink
Herve Boutemy added a comment -

perhaps the version range algorithm should accept every snapshots when no upper-bound limit is set: when a range does not precisely know its target version, this snapshot restrictions can't apply
this would fix this precise case where version ranges are used for RequireMavenVersion rule, I don't know if this would be ok for other use

Show
Herve Boutemy added a comment - perhaps the version range algorithm should accept every snapshots when no upper-bound limit is set: when a range does not precisely know its target version, this snapshot restrictions can't apply this would fix this precise case where version ranges are used for RequireMavenVersion rule, I don't know if this would be ok for other use
Hide
Permalink
Herve Boutemy added a comment -

this would fix this precise case where version ranges are used for RequireMavenVersion rule, I don't know if this would be ok for other use

I have found the answer: no, this would not be ok because MRELEASE-216 has the exact contrary requirements

Show
Herve Boutemy added a comment - this would fix this precise case where version ranges are used for RequireMavenVersion rule, I don't know if this would be ok for other use I have found the answer: no, this would not be ok because MRELEASE-216 has the exact contrary requirements
Herve Boutemy made changes -
Link This issue is related to MRELEASE-216 [ MRELEASE-216 ]
Dennis Lundberg made changes -
Link This issue is related to MENFORCER-101 [ MENFORCER-101 ]

People

  • Assignee:
    Unassigned
    Reporter:
    Benjamin Bentmann
Vote (2)
Watch (3)

Dates

  • Created:
    Updated: