Add Maven version used to Created-By entry in manifest

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.3
  • Fix Version/s: 2.4
  • Labels:
    None
  • Environment:
    n/a

Description

Upgrade the dependency to org.apache.maven:maven-archiver to newer version (when released) to get the version of Maven Core used for building included in the Created-By manifest entry. The call to MavenArchiver also needs to be slightly updated to pass along the MavenSession.

  1. Text File
    MEJB-56_onlymaincode.patch
    25/Jan/12 2:15 AM
    2 kB
    Anders Hammar
  2. Text File
    MEJB-56.patch
    24/Jan/12 2:18 AM
    6 kB
    Anders Hammar

Issue Links

depends upon

Bug - A problem which impairs or prevents the functions of the product. MSHARED-38 Archiver should be adding "Created-By: Apache Maven _2.0.4_" to the manifest

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
relates to

Improvement - An improvement or enhancement to an existing feature or task. MJAR-148 Add Maven version used to Created-By entry in manifest

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Anders Hammar added a comment -

Attached patch with implemented support. maven-archiver needs to be moved to v2.5 once released. I also needed to upgrade version of some dependencies.
I renamed one IT to be more manifest verification generic.

Show
Anders Hammar added a comment - Attached patch with implemented support. maven-archiver needs to be moved to v2.5 once released. I also needed to upgrade version of some dependencies. I renamed one IT to be more manifest verification generic.
Hide
Permalink
Anders Hammar added a comment -

It might also be worth analyzing the dependencies of the plugin. dependency:analyze shows there are some declarations missing.

Show
Anders Hammar added a comment - It might also be worth analyzing the dependencies of the plugin. dependency:analyze shows there are some declarations missing.
Hide
Permalink
Dennis Lundberg added a comment -

Hi Anders,

I tried applying your patch, but it doesn't apply for me. I'll try manually instead.

Just so that I've got it right: You renamed the src/it/manifest-classpath to src/it/manifest-content and modified the verify script by adding a check on the Created-By attribute?

Show
Dennis Lundberg added a comment - Hi Anders, I tried applying your patch, but it doesn't apply for me. I'll try manually instead. Just so that I've got it right: You renamed the src/it/manifest-classpath to src/it/manifest-content and modified the verify script by adding a check on the Created-By attribute?
Hide
Permalink
Anders Hammar added a comment -

Yes Dennis, that's right. I was a little bit worried that the patch wouldn't work. Not sure my Eclipse does the svn renaming correctly.
I've attached a new patch that only includes the main code changes. Apply that and fix the IT manually, please!

Show
Anders Hammar added a comment - Yes Dennis, that's right. I was a little bit worried that the patch wouldn't work. Not sure my Eclipse does the svn renaming correctly. I've attached a new patch that only includes the main code changes. Apply that and fix the IT manually, please!
Hide
Permalink
Dennis Lundberg added a comment -

Thanks for the patches! The onlymaincode patch was applied in r1235931 and manual modification of the IT was done in r1235935. Can you make sure that I got the manual modifications right?

Show
Dennis Lundberg added a comment - Thanks for the patches! The onlymaincode patch was applied in r1235931 and manual modification of the IT was done in r1235935. Can you make sure that I got the manual modifications right?
Hide
Permalink
Anders Hammar added a comment -

Yes, verified that it all looks good. You may close the ticket.

Show
Anders Hammar added a comment - Yes, verified that it all looks good. You may close the ticket.

People

  • Assignee:
    Dennis Lundberg
    Reporter:
    Anders Hammar
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: