Maven 2.x Eclipse Plugin

to-maven mojo does not handle source bundles correctly

Details

  • Type: Bug Bug
  • Status: Open Open
  • Priority: Minor Minor
  • Resolution: Unresolved
  • Affects Version/s: 2.9
  • Fix Version/s: None
  • Component/s: None
  • Labels:
    None
  • Environment:
    Any eclipse SDK version
  • Patch Submitted:
    Yes
  • Number of attachments :
    8

Description

the to-maven mojo does not install source bundles according to maven conventions. For example, the following plugins:

  1. org.eclipse.osgi_3.4.3.R34x_v20081215-1030.jar
  2. org.eclipse.osgi.source_3.4.3.R34x_v20081215-1030.jar

should be deployed respectively to:

  1. M2_REPO/org/eclipse/osgi/3.4.3-R34x_v20081215-1030/osgi-3.4.3-R34x_v20081215-1030.jar
  2. M2_REPO/org/eclipse/osgi/3.4.3-R34x_v20081215-1030/osgi-3.4.3-R34x_v20081215-1030-sources.jar

instead, they are deployed here:

  1. M2_REPO/org/eclipse/osgi/3.4.3-R34x_v20081215-1030/osgi-3.4.3-R34x_v20081215-1030.jar
  2. M2_REPO/org/eclipse/osgi/source/3.4.3-R34x_v20081215-1030/source-3.4.3-R34x_v20081215-1030.jar

To test this behaviour, I downloaded an eclipse sdk and ran the to-maven mojo in its unpacked installation directory

I am attaching a quick patch I devised to set the "sources" classifier on plugins whose name ends with ".source". I tried to minimize code changes, a revised implementation should probably modify createGroupId() and createArtifactId(), and avoid installing the pom for the sources jar.

  1. Text File
    build-post-patch.log
    13/Apr/12 3:50 AM
    209 kB
    Gabriele Catania
  2. Text File
    build-pre-patch.log
    13/Apr/12 3:50 AM
    381 kB
    Gabriele Catania
  3. Text File
    handle-sources.patch
    12/Apr/12 10:55 AM
    3 kB
    Gabriele Catania
  4. Text File
    MECLIPSE-719.patch
    13/Apr/12 3:53 AM
    9 kB
    Gabriele Catania
  5. Text File
    MECLIPSE-719.patch
    13/Apr/12 3:50 AM
    12 kB
    Gabriele Catania
  6. Text File
    MECLIPSE-719-fix-key.patch
    29/May/12 5:31 AM
    10 kB
    Gabriele Catania
  7. Text File
    MECLIPSE-719-fix-key-2.patch
    30/May/12 5:38 AM
    10 kB
    Gabriele Catania
  8. Text File
    MECLIPSE-719-fix-key-3.patch
    30/May/12 5:42 AM
    10 kB
    Gabriele Catania

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Gabriele Catania added a comment - - edited

I reworked my previous patch to use the correct method layout, adding createClassifier(), reworking createGroupId() and createArtifactId() and adding to the unit tests.

I am attaching the following:

  1. MECLIPSE-719.patch svn diff output of proposed patch and unit tests on EclipseToMavenMojo
  2. build-pre-patch.log build output of eclipse:to-maven with the current eclipse plugin on an eclipse 3.4 sdk directory
  3. build-post-patch.log build output of eclipse:to-maven with the patched eclipse plugin on an eclipse 3.4 sdk directory

the command I executed to produce the two outputs is:

mvn -e -X org.apache.maven.plugins:maven-eclipse-plugin:2.9:to-maven -DeclipseDir=.

(Please discard the first upload of MECLIPSE-719.patch since it contains incorrect formatting of the unit tests file)

Show
Gabriele Catania added a comment - - edited I reworked my previous patch to use the correct method layout, adding createClassifier() , reworking createGroupId() and createArtifactId() and adding to the unit tests. I am attaching the following: MECLIPSE-719 .patch svn diff output of proposed patch and unit tests on EclipseToMavenMojo build-pre-patch.log build output of eclipse:to-maven with the current eclipse plugin on an eclipse 3.4 sdk directory build-post-patch.log build output of eclipse:to-maven with the patched eclipse plugin on an eclipse 3.4 sdk directory the command I executed to produce the two outputs is: mvn -e -X org.apache.maven.plugins:maven-eclipse-plugin:2.9:to-maven -DeclipseDir=. (Please discard the first upload of MECLIPSE-719 .patch since it contains incorrect formatting of the unit tests file)
Hide
Permalink
Gabriele Catania added a comment -

I found a major flaw in the previously submitted patches: key collisions between jar and source artifacts would prevent jar artifacts from being deployed when a source artifact was present.

I am attaching another patch with a modified key generation algorithm, please discard previous patches.

Show
Gabriele Catania added a comment - I found a major flaw in the previously submitted patches: key collisions between jar and source artifacts would prevent jar artifacts from being deployed when a source artifact was present. I am attaching another patch with a modified key generation algorithm, please discard previous patches.
Hide
Permalink
Gabriele Catania added a comment -

Attaching another update to the patch since the previous didn't handle null classifiers correctly

Show
Gabriele Catania added a comment - Attaching another update to the patch since the previous didn't handle null classifiers correctly
Hide
Permalink
Giedrius Noreikis added a comment -

I guess it's a duplicate of MECLIPSE-575.

Show
Giedrius Noreikis added a comment - I guess it's a duplicate of MECLIPSE-575 .

People

  • Assignee:
    Unassigned
    Reporter:
    Gabriele Catania
Vote (0)
Watch (2)

Dates

  • Created:
    Updated: