Maven 2.x Eclipse Plugin

MECLIPSE-156 wasn't resolved

Details

  • Type: Bug Bug
  • Status: Open Open
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: 2.7
  • Fix Version/s: None
  • Component/s: Core : Workspace settings
  • Labels:
    None
  • Number of attachments :
    2

Description

Task MECLIPSE-156 wasn't correctly implemented and the proposed feature (namely, that the plugin should support setting file encoding) does not work. I think that only one of the proposed patches there were implemented (on IdeUtils.java) while the other (on EclipseUtils.java) one wasn't.

  1. Text File
    MECLIPSE-636-withTests.patch
    02/May/10 9:37 AM
    20 kB
    Ramiro Pereira de Magalhães
  2. Text File
    patch-MECLIPSE-636.patch
    29/Apr/10 3:22 AM
    14 kB
    Ramiro Pereira de Magalhães

Issue Links

is related to

Bug - A problem which impairs or prevents the functions of the product. MECLIPSE-616 r826602 probably introduced a bug. sourceEncoding handling

  • Major - Major loss of function.
  • Open - The issue is open and ready for the assignee to start work on it.

New Feature - A new feature of the product, which has yet to be developed. MECLIPSE-156 Plugin should support setting file encoding

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
relates to

New Feature - A new feature of the product, which has yet to be developed. MECLIPSE-156 Plugin should support setting file encoding

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Ramiro Pereira de Magalhães made changes -
Field Original Value New Value
Link This issue is related to MECLIPSE-156 [ MECLIPSE-156 ]
Hide
Permalink
Ramiro Pereira de Magalhães added a comment -

A suggetion: I guess you should allow people to reopen issues.

Show
Ramiro Pereira de Magalhães added a comment - A suggetion: I guess you should allow people to reopen issues.
Hide
Permalink
Ramiro Pereira de Magalhães added a comment - - edited

Just to be a little more clear: I think that this patch http://jira.codehaus.org/secure/attachment/34526/MECLIPSE-156-maven-eclipse-plugin.patch wasn't applied but should have been.

I'd also like to add that I did not find any documentation about that property.

Show
Ramiro Pereira de Magalhães added a comment - - edited Just to be a little more clear: I think that this patch http://jira.codehaus.org/secure/attachment/34526/MECLIPSE-156-maven-eclipse-plugin.patch wasn't applied but should have been. I'd also like to add that I did not find any documentation about that property.
Hide
Permalink
Ramiro Pereira de Magalhães added a comment - - edited

Added a patch that solves this issue using patches and suggestions from MECLIPSE-156. Now, eclipse:eclipse uses the <encoding> text from the maven-compiler-plugin to set source code's and resources' encoding. It does not set the global encoding setting of an Eclipse project, so only the source and resource folders will have the encoding set. Also, fixed the eclipse:clean mojo, allowing it to properly exclude the .settings/org.eclipse.core.resources.prefs file which contains such preferences.

Show
Ramiro Pereira de Magalhães added a comment - - edited Added a patch that solves this issue using patches and suggestions from MECLIPSE-156 . Now, eclipse:eclipse uses the <encoding> text from the maven-compiler-plugin to set source code's and resources' encoding. It does not set the global encoding setting of an Eclipse project, so only the source and resource folders will have the encoding set. Also, fixed the eclipse:clean mojo, allowing it to properly exclude the .settings/org.eclipse.core.resources.prefs file which contains such preferences.
Ramiro Pereira de Magalhães made changes -
Attachment patch-MECLIPSE-636.patch [ 48732 ]
Ramiro Pereira de Magalhães made changes -
Link This issue is related to MECLIPSE-616 [ MECLIPSE-616 ]
Barrie Treloar made changes -
Link This issue relates to MECLIPSE-156 [ MECLIPSE-156 ]
Hide
Permalink
Barrie Treloar added a comment -

Issues shouldn't be re-opened since they are closed and marked fixed against a particular version. If they are not implemented correctly then a new issue (like you have raised) should be created and linked to the first issue.

Show
Barrie Treloar added a comment - Issues shouldn't be re-opened since they are closed and marked fixed against a particular version. If they are not implemented correctly then a new issue (like you have raised) should be created and linked to the first issue.
Hide
Permalink
Ramiro Pereira de Magalhães added a comment -

I upload a new patch that fixes some small problems with the previous patch. This patch also includes a test case that ensures the correct preference file contains the needed configuration for a Eclipse's project source code and resource file encoding works properly.

Show
Ramiro Pereira de Magalhães added a comment - I upload a new patch that fixes some small problems with the previous patch. This patch also includes a test case that ensures the correct preference file contains the needed configuration for a Eclipse's project source code and resource file encoding works properly.
Ramiro Pereira de Magalhães made changes -
Attachment MECLIPSE-636-withTests.patch [ 48787 ]
Hide
Permalink
Ramiro Pereira de Magalhães added a comment -

Hey, guys, I uploaded a patch that has a fix for this issue and the a test case that shows the problem is solved, but it has not been applied yet. Am I missing something? Is there anything else I can do to help you solve this issue?

Show
Ramiro Pereira de Magalhães added a comment - Hey, guys, I uploaded a patch that has a fix for this issue and the a test case that shows the problem is solved, but it has not been applied yet. Am I missing something? Is there anything else I can do to help you solve this issue?
fabrizio giustina made changes -
Assignee fabrizio giustina [ fgiust ]
Hide
Permalink
Diego Gomes added a comment -

Hello, do we have any news about this issue? it's like a really important issue for people who use encoding.

Show
Diego Gomes added a comment - Hello, do we have any news about this issue? it's like a really important issue for people who use encoding.
Hide
Permalink
Anthony O. added a comment -

I've seen a similar bug report here : https://issues.sonatype.org/browse/MNGECLIPSE-1782

I've used this workaround :

<plugin>
	<groupId>org.apache.maven.plugins</groupId>
	<artifactId>maven-eclipse-plugin</artifactId>
	<version>2.8</version>
	<configuration>
		<downloadSources>true</downloadSources>
		<downloadJavadocs>true</downloadJavadocs>
		<wtpmanifest>true</wtpmanifest>
		<wtpapplicationxml>false</wtpapplicationxml>
		<wtpversion>2.0</wtpversion>
		<additionalConfig>
			<file>
				<name>.settings/org.eclipse.core.resources.prefs</name>
				<content>
<![CDATA[eclipse.preferences.version=1
encoding/<project>=UTF-8]]>
				</content>
			</file>
		</additionalConfig>
	</configuration>
</plugin>
Show
Anthony O. added a comment - I've seen a similar bug report here : https://issues.sonatype.org/browse/MNGECLIPSE-1782 I've used this workaround : <plugin> <groupId>org.apache.maven.plugins</groupId> <artifactId>maven-eclipse-plugin</artifactId> <version>2.8</version> <configuration> <downloadSources>true</downloadSources> <downloadJavadocs>true</downloadJavadocs> <wtpmanifest>true</wtpmanifest> <wtpapplicationxml>false</wtpapplicationxml> <wtpversion>2.0</wtpversion> <additionalConfig> <file> <name>.settings/org.eclipse.core.resources.prefs</name> <content> <![CDATA[eclipse.preferences.version=1 encoding/<project>=UTF-8]]> </content> </file> </additionalConfig> </configuration> </plugin>

People

  • Assignee:
    fabrizio giustina
    Reporter:
    Ramiro Pereira de Magalhães
Vote (4)
Watch (4)

Dates

  • Created:
    Updated: