Maven 2.x Eclipse Plugin

to-maven mojo install source plugins as ordinay plugins. It should install the source plugins as classified as 'sources'

Details

  • Type: Improvement Improvement
  • Status: Open Open
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: 2.7
  • Fix Version/s: None
  • Component/s: PDE support
  • Labels:
    None
  • Environment:
    N/A
  • Patch Submitted:
    Yes
  • Number of attachments :
    3

Description

to-maven mojo install source plugins as ordinay plugins. It should install the source plugins as classified as 'sources'

Say you have the source plugins along with your plugins. ie: here's what you would get:

[hceylan@ceylan ~]$ ll /home/hceylan/.m2/repository/org/eclipse/core/runtime/3.5.100-v20090629/
rw-rw-r- 1 hceylan hceylan 69652 2009-09-10 22:12 runtime-3.5.100-v20090629.jar
rw-rw-r- 1 hceylan hceylan 1741 2009-09-10 22:12 runtime-3.5.100-v20090629.pom
drw-rw-r-- 1 hceylan hceylan 86072 2009-09-10 22:12 source

Instead you should get the following:
[hceylan@ceylan ~]$ ll /home/hceylan/.m2/repository/org/eclipse/core/runtime/3.5.100-v20090629/
rw-rw-r- 1 hceylan hceylan 69652 2009-09-10 22:12 runtime-3.5.100-v20090629.jar
rw-rw-r- 1 hceylan hceylan 1741 2009-09-10 22:12 runtime-3.5.100-v20090629.pom
rw-rw-r- 1 hceylan hceylan 86072 2009-09-10 22:12 runtime-3.5.100-v20090629-sources.jar

Attached patch resolves that issue.

  1. Text File
    source-plugin.patch
    10/Sep/09 3:03 PM
    6 kB
    Hasan Ceylan
  2. Text File
    source-plugin.patch
    10/Sep/09 2:56 PM
    6 kB
    Hasan Ceylan
  3. Text File
    source-plugin.patch
    10/Sep/09 2:38 PM
    6 kB
    Hasan Ceylan

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Hasan Ceylan added a comment -

Modified version for inclusion of ix to http://jira.codehaus.org/browse/MECLIPSE-601

Show
Hasan Ceylan added a comment - Modified version for inclusion of ix to http://jira.codehaus.org/browse/MECLIPSE-601
Hide
Permalink
Hasan Ceylan added a comment -

There was one small mistake in the patch #2. Ignore it and use that one

Show
Hasan Ceylan added a comment - There was one small mistake in the patch #2. Ignore it and use that one
Hide
Permalink
Peter Lynch added a comment -

Hi Hasan

I've applied and tested the patch locally. Looks good, although I am going to take a shot at adding some integration tests for the ToMaven mojo before trying to commit the whole works.

I am an former Maven committer but since I've been out of the commit loop for a while I need to touch base with some core developers before doing the actual commit to trunk.

Show
Peter Lynch added a comment - Hi Hasan I've applied and tested the patch locally. Looks good, although I am going to take a shot at adding some integration tests for the ToMaven mojo before trying to commit the whole works. I am an former Maven committer but since I've been out of the commit loop for a while I need to touch base with some core developers before doing the actual commit to trunk.
Hide
Permalink
Hasan Ceylan added a comment -

Thanks for the inclusion of the patch Peter...

Any news on that issue?

Hasan

Show
Hasan Ceylan added a comment - Thanks for the inclusion of the patch Peter... Any news on that issue? Hasan
Hide
Permalink
Peter Lynch added a comment - - edited

Providing the integration tests is next in my queue. Hopefully after that it will get applied soon.

Part of the delay was grokking in what format the integration tests need to be created. Getting back into the swing of things I am discovering each plugin rolls its own style.

Show
Peter Lynch added a comment - - edited Providing the integration tests is next in my queue. Hopefully after that it will get applied soon. Part of the delay was grokking in what format the integration tests need to be created. Getting back into the swing of things I am discovering each plugin rolls its own style.

People

  • Assignee:
    Unassigned
    Reporter:
    Hasan Ceylan
Vote (1)
Watch (2)

Dates

  • Created:
    Updated: