Maven 2.x Eclipse Plugin

Ajdt support needs to include*.aj on the classpath.

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.6
  • Fix Version/s: 2.7
  • Component/s: AJDT support
  • Labels:
    None
  • Number of attachments :
    0

Description

MECLIPSE-443 broken ajdt support as *.java files are now specified as "included" where previously this was empty.
This means that *.aj files are no longer on the classpath and this break ajdt support.

Issue Links

is duplicated by

Bug - A problem which impairs or prevents the functions of the product. MECLIPSE-553 Maven Eciipse Plugin 2.6 excludes *.aj files from src/main/java

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
is related to

Bug - A problem which impairs or prevents the functions of the product. MECLIPSE-551 [regression] Resources are excluded if resource dir equals source dir

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
is superceded by

New Feature - A new feature of the product, which has yet to be developed. MECLIPSE-104 Add the ability to specify source inclusions/exclusions

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Barrie Treloar added a comment -

Moved inclusion/exclusion patterns out of EclipseClasspathWriter and into EclipsePlugin extract methods where the EclipseSourceDir gets created and defines the includes/excludes.

If ajdt is enable then all sources directories will include */.aj files.

The aspect directory will also include */.java files.

Added toString() to EclipseSourceDir.

The generated resource directory for manifest handling (target/generated-resources/eclipse) no longer exclude java files.
Since we create that directory and copy the MANIFEST.MF file into it there isn't much need for exclusion.
Test cases updated to reflect this.

Test case for MECLIPSE-538 created.

Show
Barrie Treloar added a comment - Moved inclusion/exclusion patterns out of EclipseClasspathWriter and into EclipsePlugin extract methods where the EclipseSourceDir gets created and defines the includes/excludes. If ajdt is enable then all sources directories will include * / .aj files. The aspect directory will also include * / .java files. Added toString() to EclipseSourceDir. The generated resource directory for manifest handling (target/generated-resources/eclipse) no longer exclude java files. Since we create that directory and copy the MANIFEST.MF file into it there isn't much need for exclusion. Test cases updated to reflect this. Test case for MECLIPSE-538 created.
Hide
Permalink
Andrew Eisenberg added a comment -

Will this fix be included in 2.6.1 (if this build occurs)?

Show
Andrew Eisenberg added a comment - Will this fix be included in 2.6.1 (if this build occurs)?
Hide
Permalink
Barrie Treloar added a comment -

No 2.6.1 has been renamed to 2.7.
As the consensus was that even though the issues fixed resolved a regression issue they did so by adding new features.

Arnaud is working on getting 2.7 out shortly.

Show
Barrie Treloar added a comment - No 2.6.1 has been renamed to 2.7. As the consensus was that even though the issues fixed resolved a regression issue they did so by adding new features. Arnaud is working on getting 2.7 out shortly.

People

  • Assignee:
    Barrie Treloar
    Reporter:
    Barrie Treloar
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: