Maven Eclipse Plugin
  1. Maven Eclipse Plugin
  2. MECLIPSE-449

Facet Generation generates duplicate entries - breaks RAD/RSA support

    Details

    • Type: Bug Bug
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Won't Fix
    • Affects Version/s: 2.5.1
    • Fix Version/s: None
    • Component/s: WTP support
    • Labels:
      None
    • Environment:
      WinXP, IBM RSA V7.0.0.6 (Eclipse 3.2.2)
    • Number of attachments :
      3

      Description

      Using V2.5.1 of the maven-eclipse-plugin, I have some issues in getting the generated artifacts being correct.

      Take this section of the POM:

      <additionalProjectFacets>
      <jst.java>5.0</jst.java>
      <jst.ejb>2.1</jst.ejb>
      <com.ibm.websphere.extended.ejb>6.1</com.ibm.websphere.extended.ejb>
      </additionalProjectFacets>

      Generates this:

      <faceted-project>
      <fixed facet="jst.java"/>
      <fixed facet="jst.utility"/>
      <installed facet="jst.utility" version="1.0"/>
      <installed facet="jst.java" version="5.0"/>
      <installed facet="com.ibm.websphere.extended.ejb" version="6.1"/>
      <installed facet="jst.ejb" version="2.1"/>
      <installed facet="jst.java" version="5.0"/>
      </faceted-project>

      You'll see that the jst.java facet is in there twice.

      Removing the facet from the list:

      <additionalProjectFacets>
      <jst.ejb>2.1</jst.ejb>
      <com.ibm.websphere.extended.ejb>6.1</com.ibm.websphere.extended.ejb>
      </additionalProjectFacets>

      Generates this:

      <faceted-project>
      <fixed facet="jst.java"/>
      <fixed facet="jst.utility"/>
      <installed facet="jst.utility" version="1.0"/>
      <installed facet="jst.java" version="5.0"/>
      <installed facet="com.ibm.websphere.extended.ejb" version="6.1"/>
      <installed facet="jst.ejb" version="2.1"/>
      </faceted-project>

      Which is a little more correct.

      I consider this a bug, as the facets (by their very definition) are unique and should not be repeated.

      Additionally, when compared to a RSA (V7) generated one, it is missing the standard XML header:

      <?xml version="1.0" encoding="UTF-8"?>

      Also, where does the jst.utility facet come from?

      It's inclusion is getting in the way of RSA recognising it as a true J2EE component project (the EJB Deployment descriptor tree element does not display in the Project Explorer view in the J2EE Perspective).

      This is the complete RSA generated one, for reference:

      <?xml version="1.0" encoding="UTF-8"?>
      <faceted-project>
      <runtime name="WebSphere Application Server v6.1"/>
      <fixed facet="jst.ejb"/>
      <fixed facet="jst.java"/>
      <installed facet="jst.ejb" version="2.1"/>
      <installed facet="jst.java" version="5.0"/>
      <installed facet="com.ibm.websphere.extended.ejb" version="6.1"/>
      </faceted-project>

      (Which raises another question, how do we specify the runtime items and if something is fixed or not?)

      However, to get it to be correctly recognised, all we need is this:

      <faceted-project>
      <fixed facet="jst.java"/>
      <installed facet="jst.java" version="5.0"/>
      <installed facet="jst.ejb" version="2.1"/>
      <installed facet="com.ibm.websphere.extended.ejb" version="6.1"/>
      </faceted-project>

        Activity

        Hide
        Diego Gomes added a comment -

        Two attachments:

        • sample-error.zip: contains the files generated by eclipse:eclipse and the pom for error sample
        • sample-noerror.zip: contains the files generated by eclipse:eclipse and the pom for the workaround version
        Show
        Diego Gomes added a comment - Two attachments: sample-error.zip: contains the files generated by eclipse:eclipse and the pom for error sample sample-noerror.zip: contains the files generated by eclipse:eclipse and the pom for the workaround version
        Hide
        Nicolas Ternisien added a comment -

        Bug reproduced here.

        Show
        Nicolas Ternisien added a comment - Bug reproduced here.
        Hide
        Barrie Treloar added a comment -

        removed fixed version as no one has taken ownership to look into it.

        Show
        Barrie Treloar added a comment - removed fixed version as no one has taken ownership to look into it.
        Hide
        Michael Osipov added a comment -

        Please refer to https://cwiki.apache.org/confluence/display/MAVEN/The+Great+JIRA+Cleanup+of+2014 if you're wondering why this issue was closed out.

        Show
        Michael Osipov added a comment - Please refer to https://cwiki.apache.org/confluence/display/MAVEN/The+Great+JIRA+Cleanup+of+2014 if you're wondering why this issue was closed out.
        Hide
        Diego Gomes added a comment -

        @Michael Osipov I'm not the owner of the issue, but the bug still reproducible with the sample errors I`ve included here in 25/Aug/10

        Show
        Diego Gomes added a comment - @Michael Osipov I'm not the owner of the issue, but the bug still reproducible with the sample errors I`ve included here in 25/Aug/10

          People

          • Assignee:
            Unassigned
            Reporter:
            Chris Graham
          • Votes:
            5 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: