Maven 2.x Eclipse Plugin

use project.build.finalName for WTP context-root (if specified)

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.0
  • Fix Version/s: 2.1
  • Component/s: None
  • Labels:
    None
  • Environment:
    java on linux, maven 2.0
  • Number of attachments :
    0

Description

When the regular maven build creates a *.war file, it honors the project.build.finalName if specified. However, the maven-eclipse-plugin always uses the artifactId of the project and therefore the *.war file generated by eclipse is different than the one generated by maven.

The following code in EclipseWtpmodulesWriter.java can resolve the correct context-root and should be used for setting the "deploy-name" and the "context-root".

String contextRoot = project.getArtifactId();
String finalName = project.getBuild().getFinalName();
if ( !finalName.equals( project.getArtifactId() + "-" + project.getVersion() ) )

{ contextRoot = finalName; }

Issue Links

is related to

Bug - A problem which impairs or prevents the functions of the product. MECLIPSE-667 (regression) use project.build.finalName for WTP context-root (if specified)

  • Major - Major loss of function.
  • Open - The issue is open and ready for the assignee to start work on it.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
fabrizio giustina added a comment -

fix in svn for 2.1, thansk

Show
fabrizio giustina added a comment - fix in svn for 2.1, thansk
Hide
Permalink
Shelley Baker added a comment -

This is not resolved in the .component file, as of version 2.3. The deploy-path is still hard-coded and the context-root is always set to the artifactId in EclipseWtpComponentWriter/ EclipseWtpComponent15Writer:

writer.addAttribute( ATTR_CONTEXT_ROOT, config.getProject().getArtifactId() );
writer.addAttribute( ATTR_DEPLOY_PATH, "/" );

Show
Shelley Baker added a comment - This is not resolved in the .component file, as of version 2.3. The deploy-path is still hard-coded and the context-root is always set to the artifactId in EclipseWtpComponentWriter/ EclipseWtpComponent15Writer: writer.addAttribute( ATTR_CONTEXT_ROOT, config.getProject().getArtifactId() ); writer.addAttribute( ATTR_DEPLOY_PATH, "/" );
Hide
Permalink
Dan Tran added a comment -

Could you please reopen this issue?

Show
Dan Tran added a comment - Could you please reopen this issue?
Hide
Permalink
Johan Ferner added a comment -

This problem still exists. Could someone reopen this issue

Show
Johan Ferner added a comment - This problem still exists. Could someone reopen this issue
Hide
Permalink
Stevo Slavic added a comment -

eclipse-maven-plugin:2.8 can be configured via wtpContextName parameter to use project.build.finalName as context name e.g.

pom.xml
...
<plugin>
  <groupId>org.apache.maven.plugins</groupId>
  <artifactId>maven-eclipse-plugin</artifactId>
  <configuration>
    <wtpContextName>${project.build.finalName}</wtpContextName>
  </configuration>
</plugin>
...
Show
Stevo Slavic added a comment - eclipse-maven-plugin:2.8 can be configured via wtpContextName parameter to use project.build.finalName as context name e.g. pom.xml ... <plugin> <groupId>org.apache.maven.plugins</groupId> <artifactId>maven-eclipse-plugin</artifactId> <configuration> <wtpContextName>${project.build.finalName}</wtpContextName> </configuration> </plugin> ...

People

  • Assignee:
    fabrizio giustina
    Reporter:
    Dan Allen
Vote (0)
Watch (3)

Dates

  • Created:
    Updated:
    Resolved: