Maven 2.x Eclipse Plugin

connecting existing workspace artifact-projects

Details

  • Patch Submitted:
    Yes
  • Number of attachments :
    7

Description

This patch enables you to specify your workspace, and all dependent artefacts that are available in your eclipse-workspace will be attached as project references even if they are not in the reactor.

the property can be set with -DworkspaceToConnect=.....

I did not have the time to create Test cases but, i maybe someone can help with that!

The patch is based on the MECLIPSE-333 branch.

as usual the new files are in the extra tgz.

Attachments

  1. Text File
    MECLIPSE-344.patch
    23/Nov/07 9:02 AM
    99 kB
    Richard van Nieuwenhoven
  2. File
    MECLIPSE-344.tgz
    23/Nov/07 9:02 AM
    1 kB
    Richard van Nieuwenhoven
  3. Text File
    MECLIPSE-344+rad7.patch
    20/Dec/07 9:49 AM
    88 kB
    Richard van Nieuwenhoven
  4. File
    MECLIPSE-344+rad7.tgz
    20/Dec/07 9:49 AM
    1 kB
    Richard van Nieuwenhoven
  5. Text File
    workspace_with_limit.patch
    20/Nov/07 4:02 AM
    14 kB
    Richard van Nieuwenhoven
  6. Text File
    workspace.patch
    14/Nov/07 5:31 AM
    11 kB
    Richard van Nieuwenhoven
  7. File
    workspace-new-files.tgz
    14/Nov/07 5:31 AM
    10 kB
    Richard van Nieuwenhoven

Issue Links

This issue relates to:
MECLIPSE-341 Support RAD7 Major Closed
MECLIPSE-158 Add the ability to selectively treat a referenced project as a local repository file Major Closed
MECLIPSE-334 Add a rule that determined artifacts will be always recognized as reactor projects Major Closed
MECLIPSE-197 Automatic reference of dependee projects Major Closed
MECLIPSE-74 Workspace inspection when adding a project Major Closed
MECLIPSE-32 Allow for forcing the creation of direct project references for dependencies Major Closed
MECLIPSE-256 [PATCH]Flat Maven2 Multiproject Structures and Classpath Resolution as Projects (not binaries) Major Closed
This issue is related to:
MECLIPSE-260 Ignore artifact version mismatches on creating references to sub-projects Minor Closed
MECLIPSE-120 Force inter-project dependencies Major Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Richard van Nieuwenhoven added a comment -

typo the property is -Declipse.workspaceToConnect=...

Show
Richard van Nieuwenhoven added a comment - typo the property is -Declipse.workspaceToConnect=...
Hide
Permalink
Richard van Nieuwenhoven added a comment -

There are a few jira's about exluding some projects from using project references. Now this is rather easy done if the workspace is known.

I extended the patch to include the option:

-Declipse.limitProjectReferencesToWorkspace=true

This option will force projects that are not in the workspace but in the reactor to be used as jars.

this patch includes the original patch!

Show
Richard van Nieuwenhoven added a comment - There are a few jira's about exluding some projects from using project references. Now this is rather easy done if the workspace is known. I extended the patch to include the option: -Declipse.limitProjectReferencesToWorkspace=true This option will force projects that are not in the workspace but in the reactor to be used as jars. this patch includes the original patch!
Hide
Permalink
Arnaud Heritier added a comment -

One question about your patch : Why did you call the configuration variable for the workspace : workspaceToConnect
I believed there was already a workspace var but it's not the case.
The workspace is in the new Mojo for workspace configuration.

Show
Arnaud Heritier added a comment - One question about your patch : Why did you call the configuration variable for the workspace : workspaceToConnect I believed there was already a workspace var but it's not the case. The workspace is in the new Mojo for workspace configuration.
Hide
Permalink
Richard van Nieuwenhoven added a comment -

a good question! the problem is that the eclipse.workspace variable is used for something different.
And i didn't want to break the old behavior!

Could you check if it it is still needed? maybe even deprecate it?

Show
Richard van Nieuwenhoven added a comment - a good question! the problem is that the eclipse.workspace variable is used for something different. And i didn't want to break the old behavior! Could you check if it it is still needed? maybe even deprecate it?
Hide
Permalink
Richard van Nieuwenhoven added a comment -

updated the patch to include test cases for the workspace code!

included is now:

  • connect to artefact's available in the workspace as projects
  • use the correct default class path container depending on the compiler
  • exclude artefact's from using project references (by removing them from the workspace)

I did not have the time to refactor the workspace reader stuff... Creating tests took a lot of time..

But i think we should split the workspace configuration class in a class not eclipse specific and an eclipse specific subclass.

Show
Richard van Nieuwenhoven added a comment - updated the patch to include test cases for the workspace code! included is now:
  • connect to artefact's available in the workspace as projects
  • use the correct default class path container depending on the compiler
  • exclude artefact's from using project references (by removing them from the workspace)
I did not have the time to refactor the workspace reader stuff... Creating tests took a lot of time.. But i think we should split the workspace configuration class in a class not eclipse specific and an eclipse specific subclass.
Hide
Permalink
Richard van Nieuwenhoven added a comment -

these two include the complete patch on the today trunk R597676

the others are old and included.

Show
Richard van Nieuwenhoven added a comment - these two include the complete patch on the today trunk R597676 the others are old and included.
Hide
Permalink
Richard van Nieuwenhoven added a comment -

a small fix for my patch that will give the class path container lookup partly back to eclipse.

--------ReadWorkspaceLocations--------------
//add constant
private static final String CLASSPATHENTRY_STANDARD = CLASSPATHENTRY_DEFAULT+"/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/";
--------ReadWorkspaceLocations--------------
//change the method to add defaults known by eclipse
public static HashMap readAvailableJREs( String workspaceLocation, Log logger )
{
HashMap jreMap = new HashMap();
jreMap.put( "1.2", CLASSPATHENTRY_STANDARD+"J2SE-1.2" );
jreMap.put( "1.3", CLASSPATHENTRY_STANDARD+"J2SE-1.3" );
jreMap.put( "1.4", CLASSPATHENTRY_STANDARD+"J2SE-1.4" );
jreMap.put( "1.5", CLASSPATHENTRY_STANDARD+"J2SE-1.5" );
jreMap.put( "5", jreMap.get("1.5") );
jreMap.put( "1.6", CLASSPATHENTRY_STANDARD+"JavaSE-1.6" );
jreMap.put( "6", jreMap.get("1.6") );
--------EclipsePluginTest--------------
// changed test result in testProject38and39()
doTestProject38and39( "project-38", workspace15, "J2SE-1.3" ,null);
-----------------------------------------

Show
Richard van Nieuwenhoven added a comment - a small fix for my patch that will give the class path container lookup partly back to eclipse. --------ReadWorkspaceLocations-------------- //add constant private static final String CLASSPATHENTRY_STANDARD = CLASSPATHENTRY_DEFAULT+"/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/"; --------ReadWorkspaceLocations-------------- //change the method to add defaults known by eclipse public static HashMap readAvailableJREs( String workspaceLocation, Log logger ) { HashMap jreMap = new HashMap(); jreMap.put( "1.2", CLASSPATHENTRY_STANDARD+"J2SE-1.2" ); jreMap.put( "1.3", CLASSPATHENTRY_STANDARD+"J2SE-1.3" ); jreMap.put( "1.4", CLASSPATHENTRY_STANDARD+"J2SE-1.4" ); jreMap.put( "1.5", CLASSPATHENTRY_STANDARD+"J2SE-1.5" ); jreMap.put( "5", jreMap.get("1.5") ); jreMap.put( "1.6", CLASSPATHENTRY_STANDARD+"JavaSE-1.6" ); jreMap.put( "6", jreMap.get("1.6") ); --------EclipsePluginTest-------------- // changed test result in testProject38and39() doTestProject38and39( "project-38", workspace15, "J2SE-1.3" ,null); -----------------------------------------
Hide
Permalink
Martin Zeltner added a comment -

After the discussion with Richie I'm convinced now that the MECLIPSE-344 covers my needs (MECLIPSE-334) too. But dealing with files in the workspace folder looks to me a bit dangerous because they seem to be not so stable in their format as the .project and .classpath. Can anyone give me a link to documentation that convince me that the amount and the formats of these files are stable?

Cheers,
Martin

Show
Martin Zeltner added a comment - After the discussion with Richie I'm convinced now that the MECLIPSE-344 covers my needs (MECLIPSE-334) too. But dealing with files in the workspace folder looks to me a bit dangerous because they seem to be not so stable in their format as the .project and .classpath. Can anyone give me a link to documentation that convince me that the amount and the formats of these files are stable? Cheers, Martin
Hide
Permalink
Richard van Nieuwenhoven added a comment -

this part of file format did not change since 2.0 and that's a long time. It is also protected by a magic code so no version incompatibility possible.

And we will now use a dependency to the original eclipse (binaries) to read them, so i think we are on the save side here

Show
Richard van Nieuwenhoven added a comment - this part of file format did not change since 2.0 and that's a long time. It is also protected by a magic code so no version incompatibility possible. And we will now use a dependency to the original eclipse (binaries) to read them, so i think we are on the save side here
Hide
Permalink
Richard van Nieuwenhoven added a comment -

Updated the patch for the current snapshot and included the standard JRE resolution of eclipse.

The workspace scanning is now re factored to reader and data class.

Now also included is the RAD-7 support (that needs the workspace reading) with tests.

to use the RAD-7 support the option

  • workspaceToConnect must point to the current workspace directory (use ${workspace_loc} in eclipse launches)
  • wtpdefaultserver contains the exact name or a substring of the defined wtp server to use
Show
Richard van Nieuwenhoven added a comment - Updated the patch for the current snapshot and included the standard JRE resolution of eclipse. The workspace scanning is now re factored to reader and data class. Now also included is the RAD-7 support (that needs the workspace reading) with tests. to use the RAD-7 support the option
  • workspaceToConnect must point to the current workspace directory (use ${workspace_loc} in eclipse launches)
  • wtpdefaultserver contains the exact name or a substring of the defined wtp server to use
Hide
Permalink
Benjamin Baril added a comment -

MECLIPSE-344+rad7.tgz is 1kb and does not contain the binary as stated in the above comment.

Show
Benjamin Baril added a comment - MECLIPSE-344+rad7.tgz is 1kb and does not contain the binary as stated in the above comment.
Hide
Permalink
Richard van Nieuwenhoven added a comment -

it contains the binary files for the patch! "svn diff" can not handle binary files.

Show
Richard van Nieuwenhoven added a comment - it contains the binary files for the patch! "svn diff" can not handle binary files.
Hide
Permalink
Benjamin Baril added a comment -

Ahh, ok, I misunderstood the comment.

Building now

Show
Benjamin Baril added a comment - Ahh, ok, I misunderstood the comment. Building now
Hide
Permalink
David J. M. Karlsen added a comment -

This issue is related to: http://jira.codehaus.org/browse/MECLIPSE-341

Show
David J. M. Karlsen added a comment - This issue is related to: http://jira.codehaus.org/browse/MECLIPSE-341
Hide
Permalink
Arnaud Heritier added a comment -

This issue is fixed. Thanks for all patches submitted by Richard.
To try the latest SNAPSHOT (2.5-20080131.135640-18) of the incoming version you have to define and activate this profile :

<profile>
      <id>apache.snapshots</id>
      <repositories>
        <repository>
          <releases>
            <enabled>false</enabled>
          </releases>
          <snapshots/>
          <id>apache.snapshots</id>
          <name>Maven Snapshots</name>
          <url>http://people.apache.org/maven-snapshot-repository</url>
        </repository>
      </repositories>
      <pluginRepositories>
        <pluginRepository>
          <releases>
            <enabled>false</enabled>
          </releases>
          <snapshots/>
          <id>apache.plugin.snapshots</id>
          <name>Maven Plugin Snapshots</name>
          <url>http://people.apache.org/maven-snapshot-repository</url>
        </pluginRepository>
      </pluginRepositories>
    </profile>

Then you have to call this command :

mvn org.apache.maven.plugins:maven-eclipse-plugin:2.5-SNAPSHOT:eclipse
Show
Arnaud Heritier added a comment - This issue is fixed. Thanks for all patches submitted by Richard. To try the latest SNAPSHOT (2.5-20080131.135640-18) of the incoming version you have to define and activate this profile : 
<profile>
      <id>apache.snapshots</id>
      <repositories>
        <repository>
          <releases>
            <enabled>false</enabled>
          </releases>
          <snapshots/>
          <id>apache.snapshots</id>
          <name>Maven Snapshots</name>
          <url>http://people.apache.org/maven-snapshot-repository</url>
        </repository>
      </repositories>
      <pluginRepositories>
        <pluginRepository>
          <releases>
            <enabled>false</enabled>
          </releases>
          <snapshots/>
          <id>apache.plugin.snapshots</id>
          <name>Maven Plugin Snapshots</name>
          <url>http://people.apache.org/maven-snapshot-repository</url>
        </pluginRepository>
      </pluginRepositories>
    </profile>
Then you have to call this command : 
mvn org.apache.maven.plugins:maven-eclipse-plugin:2.5-SNAPSHOT:eclipse
Hide
Permalink
Arnaud Heritier added a comment -

We have a failure if the worspace doesn't exist and it could be a good idea to add a flag to activate this new feature only if asked (set to false by default).
http://www.nabble.com/maven-eclipse-plugin-2.5-coming-soon-td15207954s177.html

Show
Arnaud Heritier added a comment - We have a failure if the worspace doesn't exist and it could be a good idea to add a flag to activate this new feature only if asked (set to false by default). http://www.nabble.com/maven-eclipse-plugin-2.5-coming-soon-td15207954s177.html
Hide
Permalink
Joerg Schaible added a comment -

Will it link always all projects or is it possible to link only the SNAPSHOTs? The difference is, that with the information from the Eclipse workspace you don't have to rebuild all Eclipse files at once to get the SNAPSHOTs linked. You will have the information now to rebuild the Eclipse projects for a single submodule only, but have the SNAPSHOTs still linked. Therefore it would be really nice to have both operation modes.

Show
Joerg Schaible added a comment - Will it link always all projects or is it possible to link only the SNAPSHOTs? The difference is, that with the information from the Eclipse workspace you don't have to rebuild all Eclipse files at once to get the SNAPSHOTs linked. You will have the information now to rebuild the Eclipse projects for a single submodule only, but have the SNAPSHOTs still linked. Therefore it would be really nice to have both operation modes.
Hide
Permalink
Pedro added a comment -

I just noticed a small problem with this fix.
If you have a dependency on a project for source code and tests, the project is
added twice to the "Required projects in the build path".
This of course causes eclipse to complain that the project has been added twice.

<dependency>
<groupId>${project.groupId}</groupId>
<artifactId>outboundInterfaces</artifactId>
<classifier>${environment.type}</classifier>
</dependency>
<dependency>
<groupId>${project.groupId}</groupId>
<artifactId>outboundInterfaces</artifactId>
<version>${project.version}</version>
<type>test-jar</type>
<scope>test</scope>
</dependency>

Show
Pedro added a comment - I just noticed a small problem with this fix. If you have a dependency on a project for source code and tests, the project is added twice to the "Required projects in the build path". This of course causes eclipse to complain that the project has been added twice. <dependency> <groupId>${project.groupId}</groupId> <artifactId>outboundInterfaces</artifactId> <classifier>${environment.type}</classifier> </dependency> <dependency> <groupId>${project.groupId}</groupId> <artifactId>outboundInterfaces</artifactId> <version>${project.version}</version> <type>test-jar</type> <scope>test</scope> </dependency>
Hide
Permalink
Arnaud Heritier added a comment -

This last issue is reported in MECLIPSE-397 but I'm not surethat it is related to this one. You didn't have this problem with 2.4 ?

Show
Arnaud Heritier added a comment - This last issue is reported in MECLIPSE-397 but I'm not surethat it is related to this one. You didn't have this problem with 2.4 ?
Hide
Permalink
Arnaud Heritier added a comment -

I think we solved all problems discussed on the mailing list. I close the issue. Please open new ones if necessary

Show
Arnaud Heritier added a comment - I think we solved all problems discussed on the mailing list. I close the issue. Please open new ones if necessary
Hide
Permalink
Richard van Nieuwenhoven added a comment -

Only linking the SNAPSHOT's, can be done, the problem is the list of options are getting more and more complex and interweaving.

So i think it is best to make no new option but let the user decide with the eclipse means available (what's in the workspace will be linked).
I think the best solution is to import or delete (just from the workspace) the projects as needed and then let the eclipse plugin connect them.

Show
Richard van Nieuwenhoven added a comment - Only linking the SNAPSHOT's, can be done, the problem is the list of options are getting more and more complex and interweaving. So i think it is best to make no new option but let the user decide with the eclipse means available (what's in the workspace will be linked). I think the best solution is to import or delete (just from the workspace) the projects as needed and then let the eclipse plugin connect them.
Hide
Permalink
Barrie Treloar added a comment -

Not having an option as per http://jira.codehaus.org/browse/MECLIPSE-344#action_126688 makes sense to me.

If you have imported the project already into eclipse then link to it, otherwise use m2 repository.

Show
Barrie Treloar added a comment - Not having an option as per http://jira.codehaus.org/browse/MECLIPSE-344#action_126688 makes sense to me. If you have imported the project already into eclipse then link to it, otherwise use m2 repository.

People

Vote (9)
Watch (8)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.