|
[
Permalink
| « Hide
]
Richard van Nieuwenhoven added a comment - 14/Nov/07 06:01 AM
typo the property is -Declipse.workspaceToConnect=...
There are a few jira's about exluding some projects from using project references. Now this is rather easy done if the workspace is known.
I extended the patch to include the option: -Declipse.limitProjectReferencesToWorkspace=true This option will force projects that are not in the workspace but in the reactor to be used as jars. this patch includes the original patch! One question about your patch : Why did you call the configuration variable for the workspace : workspaceToConnect
I believed there was already a workspace var but it's not the case. The workspace is in the new Mojo for workspace configuration. a good question! the problem is that the eclipse.workspace variable is used for something different.
And i didn't want to break the old behavior! Could you check if it it is still needed? maybe even deprecate it? updated the patch to include test cases for the workspace code!
included is now:
I did not have the time to refactor the workspace reader stuff... Creating tests took a lot of time.. But i think we should split the workspace configuration class in a class not eclipse specific and an eclipse specific subclass. these two include the complete patch on the today trunk R597676
the others are old and included. a small fix for my patch that will give the class path container lookup partly back to eclipse.
-------- After the discussion with Richie I'm convinced now that the
Cheers, this part of file format did not change since 2.0 and that's a long time. It is also protected by a magic code so no version incompatibility possible.
And we will now use a dependency to the original eclipse (binaries) to read them, so i think we are on the save side here Updated the patch for the current snapshot and included the standard JRE resolution of eclipse.
The workspace scanning is now re factored to reader and data class. Now also included is the RAD-7 support (that needs the workspace reading) with tests.
to use the RAD-7 support the option
it contains the binary files for the patch! "svn diff" can not handle binary files.
Ahh, ok, I misunderstood the comment.
Building now This issue is related to: http://jira.codehaus.org/browse/MECLIPSE-341
This issue is fixed. Thanks for all patches submitted by Richard.
To try the latest SNAPSHOT (2.5-20080131.135640-18) of the incoming version you have to define and activate this profile : <profile>
<id>apache.snapshots</id>
<repositories>
<repository>
<releases>
<enabled>false</enabled>
</releases>
<snapshots/>
<id>apache.snapshots</id>
<name>Maven Snapshots</name>
<url>http://people.apache.org/maven-snapshot-repository</url>
</repository>
</repositories>
<pluginRepositories>
<pluginRepository>
<releases>
<enabled>false</enabled>
</releases>
<snapshots/>
<id>apache.plugin.snapshots</id>
<name>Maven Plugin Snapshots</name>
<url>http://people.apache.org/maven-snapshot-repository</url>
</pluginRepository>
</pluginRepositories>
</profile>
Then you have to call this command : mvn org.apache.maven.plugins:maven-eclipse-plugin:2.5-SNAPSHOT:eclipse We have a failure if the worspace doesn't exist and it could be a good idea to add a flag to activate this new feature only if asked (set to false by default).
http://www.nabble.com/maven-eclipse-plugin-2.5-coming-soon-td15207954s177.html Will it link always all projects or is it possible to link only the SNAPSHOTs? The difference is, that with the information from the Eclipse workspace you don't have to rebuild all Eclipse files at once to get the SNAPSHOTs linked. You will have the information now to rebuild the Eclipse projects for a single submodule only, but have the SNAPSHOTs still linked. Therefore it would be really nice to have both operation modes.
I just noticed a small problem with this fix.
If you have a dependency on a project for source code and tests, the project is added twice to the "Required projects in the build path". This of course causes eclipse to complain that the project has been added twice. <dependency> This last issue is reported in
I think we solved all problems discussed on the mailing list. I close the issue. Please open new ones if necessary
Only linking the SNAPSHOT's, can be done, the problem is the list of options are getting more and more complex and interweaving.
So i think it is best to make no new option but let the user decide with the eclipse means available (what's in the workspace will be linked). Not having an option as per http://jira.codehaus.org/browse/MECLIPSE-344#action_126688
If you have imported the project already into eclipse then link to it, otherwise use m2 repository. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||