Maven 2.x Eclipse Plugin

Please add support for the AJDT plugin

Details

  • Type: New Feature New Feature
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.2
  • Fix Version/s: 2.6
  • Component/s: AJDT support
  • Labels:
    None
  • Patch Submitted:
    Yes
  • Number of attachments :
    3

Description

Please add support for the AJDT plugin.

I have modified the eclipse plugin for our site with the needed changes. I have attached the modifications that I made for someone to look at and incorporate into the plugin.

  1. Text File
    ajdt.patch
    13/Mar/07 5:21 PM
    23 kB
    Carlos Sanchez

Issue Links

is depended upon by

Bug - A problem which impairs or prevents the functions of the product. MECLIPSE-544 aspectj libraries do not get included anymore with 2.6

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
is duplicated by

New Feature - A new feature of the product, which has yet to be developed. MECLIPSE-270 Add support for classpathentry attributes

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

New Feature - A new feature of the product, which has yet to be developed. MASPECTJ-46 Create eclipse goal on aspectJ plugin that supports AJDT 1.5

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
is related to

Improvement - An improvement or enhancement to an existing feature or task. MECLIPSE-547 Maven Eclipse plugin 2.6 with AJDT changes are not backwards compatible.

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
relates to

New Feature - A new feature of the product, which has yet to be developed. MECLIPSE-313 AJDT feature

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Carlos Sanchez added a comment -

Previous attachment in diff format

Show
Carlos Sanchez added a comment - Previous attachment in diff format
Hide
Permalink
Eric Berry added a comment - - edited

This has been updated for maven-eclipse-plugin 2.5.1 and also ajdt version 1.5.3. I have also included tests and updates to the site build to show how to use it.

Hopefully one of the commiters will be willing to look at this and incorporate it.

Show
Eric Berry added a comment - - edited This has been updated for maven-eclipse-plugin 2.5.1 and also ajdt version 1.5.3. I have also included tests and updates to the site build to show how to use it. Hopefully one of the commiters will be willing to look at this and incorporate it.
Hide
Permalink
Eric Berry added a comment -

Look at the 122kb maven-eclipse-plugin.zip.

Show
Eric Berry added a comment - Look at the 122kb maven-eclipse-plugin.zip.
Hide
Permalink
Arnaud Heritier added a comment -

Fixed and snapshot 2.6-20080902.232029-1 deployed. If you can test it ....

Show
Arnaud Heritier added a comment - Fixed and snapshot 2.6-20080902.232029-1 deployed. If you can test it ....
Hide
Permalink
Eric Berry added a comment -

Tested. It works as expected. Thanks.

Show
Eric Berry added a comment - Tested. It works as expected. Thanks.
Hide
Permalink
David J. M. Karlsen added a comment -

Is the site staged anywhere (to be able to see documentation of new parameters)

Show
David J. M. Karlsen added a comment - Is the site staged anywhere (to be able to see documentation of new parameters)
Hide
Permalink
Arnaud Heritier added a comment -

It will be in few hours here :
http://maven.apache.org/plugins/maven-eclipse-plugin-2.6-SNAPSHOT/

Show
Arnaud Heritier added a comment - It will be in few hours here : http://maven.apache.org/plugins/maven-eclipse-plugin-2.6-SNAPSHOT/
Hide
Permalink
Alexander Hachmann added a comment -

I can understand the wish for a AJDT-Plugin support, but I cannot understand
why this must have such an impact on projects that do not use that plugin.

As we do not use that plugin we now are having the problem that our projects
do not compile for the reason of the missing jars :-/

In my eyes this AJDT-Plugin Feature MUST be implemented in a more generic way.
Read the eclipse configurations whether that plugin is installed or something else.
But do not force other Projects to use the AJDT Plugin, just because the are workin
with AOP!!!!

Show
Alexander Hachmann added a comment - I can understand the wish for a AJDT-Plugin support, but I cannot understand why this must have such an impact on projects that do not use that plugin. As we do not use that plugin we now are having the problem that our projects do not compile for the reason of the missing jars :-/ In my eyes this AJDT-Plugin Feature MUST be implemented in a more generic way. Read the eclipse configurations whether that plugin is installed or something else. But do not force other Projects to use the AJDT Plugin, just because the are workin with AOP!!!!
Hide
Permalink
Arnaud Heritier added a comment -

Please open an new issue if this one creates a problem for you. A 2.7 is already on rails.

Show
Arnaud Heritier added a comment - Please open an new issue if this one creates a problem for you. A 2.7 is already on rails.
Hide
Permalink
Eric Berry added a comment - - edited

Alexander, In the configuration of the eclipse plugin add <ajdtVersion>none</ajdtVersion>. This should fix the problem.

There is hidden documentation here http://maven.apache.org/plugins/maven-eclipse-plugin/examples/ajdt-projects.html that describes how to use the ajdt plugin.

Show
Eric Berry added a comment - - edited Alexander, In the configuration of the eclipse plugin add <ajdtVersion>none</ajdtVersion>. This should fix the problem. There is hidden documentation here http://maven.apache.org/plugins/maven-eclipse-plugin/examples/ajdt-projects.html that describes how to use the ajdt plugin.
Hide
Permalink
Tan Quach added a comment -

I agree with Alexander, and I've created a new issue: http://jira.codehaus.org/browse/MECLIPSE-547

Show
Tan Quach added a comment - I agree with Alexander, and I've created a new issue: http://jira.codehaus.org/browse/MECLIPSE-547
Hide
Permalink
Eirik Rosvold Larsen added a comment -

According to the comments on MECLIPSE-270, this jira task replaces/duplicates that task. MECLIPSE-270 is about adding attributes to classpathentries in .classpath.

Can someone please elaborate how this can be accomplished in the pom.xml? This feature lacks documentation on the project website.

Regards

Show
Eirik Rosvold Larsen added a comment - According to the comments on MECLIPSE-270 , this jira task replaces/duplicates that task. MECLIPSE-270 is about adding attributes to classpathentries in .classpath. Can someone please elaborate how this can be accomplished in the pom.xml? This feature lacks documentation on the project website. Regards
Hide
Permalink
Arnaud Heritier added a comment -

The documentation about ajdt is here : http://maven.apache.org/plugins/maven-eclipse-plugin/examples/ajdt-projects.html
You can find several exemples here : http://svn.apache.org/repos/asf/maven/plugins/trunk/maven-eclipse-plugin/src/test/resources/projects/
If some docs are missing, do not hesitate to open an issue. We'll try to improve it.
We know there are many lacks in it.

Show
Arnaud Heritier added a comment - The documentation about ajdt is here : http://maven.apache.org/plugins/maven-eclipse-plugin/examples/ajdt-projects.html You can find several exemples here : http://svn.apache.org/repos/asf/maven/plugins/trunk/maven-eclipse-plugin/src/test/resources/projects/ If some docs are missing, do not hesitate to open an issue. We'll try to improve it. We know there are many lacks in it.
Hide
Permalink
Eirik Rosvold Larsen added a comment -

Arnaud: thanks for the link.

After plundering around, I found that adding wtp version 2.0 to the pom automatically added the required attributes to the classpathentries like this:

<classpathentry kind="var" path="M2_REPO/log4j/log4j/1.2.15/log4j-1.2.15.jar" sourcepath="M2_REPO/log4j/log4j/1.2.15/log4j-1.2.15-sources.jar">
<attributes>
<attribute value="/WEB-INF/lib" name="org.eclipse.jst.component.dependency"/>
</attributes>
</classpathentry>

A nice feature was that the attribute was only added if the maven dependency scope was compile or runtime. Small question though: If the scope is provided, the maven eclipse plugin doesn't add any attribute to the corresponding classpathentry. The wtp plugin for eclipse seems to support the following attribute for entries that are not to be deployed:

"org.eclipse.jst.component.nondependency"

Maybe you should add this for scope provided? Just a thought..

Thanks again!

Show
Eirik Rosvold Larsen added a comment - Arnaud: thanks for the link. After plundering around, I found that adding wtp version 2.0 to the pom automatically added the required attributes to the classpathentries like this: <classpathentry kind="var" path="M2_REPO/log4j/log4j/1.2.15/log4j-1.2.15.jar" sourcepath="M2_REPO/log4j/log4j/1.2.15/log4j-1.2.15-sources.jar"> <attributes> <attribute value="/WEB-INF/lib" name="org.eclipse.jst.component.dependency"/> </attributes> </classpathentry> A nice feature was that the attribute was only added if the maven dependency scope was compile or runtime. Small question though: If the scope is provided, the maven eclipse plugin doesn't add any attribute to the corresponding classpathentry. The wtp plugin for eclipse seems to support the following attribute for entries that are not to be deployed: "org.eclipse.jst.component.nondependency" Maybe you should add this for scope provided? Just a thought.. Thanks again!

People

  • Assignee:
    Arnaud Heritier
    Reporter:
    Eric Berry
Vote (10)
Watch (10)

Dates

  • Created:
    Updated:
    Resolved: