Details
-
Type:
Bug
-
Status:
Open
-
Priority:
Major
-
Resolution: Unresolved
-
Affects Version/s: 2.2
-
Fix Version/s: None
-
Component/s: PDE support
-
Labels:None
-
Patch Submitted:Yes
-
Number of attachments :
Description
Use case:
- I have non java source files in src/main/foo (for example a UML model)
- the "foo" artifact handler builds a zip containing the "foo" source files and its language is not "java" (for example the UML model zipped)
- I have a "bar" plugin which generates "bar" java source files from the "foo" source files in target/generated-sources/bar. (for example an MDA plugin)
- The "bar" plugin also builds a jar containing the target/generated-sources/bar java source files and attachs it with a "bar" classifier.
So even if the language of my project's artifact handler is not set to "java", since my project contains java source code (generated), my project should be considered a java project so that it can be referenced in multiproject mode by other projects in their build path.
The effect is obtained by replacing :
isJavaProject = "java".equals( artifactHandler.getLanguage() ) && !"ear".equals( packaging );
by
isJavaProject = ("java".equals(artifactHandler.getLanguage()) || sourceDirs.length > 0)
&& !"ear".equals(packaging);
and moving the code which builds the sourceDirs from the EclipsePlugin#writeConfiguration( IdeDependency[] deps ) to the EclipsePlugin#setup() method.
Regards,
Cédric
Activity
Cédric Vidal
made changes -
| Field | Original Value | New Value |
|---|---|---|
| Attachment | MECLIPSE-173.patch [ 23467 ] |
fabrizio giustina
made changes -
| Fix Version/s | 2.3 [ 12556 ] | |
| Fix Version/s | 2.4 [ 13001 ] |
Brian Fox
made changes -
| Fix Version/s | 2.5 [ 13593 ] | |
| Fix Version/s | 2.4 [ 13001 ] |
Arnaud Heritier
made changes -
| Fix Version/s | 2.5 [ 13593 ] |
Arnaud Heritier
made changes -
| Patch Submitted | [Yes] |
The patch has been created with TortoiseSVN relative to the root of the maven-eclipse-plugin.
Regards.