[with PATCH] Plugin generates invalid Eclipse project files when multiproject contains two references to the same artifact

Details

Description

HI

in same circumstances the eclipse-plugin will generate a Eclipse project file which contains two references to the same artifact/project which will cause Eclipse to fail loading the project. The attached patch is very small and solves this problem by managing the references within a java.util.Set and using equals() within the IdeDependency.java class.

Thanks

Kristian

Activity

Hide
Permalink
Barrie Treloar added a comment -

IdeDependency is comparable and equals delegates to compare, hashCode() also defined.

AbstractIdeSupportMojo.doDependencyResolution() maintains a list of dependencies and code already guards against duplicates:

// no duplicate entries allowed. System paths can cause this problem.
if ( !dependencies.contains( dep ) )
{
  dependencies.add( dep );
}

This should resolve your problem.

Show
Barrie Treloar added a comment - IdeDependency is comparable and equals delegates to compare, hashCode() also defined. AbstractIdeSupportMojo.doDependencyResolution() maintains a list of dependencies and code already guards against duplicates: 
// no duplicate entries allowed. System paths can cause this problem.
if ( !dependencies.contains( dep ) )
{
  dependencies.add( dep );
}
This should resolve your problem.

People

  • Assignee:
    Unassigned
    Reporter:
    Kristian Köhler
Vote (2)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: