application.xml generated incorrectly

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 2.1
  • Labels:
    None

Description

When generating an application.xml the description is written out before the display-name.

According to the DTD, display-name needs to be first. See: http://java.sun.com/dtd/application_1_3.dtd

A work around is to not use a description element in the pom.

  1. Text File
    MNG-1402-maven-ear-plugin.patch
    02/Nov/05 3:59 PM
    1 kB
    Tomislav Stojcevich
  2. Text File
    MNG-1402-maven-ear-pluginB.patch
    03/Nov/05 8:37 AM
    2 kB
    Tomislav Stojcevich

Issue Links

relates to

Bug - A problem which impairs or prevents the functions of the product. MEAR-118 Invalid application.xml generated

  • Critical - Crashes, loss of data, severe memory leak.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Tomislav Stojcevich added a comment -

Attached is the patch file.

Show
Tomislav Stojcevich added a comment - Attached is the patch file.
Hide
Permalink
Brett Porter added a comment -

this is the revers to my fix here:

http://svn.apache.org/viewcvs.cgi/maven/components/trunk/maven-plugins/maven-ear-plugin/src/main/java/org/apache/maven/plugin/ear/ApplicationXmlWriter.java?rev=292709&r1=291287&r2=292709&diff_format=h

is it possible that the order is different in 1.3 and 1.4? I remember needing this for OpenEJB to build.

Show
Brett Porter added a comment - this is the revers to my fix here: http://svn.apache.org/viewcvs.cgi/maven/components/trunk/maven-plugins/maven-ear-plugin/src/main/java/org/apache/maven/plugin/ear/ApplicationXmlWriter.java?rev=292709&r1=291287&r2=292709&diff_format=h is it possible that the order is different in 1.3 and 1.4? I remember needing this for OpenEJB to build.
Hide
Permalink
Tomislav Stojcevich added a comment -

It does look like they switchd the order.

http://java.sun.com/dtd/application_1_3.dtd shows:
<!ELEMENT application (icon?, display-name, description?, module+,
security-role*)>

http://java.sun.com/xml/ns/j2ee/j2ee_1_4.xsd which is included in http://java.sun.com/xml/ns/j2ee/application_1_4.xsd shows
<xsd:sequence>
<xsd:element name="description" type="j2ee:descriptionType" minOccurs="0" maxOccurs="unbounded"/>
<xsd:element name="display-name" type="j2ee:display-nameType" minOccurs="0" maxOccurs="unbounded"/>
<xsd:element name="icon" type="j2ee:iconType" minOccurs="0" maxOccurs="unbounded"/>
</xsd:sequence>

Attached is the new patch that checks for the version and writes them out appropriately.
I generated both and both validated correctly.

Show
Tomislav Stojcevich added a comment - It does look like they switchd the order. http://java.sun.com/dtd/application_1_3.dtd shows: <!ELEMENT application (icon?, display-name, description?, module+, security-role*)> http://java.sun.com/xml/ns/j2ee/j2ee_1_4.xsd which is included in http://java.sun.com/xml/ns/j2ee/application_1_4.xsd shows <xsd:sequence> <xsd:element name="description" type="j2ee:descriptionType" minOccurs="0" maxOccurs="unbounded"/> <xsd:element name="display-name" type="j2ee:display-nameType" minOccurs="0" maxOccurs="unbounded"/> <xsd:element name="icon" type="j2ee:iconType" minOccurs="0" maxOccurs="unbounded"/> </xsd:sequence> Attached is the new patch that checks for the version and writes them out appropriately. I generated both and both validated correctly.
Hide
Permalink
Stéphane Nicoll added a comment -

We will need to fix this in M2 as well. I'll take care of that.

Show
Stéphane Nicoll added a comment - We will need to fix this in M2 as well. I'll take care of that.
Hide
Permalink
Stéphane Nicoll added a comment -

Applied, thanks.

Show
Stéphane Nicoll added a comment - Applied, thanks.
Hide
Permalink
jerome added a comment -

this bug is here again with version 2.4
(display-name before description in application.xml generated).

Work good with previous version (tested with 2.3.1 and 2.3.2).

Show
jerome added a comment - this bug is here again with version 2.4 (display-name before description in application.xml generated). Work good with previous version (tested with 2.3.1 and 2.3.2).
Hide
Permalink
Stéphane Nicoll added a comment -

I know. It's fixed already in 2.4.1 (see MEAR-118)

Show
Stéphane Nicoll added a comment - I know. It's fixed already in 2.4.1 (see MEAR-118)

People

  • Assignee:
    Stéphane Nicoll
    Reporter:
    Tomislav Stojcevich
Vote (1)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: