Maven 2.x Ear Plugin

EAR plugin is not thread safe

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.4.1
  • Fix Version/s: 2.4.2
  • Labels:
    None
  • Number of attachments :
    1

Description

When running with parallel m3, the ear plugin bombs out. A quick inspection of the source code reveals numerous singletons.

  1. Text File
    MEAR-125.patch
    05/May/10 2:11 PM
    31 kB
    Kristian Rosenvold

Activity

Ascending order - Click to sort in descending order
Kristian Rosenvold made changes -
Field Original Value New Value
Assignee Kristian Rosenvold [ krosenvold ]
Hide
Permalink
Stéphane Nicoll added a comment -

Right, it has never been designed to be ran in parallel actually. Changing this won't be a big deal but it involves a lot of change. Do you want do to do it alone or can I help?

Show
Stéphane Nicoll added a comment - Right, it has never been designed to be ran in parallel actually. Changing this won't be a big deal but it involves a lot of change. Do you want do to do it alone or can I help?
Stéphane Nicoll made changes -
Fix Version/s 2.5 [ 14487 ]
Affects Version/s 2.4.1 [ 16129 ]
Hide
Permalink
Kristian Rosenvold added a comment -

I'd be really happy if you could take this. I'm fixing issues high & low these days. I have failing test projects in CI that we can use to test.

Show
Kristian Rosenvold added a comment - I'd be really happy if you could take this. I'm fixing issues high & low these days. I have failing test projects in CI that we can use to test.
Hide
Permalink
Kristian Rosenvold added a comment -

As agreed with Stéphane Nicoll I'm attaching this patch to this issue for review. The patch includes upgrade to maven-plugins v18 and @threadSafe annotations on the plugins themselves.

Show
Kristian Rosenvold added a comment - As agreed with Stéphane Nicoll I'm attaching this patch to this issue for review. The patch includes upgrade to maven-plugins v18 and @threadSafe annotations on the plugins themselves.
Kristian Rosenvold made changes -
Attachment MEAR-125.patch [ 48856 ]
Hide
Permalink
Kristian Rosenvold added a comment - - edited

It's all yours; if you have any problems applying with patch try "git apply MEAR-125.patch"

Show
Kristian Rosenvold added a comment - - edited It's all yours; if you have any problems applying with patch try "git apply MEAR-125 .patch"
Kristian Rosenvold made changes -
Assignee Kristian Rosenvold [ krosenvold ] Stephane Nicoll [ sni ]
Stéphane Nicoll made changes -
Fix Version/s 2.4.2 [ 16465 ]
Fix Version/s 2.5 [ 14487 ]
Hide
Permalink
Stéphane Nicoll added a comment -

I guess the newEarModule on EarModuleFactory is becoming way too much complex but that's something we can address in a later refactoring. The only thing that matters is that we cut a release fixing this issue.

I reviewed the patch and we can apply it as is. I've created a 2.4.2 version for this (no need to switch to a major version as the actual change is purely internal and does not affect any api/configuration.

Thanks for this!

Show
Stéphane Nicoll added a comment - I guess the newEarModule on EarModuleFactory is becoming way too much complex but that's something we can address in a later refactoring. The only thing that matters is that we cut a release fixing this issue. I reviewed the patch and we can apply it as is. I've created a 2.4.2 version for this (no need to switch to a major version as the actual change is purely internal and does not affect any api/configuration. Thanks for this!
Hide
Permalink
Kristian Rosenvold added a comment -

Fixed in r942855

Show
Kristian Rosenvold added a comment - Fixed in r942855
Kristian Rosenvold made changes -
Status Open [ 1 ] Closed [ 6 ]
Assignee Stephane Nicoll [ sni ] Kristian Rosenvold [ krosenvold ]
Resolution Fixed [ 1 ]

People

  • Assignee:
    Kristian Rosenvold
    Reporter:
    Kristian Rosenvold
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: