Details

    • Type: Task Task
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.2
    • Fix Version/s: 2.3
    • Component/s: None
    • Labels:
      None
    • Number of attachments :
      1

      Activity

      Hide
      John Casey added a comment -

      this is relevant to the current release which is up for a vote. We should complete the documentation review before releasing.

      Show
      John Casey added a comment - this is relevant to the current release which is up for a vote. We should complete the documentation review before releasing.
      Hide
      John Casey added a comment -

      Where are we on this, BTW? I can review the documentation tomorrow if need be.

      Show
      John Casey added a comment - Where are we on this, BTW? I can review the documentation tomorrow if need be.
      Hide
      Allan Ramirez added a comment -

      hi, already committed the docs. btw, do i have to make configuration for the deploy goal.. the docs can already be found at the guides

      http://maven.apache.org/guides/mini/guide-deploy-ftp.html
      http://maven.apache.org/guides/mini/guide-deploy-ssh-external.html

      and also in the usage.html

      Show
      Allan Ramirez added a comment - hi, already committed the docs. btw, do i have to make configuration for the deploy goal.. the docs can already be found at the guides http://maven.apache.org/guides/mini/guide-deploy-ftp.html http://maven.apache.org/guides/mini/guide-deploy-ssh-external.html and also in the usage.html
      Hide
      Brett Porter added a comment -

      good content!

      some feedback:

      • please use the layout of the standard (primary use case in usage should just be configuring for "deploy", then have example for deploying a file, and different types of deployment (ssh, etc)
      • the examples should be named by what someone is trying to do, not how they do it (they don't know they are looking for the deploy-file goal, necessarily, they know they need to deploy a file)

      Regarding the other guides, I would suggest they get moved to this plugin as examples, and the main documentation should just have a "guide to deploying" linking to this plugin's examples page.

      Show
      Brett Porter added a comment - good content! some feedback: please use the layout of the standard (primary use case in usage should just be configuring for "deploy", then have example for deploying a file, and different types of deployment (ssh, etc) the examples should be named by what someone is trying to do, not how they do it (they don't know they are looking for the deploy-file goal, necessarily, they know they need to deploy a file) Regarding the other guides, I would suggest they get moved to this plugin as examples, and the main documentation should just have a "guide to deploying" linking to this plugin's examples page.
      Hide
      Allan Ramirez added a comment -

      for review.. not sure if i got it right

      Show
      Allan Ramirez added a comment - for review.. not sure if i got it right
      Hide
      Brett Porter added a comment -

      good stuff.

      a couple of minor things:

      • "The information will be ta..." is indented incorrectly
      • the goal links don't work
      • how to use -> Usage
      • how to use section says "Plugin Name" instead of "deploy plugin"
      • comment out/remove the empty faq
      • for the examples, I'd suggest grouping them by "project deployment" and "file deployment"
      • there should be an issue opened and linked from MNG to point at these docs instead of the guides already on the site which are now duplicates

      thanks!

      Show
      Brett Porter added a comment - good stuff. a couple of minor things: "The information will be ta..." is indented incorrectly the goal links don't work how to use -> Usage how to use section says "Plugin Name" instead of "deploy plugin" comment out/remove the empty faq for the examples, I'd suggest grouping them by "project deployment" and "file deployment" there should be an issue opened and linked from MNG to point at these docs instead of the guides already on the site which are now duplicates thanks!
      Hide
      Allan Ramirez added a comment -

      applied.. for review again..

      thanks

      Show
      Allan Ramirez added a comment - applied.. for review again.. thanks
      Hide
      Brett Porter added a comment -

      looks good, thanks

      Show
      Brett Porter added a comment - looks good, thanks
      Hide
      Franz Allan Valencia See added a comment -

      Changes with MDEPLOY-35-maven-deploy-plugin.patch
      In site.xml
      Updated the Licensing Agreement based on [1]

      In *.apt
      Added the Licensing Agreement based on [1]

      In faq.fml
      Added the Licensing Agreement based on [1]

      [1] http://docs.codehaus.org/display/MAVEN/Maven+Plugin+Documentation

      Show
      Franz Allan Valencia See added a comment - Changes with MDEPLOY-35 -maven-deploy-plugin.patch In site.xml Updated the Licensing Agreement based on [1] In *.apt Added the Licensing Agreement based on [1] In faq.fml Added the Licensing Agreement based on [1] [1] http://docs.codehaus.org/display/MAVEN/Maven+Plugin+Documentation

        People

        • Assignee:
          Allan Ramirez
          Reporter:
          Allan Ramirez
        • Votes:
          0 Vote for this issue
          Watchers:
          0 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Time Tracking

            Estimated:
            Original Estimate - Not Specified
            Not Specified
            Remaining:
            Remaining Estimate - 0 minutes
            0m
            Logged:
            Time Spent - 6 hours, 30 minutes
            6h 30m