jira.codehaus.org

  • Log In Access more options
    • Online Help
    • Keyboard Shortcuts
    • About JIRA
    • JIRA Credits
    • What?s New
  • Dashboards Access more options (Alt+d)
  • Projects Access more options (Alt+p)
  • Issues Access more options (Alt+i)
Signup
Maven 2.x and 3.x Deploy Plugin
  • Maven 2.x and 3.x Deploy Plugin
  • MDEPLOY-19

Ability to deploy-file as classifier

  • Log In
  • Views
    • XML
    • Word
    • Printable

Details

  • Type: New Feature New Feature
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.1
  • Fix Version/s: 2.2
  • Component/s: None
  • Labels:
    None
  • Environment:
    xp
  • Number of attachments :
    1

Description

deploy-file currently does not support this option

  • Options
    • Sort By Name
    • Sort By Date
    • Ascending
    • Descending
    • Download All

Attachments

  1. File
    MDEPLOY19.diff
    28/Jan/06 8:15 AM
    8 kB
    ${attachment.displayAuthor}

Activity

Ascending order - Click to sort in descending order
  • All
  • Comments
  • Work Log
  • History
  • Activity
Hide
Permalink
Jerome Lacoste added a comment - 28/Jan/06 8:18 AM

I attached the fix. I haven't tested it thoroughly apart from a quick

mvn install && mvn deploy:deploy-file -Durl=file:///tmp/ -Dfile=target/maven-deploy-plugin-2.2-SNAPSHOT.jar -Dclassifier=test -DpomFile=pom.xml -DrepositoryId=dummy

Note: the fix depends on MDEPLOY-23 to be applied first.

Show
Jerome Lacoste added a comment - 28/Jan/06 8:18 AM I attached the fix. I haven't tested it thoroughly apart from a quick mvn install && mvn deploy:deploy-file -Durl= file:///tmp/ -Dfile=target/maven-deploy-plugin-2.2-SNAPSHOT.jar -Dclassifier=test -DpomFile=pom.xml -DrepositoryId=dummy Note: the fix depends on MDEPLOY-23 to be applied first.
Hide
Permalink
Allan Ramirez added a comment - 03/Feb/06 3:33 AM

Hi Jerome,

Could you make another copy of that diff file, I think It is broken. Thanks

Allan

Show
Allan Ramirez added a comment - 03/Feb/06 3:33 AM Hi Jerome, Could you make another copy of that diff file, I think It is broken. Thanks Allan
Hide
Permalink
Jerome Lacoste added a comment - 03/Feb/06 3:37 AM

What kind of brokeness? It doesn't apply? or it's not considered as a patch?

Show
Jerome Lacoste added a comment - 03/Feb/06 3:37 AM What kind of brokeness? It doesn't apply? or it's not considered as a patch?
Hide
Permalink
Allan Ramirez added a comment - 03/Feb/06 7:42 PM

It is not considered as a patch.

Show
Allan Ramirez added a comment - 03/Feb/06 7:42 PM It is not considered as a patch.
Hide
Permalink
Brett Porter added a comment - 03/Feb/06 8:02 PM

I've had problems with your method of patches before Jerome - can you use "svn diff" instead of taking copies of the files and using diff? We need to know what the source revision was.

Show
Brett Porter added a comment - 03/Feb/06 8:02 PM I've had problems with your method of patches before Jerome - can you use "svn diff" instead of taking copies of the files and using diff? We need to know what the source revision was.
Hide
Permalink
Allan Ramirez added a comment - 22/Feb/06 2:18 AM

Fixed in SVN. Thanks Jerome

Show
Allan Ramirez added a comment - 22/Feb/06 2:18 AM Fixed in SVN. Thanks Jerome
Hide
Permalink
Jerome Lacoste added a comment - 24/Feb/06 12:35 AM

To Brett: "I've had problems with your method of patches before Jerome - can you use "svn diff" instead of taking copies of the files and using diff? We need to know what the source revision was."

The reason I don't use svn diff directly is I often have several patches waiting on the same project. For example I submitted that one in a serie of 3 patches. I cannot then use svn diff to create my patch. I would have to create each patch independently of the other and 1- it is often not possible, 2- that means I would have to update my patch when a precedent one is checked in. So svn diff is not an option in some cases given the way I work (in batch).

So I use 'quilt' to handle the patches. It is supposed to work. I've used it successfully on all the other projects I am working on. But I sometimes make a mistake, and that render the patch not usable. I will improve my discipline and make sure that I better test apply my patch stack before submission. Maybe should I only submit them as a group (that's what is done in other projects)?

Sorry if that caused you some issues but I think that this is still the correct way to go for me.

Show
Jerome Lacoste added a comment - 24/Feb/06 12:35 AM To Brett: "I've had problems with your method of patches before Jerome - can you use "svn diff" instead of taking copies of the files and using diff? We need to know what the source revision was." The reason I don't use svn diff directly is I often have several patches waiting on the same project. For example I submitted that one in a serie of 3 patches. I cannot then use svn diff to create my patch. I would have to create each patch independently of the other and 1- it is often not possible, 2- that means I would have to update my patch when a precedent one is checked in. So svn diff is not an option in some cases given the way I work (in batch). So I use 'quilt' to handle the patches. It is supposed to work. I've used it successfully on all the other projects I am working on. But I sometimes make a mistake, and that render the patch not usable. I will improve my discipline and make sure that I better test apply my patch stack before submission. Maybe should I only submit them as a group (that's what is done in other projects)? Sorry if that caused you some issues but I think that this is still the correct way to go for me.
Hide
Permalink
Stefan Hübner added a comment - 28/Jun/06 6:20 AM

Was there any particular reason, to issue this only for the deploy-file goal? Doesn't this also make sense for the deploy-goal?

Show
Stefan Hübner added a comment - 28/Jun/06 6:20 AM Was there any particular reason, to issue this only for the deploy-file goal? Doesn't this also make sense for the deploy-goal?
Hide
Permalink
Anagnostopoulos Kostis added a comment - 14/Nov/06 9:59 AM

Hello,
I have the same problem as Stefan Hübner said:

The deploy goal does not take into consideration the <classifier> parameter.

We should either re-open this issue or file a new one!
What should we do?

Regards,
Kostis

Show
Anagnostopoulos Kostis added a comment - 14/Nov/06 9:59 AM Hello, I have the same problem as Stefan Hübner said: The deploy goal does not take into consideration the <classifier> parameter. We should either re-open this issue or file a new one! What should we do? Regards, Kostis

People

  • Assignee:
    Allan Ramirez
    Reporter:
    Dan Tran
Vote (2)
Watch (0)

Dates

  • Created:
    11/Jan/06 2:20 AM
    Updated:
    14/Nov/06 9:59 AM
    Resolved:
    27/Feb/06 5:39 PM

Time Tracking

Estimated:
Not Specified
Original Estimate - Not Specified
Remaining:
0m
Remaining Estimate - 0 minutes
Logged:
2h
Time Spent - 2 hours
  • Atlassian JIRA (v5.2.7#850-sha1:b2af0c8)
  • Report a problem
  • Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.