jira.codehaus.org

  • Log In Access more options
    • Online Help
    • Keyboard Shortcuts
    • About JIRA
    • JIRA Credits
    • What?s New
  • Dashboards Access more options (Alt+d)
  • Projects Access more options (Alt+p)
  • Issues Access more options (Alt+i)
Signup
Maven 2.x Dependency Plugin
  • Maven 2.x Dependency Plugin
  • MDEP-22

copy of provided dependencies

  • Log In
  • Views
    • XML
    • Word
    • Printable

Details

  • Type: Wish Wish
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 2.0-alpha-1
  • Component/s: None
  • Labels:
    None
  • Environment:
    all
  • Number of attachments :
    1

Description

create an attribute to say "don't copy 'provided' dependencies", into copy-dependencies goal.

  • Options
    • Sort By Name
    • Sort By Date
    • Ascending
    • Descending
    • Download All

Attachments

  1. Text File
    MDEP-21.patch
    10/Oct/06 10:33 AM
    4 kB
    Mark Struberg

Issue Links

duplicates

Wish - General wishlist item MDEP-21 Option to not copy 'provided' scoped jars

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
  • All
  • Comments
  • Work Log
  • History
  • Activity
Hide
Permalink
Brian Fox added a comment - 11/Sep/06 9:08 PM

Added the ability to specify a scope to exclude. This uses the plexus ScopeArtifactFilter, which defines what scopes are included. For example, since test scope effectively includes all other scopes, then excluding the test scope would exclude everything. (which the plugin won't allow)

Show
Brian Fox added a comment - 11/Sep/06 9:08 PM Added the ability to specify a scope to exclude. This uses the plexus ScopeArtifactFilter, which defines what scopes are included. For example, since test scope effectively includes all other scopes, then excluding the test scope would exclude everything. (which the plugin won't allow)
Hide
Permalink
Mark Struberg added a comment - 10/Oct/06 10:18 AM

There are some bugs in the test cases if running under *nix

The reason is the shortening of the long time value to seconds for some file systems.

If you set a long time of actual value
> 1160492034512
to a file and afterwards read the lastModificationDate, you'll only get
> 1160492034000

So here are 2 failure situations:

1.) For some test cases you simply have to extend the time-offset from 222 to 2222:

.) TestMarkerFileFilter.java
.) TestDefaultMarkerFileHandler.java
.) TestSourcesMarkerFileHandler.java
If you have an actual time value of
> 1160492034112
you'll get
> 1160492034334
which will be truncated by the file system to
> 1160492034000
which is lower then the original value! -> assert will fail
adding 2222 (bit over 2 seconds) will help.

2.) As i explained above, some time values have to be truncate to seconds:

.) TestCopyDependenciesMojo.java line 523
assertEquals( time/1000, copiedFile.lastModified()/1000 );

.) TestCopyDependenciesMojo.java line 488 and 550
Thread.sleep( 1001 ); // sleep a bit more than a second...

at least it works on Linux this way. Please retest under Windoof

best regards,
strub

Show
Mark Struberg added a comment - 10/Oct/06 10:18 AM There are some bugs in the test cases if running under *nix The reason is the shortening of the long time value to seconds for some file systems. If you set a long time of actual value > 1160492034512 to a file and afterwards read the lastModificationDate, you'll only get > 1160492034000 So here are 2 failure situations: 1.) For some test cases you simply have to extend the time-offset from 222 to 2222: .) TestMarkerFileFilter.java .) TestDefaultMarkerFileHandler.java .) TestSourcesMarkerFileHandler.java If you have an actual time value of > 1160492034112 you'll get > 1160492034334 which will be truncated by the file system to > 1160492034000 which is lower then the original value! -> assert will fail adding 2222 (bit over 2 seconds) will help. 2.) As i explained above, some time values have to be truncate to seconds: .) TestCopyDependenciesMojo.java line 523 assertEquals( time/1000, copiedFile.lastModified()/1000 ); .) TestCopyDependenciesMojo.java line 488 and 550 Thread.sleep( 1001 ); // sleep a bit more than a second... at least it works on Linux this way. Please retest under Windoof best regards, strub
Hide
Permalink
Mark Struberg added a comment - 10/Oct/06 10:33 AM

oops wrongly attached this to MDEP-21 first, for sanity i also attach it here.

Show
Mark Struberg added a comment - 10/Oct/06 10:33 AM oops wrongly attached this to MDEP-21 first, for sanity i also attach it here.

People

  • Assignee:
    Brian Fox
    Reporter:
    Jerome CARRE
Vote (1)
Watch (1)

Dates

  • Created:
    02/May/06 2:07 PM
    Updated:
    10/Oct/06 10:33 AM
    Resolved:
    11/Sep/06 9:08 PM
  • Atlassian JIRA (v5.2.7#850-sha1:b2af0c8)
  • Report a problem
  • Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.