Details

    • Type: Wish Wish
    • Status: Closed Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0-alpha-1
    • Component/s: None
    • Labels:
      None
    • Environment:
      all
    • Number of attachments :
      1

      Description

      create an attribute to say "don't copy 'provided' dependencies", into copy-dependencies goal.

        Issue Links

          Activity

          Hide
          brianfox brianfox added a comment -

          Added the ability to specify a scope to exclude. This uses the plexus ScopeArtifactFilter, which defines what scopes are included. For example, since test scope effectively includes all other scopes, then excluding the test scope would exclude everything. (which the plugin won't allow)

          Show
          brianfox brianfox added a comment - Added the ability to specify a scope to exclude. This uses the plexus ScopeArtifactFilter, which defines what scopes are included. For example, since test scope effectively includes all other scopes, then excluding the test scope would exclude everything. (which the plugin won't allow)
          Hide
          Mark Struberg added a comment -

          There are some bugs in the test cases if running under *nix

          The reason is the shortening of the long time value to seconds for some file systems.

          If you set a long time of actual value
          > 1160492034512
          to a file and afterwards read the lastModificationDate, you'll only get
          > 1160492034000

          So here are 2 failure situations:

          1.) For some test cases you simply have to extend the time-offset from 222 to 2222:

          .) TestMarkerFileFilter.java
          .) TestDefaultMarkerFileHandler.java
          .) TestSourcesMarkerFileHandler.java
          If you have an actual time value of
          > 1160492034112
          you'll get
          > 1160492034334
          which will be truncated by the file system to
          > 1160492034000
          which is lower then the original value! -> assert will fail
          adding 2222 (bit over 2 seconds) will help.

          2.) As i explained above, some time values have to be truncate to seconds:

          .) TestCopyDependenciesMojo.java line 523
          assertEquals( time/1000, copiedFile.lastModified()/1000 );

          .) TestCopyDependenciesMojo.java line 488 and 550
          Thread.sleep( 1001 ); // sleep a bit more than a second...

          at least it works on Linux this way. Please retest under Windoof

          best regards,
          strub

          Show
          Mark Struberg added a comment - There are some bugs in the test cases if running under *nix The reason is the shortening of the long time value to seconds for some file systems. If you set a long time of actual value > 1160492034512 to a file and afterwards read the lastModificationDate, you'll only get > 1160492034000 So here are 2 failure situations: 1.) For some test cases you simply have to extend the time-offset from 222 to 2222: .) TestMarkerFileFilter.java .) TestDefaultMarkerFileHandler.java .) TestSourcesMarkerFileHandler.java If you have an actual time value of > 1160492034112 you'll get > 1160492034334 which will be truncated by the file system to > 1160492034000 which is lower then the original value! -> assert will fail adding 2222 (bit over 2 seconds) will help. 2.) As i explained above, some time values have to be truncate to seconds: .) TestCopyDependenciesMojo.java line 523 assertEquals( time/1000, copiedFile.lastModified()/1000 ); .) TestCopyDependenciesMojo.java line 488 and 550 Thread.sleep( 1001 ); // sleep a bit more than a second... at least it works on Linux this way. Please retest under Windoof best regards, strub
          Hide
          Mark Struberg added a comment -

          oops wrongly attached this to MDEP-21 first, for sanity i also attach it here.

          Show
          Mark Struberg added a comment - oops wrongly attached this to MDEP-21 first, for sanity i also attach it here.

            People

            • Assignee:
              brianfox brianfox
              Reporter:
              Jerome CARRE
            • Votes:
              1 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: