Maven 2.x Dependency Plugin

Indeterministic artifact ordering can cause bogus warnings

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Trivial Trivial
  • Resolution: Fixed
  • Affects Version/s: 2.0
  • Fix Version/s: 2.1
  • Component/s: analyze
  • Labels:
    None
  • Patch Submitted:
    Yes
  • Number of attachments :
    1

Description

Once MNG-1412 gets released, it will be nice to have the dependency analyzer respect ordering, too.

As some motivation, consider a project P with the following dependency tree:

Project P
+- Dep A
   +- Dep B

Further assume that both dependencies a and B contain the same class X (for whatever reason, say backward-compat). Project P directly uses this class X (hence Dep A being a dependency of P).

Currenlty, the ordering of artifacts is ignored by the analyzer such that the artifactClassMap might list Dep B before Dep A. This in turn will make findArtifactForClassName() return Dep B as the source artifact for class X which results in the bogus warning "Used undeclared dependency Dep B" because Dep A should have been considered instead as it is first on the class path.

Issue Links

Activity

Hide
Brian Fox added a comment -

Patch applied thanks. An IT for this would be great.

Show
Brian Fox added a comment - Patch applied thanks. An IT for this would be great.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: