Configuration for different report encodings (other than UTF-8)

Details

  • Type: New Feature New Feature
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 2.4
  • Labels:
    None

Description

The Cobertura patch 1670817 implements the possibility to specify the encoding for the java source code files. This is absolutely necessary if the Java source code uses encoding other than UTF-8. See https://sourceforge.net/tracker/?func=detail&atid=720017&aid=1670817&group_id=130558

It would be nice if everybody would use UTF-8, this is however not always possible; i.e. due to Microsoft's dominance () many people use unconciously the so called ANSI (Windows-1252) unofficial "standard". When writing code (better to say comments) in other languages than english, the Cobertura report output (that utilizes UTF-8) is hardly readable.

Hence, it is highly desirable if somebody would implement asap an appropriate patch for the maven cobertura plugin where with a new configuration option the user can specify the source character set (the default remains UTF-8).

... 
       <configuration>
          <formats>
            <format>...</format>
          </formats>
          <charset>CP1252</charset>
       </configuration>
...

Issue Links

is duplicated by

Bug - A problem which impairs or prevents the functions of the product. MCOBERTURA-116 Add encoding parameter in case Java Source is not default

  • Critical - Crashes, loss of data, severe memory leak.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

New Feature - A new feature of the product, which has yet to be developed. MCOBERTURA-33 Adding the Cobertura Merge task

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Sasha Cvetkovic added a comment -

In order to be consistent with the Cobertura patch it is better to call the new option

Show
Sasha Cvetkovic added a comment - In order to be consistent with the Cobertura patch it is better to call the new option
Hide
Permalink
Sasha Cvetkovic added a comment -

In order to be consistent with the Cobertura patch it is better to call the new option "encoding", i.e.

... 
       <configuration>
          <formats>
            <format>...</format>
          </formats>
          <encoding>CP1252</encoding>
       </configuration>
...
Show
Sasha Cvetkovic added a comment - In order to be consistent with the Cobertura patch it is better to call the new option "encoding", i.e. 
... 
       <configuration>
          <formats>
            <format>...</format>
          </formats>
          <encoding>CP1252</encoding>
       </configuration>
...
Hide
Permalink
Sasha Cvetkovic added a comment -

And here is the proposed patch (MCOBERTURA-85.patch) - w/o JUnit Tests (should be quite straightforward).

Notes:

  • Modifications done in the tagged version 2.2
  • CoberturaInstrumentMojo.java (method addCoberturaDependenciesToTestClasspath()) : in the final version (2.3?) one should replace the group identifier "patches" with "net.sourceforge.cobertura".
  • pom.xml must be adapted accordingly (set correct plugin version + set appropriate dependency with the patched/updated cobertura - 2.0?, i.e. the version that implements the encoding switch).
Show
Sasha Cvetkovic added a comment - And here is the proposed patch (MCOBERTURA-85.patch) - w/o JUnit Tests (should be quite straightforward). Notes:
  • Modifications done in the tagged version 2.2
  • CoberturaInstrumentMojo.java (method addCoberturaDependenciesToTestClasspath()) : in the final version (2.3?) one should replace the group identifier "patches" with "net.sourceforge.cobertura".
  • pom.xml must be adapted accordingly (set correct plugin version + set appropriate dependency with the patched/updated cobertura - 2.0?, i.e. the version that implements the encoding switch).
Hide
Permalink
Jörg Hohwiller added a comment -

The proper fix would have been to honor project.build.sourceEncoding:
http://docs.codehaus.org/display/MAVENUSER/POM+Element+for+Source+File+Encoding

Show
Jörg Hohwiller added a comment - The proper fix would have been to honor project.build.sourceEncoding: http://docs.codehaus.org/display/MAVENUSER/POM+Element+for+Source+File+Encoding

People

  • Assignee:
    David J. M. Karlsen
    Reporter:
    Sasha Cvetkovic
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: