[#MCLEAN-39] followSymLinks is always set to true - jira.codehaus.org

Maven 2.x Clean Plugin

followSymLinks is always set to true

Created: 06/Feb/09 07:11 AM Updated: 15/Feb/10 09:26 AM Resolved: 10/Jan/10 12:56 PM

Component/s:

None

Affects Version/s:

2.3

Fix Version/s:

2.4

Time Tracking:

Not Specified

File Attachments:

clean.txt (23 kB)
2.

test-clean.zip (0.8 kB)

Environment:

Maven 2.0.9, Linux

Issue Links:

Related

This issue is related to:

MWAR-205 A useDefaultExcludes=false option, like the assembly plugin has.

Testcase included:

yes

Description

« Hide

From my tests, followSymLinks that is used to delete the content of symlink when it is set to true, is not taken in account.
It should be a regression caused by http://jira.codehaus.org/browse/MCLEAN-28

This is a blocker bug, since it could delete all the filesystem easily, and there is no workaround. Even when I set followSymLinks explicitley to false, Maven clean 2.3 follow symlinks and delete its contents.

To reproduce :
Declare 2.3 clean plugin in your pom
mkdir /tmp/test
touch /tmp/test/foo
symlink -s /tmp/test /myproject/target/test
cd /myproject
mvn clean

After runnig that, /tmp/test is empty !

If it is confirmed, I would recommand to release quickly a 2.4 version with a fix, since in is REALLY dansgerous.

Sort Order:

[ Permalink | « Hide ]

Bouiaw added a comment - 06/Feb/09 07:12 AM

The only workaround I have found is to use 2.1.1 release.

[ Permalink | « Hide ]

Brian Fox added a comment - 06/Feb/09 08:09 AM

A quick scan of the code shows everything in order. Can you include output of "mvn clean -X" ?

[ Permalink | « Hide ]

Bouiaw added a comment - 06/Feb/09 04:45 PM

You will find attached the output of mvn -X clean, and a test case to reproduce the issue.
Run the sh script and next run mvn clean to see the issue : /tmp/test/toto is deleted with default configuration !

[ Permalink | « Hide ]

Bouiaw added a comment - 08/Feb/09 12:42 PM

From what I saw, there is a few code in the clean plugin, and from a diff between 2.1.1 (where the issue did not occure) and 2.3, I don't see any change that could cause this bug.

I think the issue come from something that has been broken between Maven file-management 1.0 (Maven clean 2.1.1) and Maven file-management 1.2.1 (Maven clean 2.3), eventually from its plexus-utils dependency.

For information, this bug is not testable with Maven Clean 2.2 (file-management 1.2) because of http://jira.codehaus.org/browse/MCLEAN-28.

[ Permalink | « Hide ]

Benjamin Bentmann added a comment - 10/Jan/10 12:56 PM

Fixed in r897682.