Maven 2.x Clean Plugin

Maven clean plugin doesn't filter resources from exclude list

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.2
  • Fix Version/s: 2.3
  • Labels:
    None
  • Number of attachments :
    3

Description

For example you want to delete content of folder but want to keep folder itself and it's SCM (e.g. SVN) information. Following configuration for "maven-maven-clean" plugin deletes all plain files under ".svn" directory and simply keeps empty subdirs. Thus, making update command impossible.

<build>
  ...
  <plugins>
    <plugin>
      <artifactId>maven-clean-plugin</artifactId>
      <configuration>
        <verbose>true</verbose>
        <filesets>
          <fileset>
            <directory>logic/src/test/generated/resources</directory>
            <excludes>
              <exclude>.svn/**/*</exclude>
            </excludes>
            <includes>
              <include>**/*</include>
            </includes>
            <followSymlinks>false</followSymlinks>
          </fileset>
        </filesets>
      </configuration>
    </plugin>
  </plugins>
</build>

Issue Links

depends upon

Bug - A problem which impairs or prevents the functions of the product. MSHARED-61 Base directory of file set is not excluded from deletion if it contains excluded paths

  • Critical - Crashes, loss of data, severe memory leak.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Bug - A problem which impairs or prevents the functions of the product. MSHARED-62 Excludes are ignored for deletion if followSymlinks=false

  • Critical - Crashes, loss of data, severe memory leak.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Benjamin Bentmann added a comment - - edited

I can reproduce this issue (on WinXP), attached is a complete mini project.

A workaround is to set followSymlinks=true for the file set, that keeps the plain files alive in your special scenario. So it seems the issue originates somewhere from org.apache.maven.shared.model.fileset.util.FileSetManager in org.apache.maven.shared:file-management:1.2.

Show
Benjamin Bentmann added a comment - - edited I can reproduce this issue (on WinXP), attached is a complete mini project. A workaround is to set followSymlinks=true for the file set, that keeps the plain files alive in your special scenario. So it seems the issue originates somewhere from org.apache.maven.shared.model.fileset.util.FileSetManager in org.apache.maven.shared:file-management:1.2.
Hide
Permalink
Benjamin Bentmann added a comment -

Step 1: Patch providing a unit test for file-management to reveal its bug.

Show
Benjamin Bentmann added a comment - Step 1: Patch providing a unit test for file-management to reveal its bug.
Hide
Permalink
Benjamin Bentmann added a comment -

Step 2: Patch to fix the FileSetManager.

There were actually two bugs:

  • findDeletableFiles() queried scanner.getExcludedFiles() to get the mismarked symlinks but it should query scanner.getIncludedFiles()
  • both findDeletableDirectories() and findDeletableFiles() forget to prevent the base directory from deletion if it contains excluded files/directories
Show
Benjamin Bentmann added a comment - Step 2: Patch to fix the FileSetManager. There were actually two bugs: findDeletableFiles() queried scanner.getExcludedFiles() to get the mismarked symlinks but it should query scanner.getIncludedFiles() both findDeletableDirectories() and findDeletableFiles() forget to prevent the base directory from deletion if it contains excluded files/directories
Hide
Permalink
Benjamin Bentmann added a comment -

Fixed in r694394.

Show
Benjamin Bentmann added a comment - Fixed in r694394 .

People

  • Assignee:
    Benjamin Bentmann
    Reporter:
    Vladimir Sosnin
Vote (1)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: