jira.codehaus.org

  • Log In Access more options
    • Online Help
    • Keyboard Shortcuts
    • About JIRA
    • JIRA Credits
    • What?s New
  • Dashboards Access more options (Alt+d)
  • Projects Access more options (Alt+p)
  • Issues Access more options (Alt+i)
Signup
Maven 2.x Checkstyle Plugin
  • Maven 2.x Checkstyle Plugin
  • MCHECKSTYLE-85

Make tests platform-independent

  • Log In
  • Views
    • XML
    • Word
    • Printable

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Trivial Trivial
  • Resolution: Fixed
  • Affects Version/s: 2.1
  • Fix Version/s: 2.2
  • Labels:
    None
  • Patch Submitted:
    Yes
  • Number of attachments :
    1

Description

The test suite of the plugin uses the the JVM's default locale to get its resource bundle. However, AbstractMavenReport.execute() will always use the English locale when calling MavenReport.generate(). Hence, the tests will search for say German strings in a report generated from English resources...

By the way, the current head of the maven-reporting-impl simply throws a MojoExecutionException from AbstractMavenReport.execute(). All tests will fail once the plugin updates its dependencies. Not to mention that the report cannot be generated from the command line any more, pitty.

  • Options
    • Sort By Name
    • Sort By Date
    • Ascending
    • Descending
    • Download All

Attachments

  1. Text File
    checkstyle-test-locale.patch
    02/Feb/08 2:02 PM
    0.8 kB
    Benjamin Bentmann

Activity

  • All
  • Comments
  • Work Log
  • History
  • Activity
Hide
Permalink
Dennis Lundberg added a comment - 02/Feb/08 6:02 PM

Patch applied in r617931. Thanks!

Show
Dennis Lundberg added a comment - 02/Feb/08 6:02 PM Patch applied in r617931. Thanks!

People

  • Assignee:
    Dennis Lundberg
    Reporter:
    Benjamin Bentmann
Vote (0)
Watch (0)

Dates

  • Created:
    02/Feb/08 2:02 PM
    Updated:
    02/Feb/08 6:02 PM
    Resolved:
    02/Feb/08 6:02 PM
  • Atlassian JIRA (v5.2.7#850-sha1:b2af0c8)
  • Report a problem
  • Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.