Maven 2.x Checkstyle Plugin

Suppressions property is incorrectly set if suppressions file is on classpath

Details

  • Type: Bug Bug
  • Status: Open Open
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: 2.8
  • Fix Version/s: None
  • Labels:
    None
  • Number of attachments :
    2

Description

If checkstyle plugin loads suppressions file from its classpath, and the checkstyle configuration contains suppression filter with a property placeholder, that property is not expanded because an incorrect path is used.

  1. Text File
    MCHECKSTYLE-169-bugfix.patch
    02/Feb/12 7:17 PM
    7 kB
    Sergei Ivanov
  2. Text File
    MCHECKSTYLE-169-it.patch
    02/Feb/12 7:17 PM
    11 kB
    Sergei Ivanov

Issue Links

relates to

Bug - A problem which impairs or prevents the functions of the product. MCHECKSTYLE-149 supressionsFileExpression does not work.

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Sergei Ivanov added a comment -

Related to some prior changes, but the problem is that an unresolved (as in the plugin config) file path is passed into checkstyle engine, whereas the resolved file path (see getSuppressions() method) is not used.

Show
Sergei Ivanov added a comment - Related to some prior changes, but the problem is that an unresolved (as in the plugin config) file path is passed into checkstyle engine, whereas the resolved file path (see getSuppressions() method) is not used.
Hide
Permalink
Dennis Lundberg added a comment -

Can you give a sample project that we can use to test this?

Show
Dennis Lundberg added a comment - Can you give a sample project that we can use to test this?
Hide
Permalink
Sergei Ivanov added a comment -

Hello Dennis,
Attached are an integration test for the described problem and a patch that fixes it. I wanted to add a couple of additional integration tests to check for regressions, but ran out of spare time. Please review and integrate into the next release if deemed suitable. The patch is against the SVN trunk for the plugin.
Thank you.

Show
Sergei Ivanov added a comment - Hello Dennis, Attached are an integration test for the described problem and a patch that fixes it. I wanted to add a couple of additional integration tests to check for regressions, but ran out of spare time. Please review and integrate into the next release if deemed suitable. The patch is against the SVN trunk for the plugin. Thank you.
Hide
Permalink
Sergei Ivanov added a comment -

Any chance of the attached patch being integrated into 2.10?

Show
Sergei Ivanov added a comment - Any chance of the attached patch being integrated into 2.10?
Hide
Permalink
Sergei Ivanov added a comment -

Please, please!

Show
Sergei Ivanov added a comment - Please, please!
Hide
Permalink
Sergei Ivanov added a comment -

Can we have it integrated into 2.11, please?

Show
Sergei Ivanov added a comment - Can we have it integrated into 2.11, please?

People

  • Assignee:
    Unassigned
    Reporter:
    Sergei Ivanov
Vote (3)
Watch (3)

Dates

  • Created:
    Updated: