Maven 2.x Checkstyle Plugin

supressionsFileExpression does not work.

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.6
  • Fix Version/s: 2.7
  • Labels:
    None
  • Patch Submitted:
    Yes
  • Number of attachments :
    0

Description

In DefaultCheckstyleExecutor.getOverridingProperties() there is the following:

  if ( request.getSuppressionsFileExpression() != null )
        {
            String suppresionFile = request.getSuppressionsFileExpression();

            if ( suppresionFile != null )
            {
                p.setProperty( request.getSuppressionsFileExpression(), suppresionFile );
            }
        }

Note how supressionFile is being set to the expression, not the file. This one line should read:

            String suppresionFile = request.getSuppressionsLocation();

This bug is blocking the m2e-checkstyle plugin from supporting Maven-driven suppression files.

Issue Links

is duplicated by

Bug - A problem which impairs or prevents the functions of the product. MCHECKSTYLE-134 suppressionsFileExpression does not work - cannot initialize module SuppressionFilter

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
is related to

Bug - A problem which impairs or prevents the functions of the product. MCHECKSTYLE-169 Suppressions property is incorrectly set if suppressions file is on classpath

  • Major - Major loss of function.
  • Open - The issue is open and ready for the assignee to start work on it.

Activity

Hide
Permalink
Dennis Lundberg added a comment -

Patch applied in r1092500.

Thanks!

New 2.7-SNAPSHOT deployed. Please test it.

Show
Dennis Lundberg added a comment - Patch applied in r1092500 . Thanks! New 2.7-SNAPSHOT deployed. Please test it.

People

  • Assignee:
    Dennis Lundberg
    Reporter:
    Idcmp
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: