Maven 2.x Checkstyle Plugin

Upgrade to Checkstyle 5.3

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 2.7
  • Labels:
    None
  • Number of attachments :
    1

Description

Issue Links

is depended upon by

Improvement - An improvement or enhancement to an existing feature or task. MOJO-1660 Upgrade to m-checkstyle-p 2.7 to solve checkstyle violations related to the maven plugin annotations

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Olivier Lamy added a comment -

who push this in central repo ? currently it's not in .

Show
Olivier Lamy added a comment - who push this in central repo ? currently it's not in .
Hide
Permalink
Bruno Marti added a comment -

Who installed checkstyle 5.0 on central repo?
Perhaps this guy can help.
I would really appreciate this improvement in the near future.

Show
Bruno Marti added a comment - Who installed checkstyle 5.0 on central repo? Perhaps this guy can help. I would really appreciate this improvement in the near future.
Hide
Permalink
Paul Nyheim added a comment -

Indeed 5.1 seems to be missing, but current version is 5.3, and please note that in version 5.2 they changed groupId from checkstyle to com.puppycrawl.tools, as noted in the Release Notes

Both 5.2 and 5.3 are present in central repo: https://repository.sonatype.org/index.html#nexus-search;quick~checkstyle

Show
Paul Nyheim added a comment - Indeed 5.1 seems to be missing, but current version is 5.3, and please note that in version 5.2 they changed groupId from checkstyle to com.puppycrawl.tools, as noted in the Release Notes Both 5.2 and 5.3 are present in central repo: https://repository.sonatype.org/index.html#nexus-search;quick~checkstyle
Hide
Permalink
Paul Nyheim added a comment - - edited

patch against v2.6 in svn
All tests run green. oops
Forgot to run mvn clean test, so there are currently 7 failures. I'll have a quick look and see if I can fix them quickly...

Show
Paul Nyheim added a comment - - edited patch against v2.6 in svn All tests run green. oops Forgot to run mvn clean test, so there are currently 7 failures. I'll have a quick look and see if I can fix them quickly...
Hide
Permalink
Paul Nyheim added a comment -

Did not have time to actually fix them now, but managed to track down the error.
The tests that fail are related to this change in Checkstyle 5.3 (all tests run fine with 5.2)
changeset:DefaultConfiguration.java

As far as I can find out, cacheFile is specified in both min-plugin-config.xml and in sun_checks.xml (with substitution property), and this creates problems due to the previous mentioned change, where the absolute path would be added to the property with a comma to separate them. This obviously fails when trying to create the file...

So the bottom line is that so long that you do not specify e.g. cacheFile several times in your config, you should be all clear.

I am not sure whether this is in fact a bug with 5.3, or if it is a result of maven-checkstyle-plugin using the Checkstyle API in the wrong way.

Show
Paul Nyheim added a comment - Did not have time to actually fix them now, but managed to track down the error. The tests that fail are related to this change in Checkstyle 5.3 (all tests run fine with 5.2) changeset:DefaultConfiguration.java As far as I can find out, cacheFile is specified in both min-plugin-config.xml and in sun_checks.xml (with substitution property), and this creates problems due to the previous mentioned change, where the absolute path would be added to the property with a comma to separate them. This obviously fails when trying to create the file... So the bottom line is that so long that you do not specify e.g. cacheFile several times in your config, you should be all clear. I am not sure whether this is in fact a bug with 5.3, or if it is a result of maven-checkstyle-plugin using the Checkstyle API in the wrong way.
Hide
Permalink
Olivier Lamy added a comment -

fixed rev 1035854

Show
Olivier Lamy added a comment - fixed rev 1035854

People

  • Assignee:
    Olivier Lamy
    Reporter:
    Simon Brandhof
Vote (8)
Watch (8)

Dates

  • Created:
    Updated:
    Resolved: