Maven 2.x Checkstyle Plugin

remove use of Serviceable (to be compatible wih maven 3.x)

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Critical Critical
  • Resolution: Fixed
  • Affects Version/s: 2.3
  • Fix Version/s: 2.5
  • Labels:
    None
  • Number of attachments :
    0

Description

the current version use interface Serviceable which won't work with maven 3.x.

Issue Links

is depended upon by

Improvement - An improvement or enhancement to an existing feature or task. SONAR-1265 Compatibility with Maven 3.0

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
is related to

Improvement - An improvement or enhancement to an existing feature or task. MCHECKSTYLE-101 Skip should skip everything including the Velocity initialization

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Olivier Lamy made changes -
Field Original Value New Value
Fix Version/s 2.4 [ 15336 ]
Assignee Olivier Lamy [ olamy ]
Hide
Permalink
Olivier Lamy added a comment -

reverting MCHECKSTYLE-101 ?
In fact I don't really understand why people attached checkstyle check in a normal build.
IMHO this must be only in a dedicated reporting profile.

Show
Olivier Lamy added a comment - reverting MCHECKSTYLE-101 ? In fact I don't really understand why people attached checkstyle check in a normal build. IMHO this must be only in a dedicated reporting profile.
Olivier Lamy made changes -
Link This issue is related to MCHECKSTYLE-101 [ MCHECKSTYLE-101 ]
Hide
Permalink
Olivier Lamy added a comment -

The question is :
Restoring this in plexus ? or reverting MCHECKSTYLE-101 ?

Show
Olivier Lamy added a comment - The question is : Restoring this in plexus ? or reverting MCHECKSTYLE-101 ?
Hide
Permalink
Benjamin Bentmann added a comment -

The Velocity component appears to be used only for generation of RSS however the generation of RSS is surely not needed for the checkstyle:check goal. I.e. the issue reported in MCHECKSTYLE-101 could be addressed by some refactoring of the plugin, that would need to aim at removing @execute goal="checkstyle" from the check goal.

Show
Benjamin Bentmann added a comment - The Velocity component appears to be used only for generation of RSS however the generation of RSS is surely not needed for the checkstyle:check goal. I.e. the issue reported in MCHECKSTYLE-101 could be addressed by some refactoring of the plugin, that would need to aim at removing @execute goal="checkstyle" from the check goal.
Olivier Lamy made changes -
Fix Version/s 2.5 [ 15982 ]
Fix Version/s 2.4 [ 15336 ]
Hide
Permalink
Olivier Lamy added a comment -

first commit in rev 836274
Leave it open as some its continue to failed with mvn 3.x

Show
Olivier Lamy added a comment - first commit in rev 836274 Leave it open as some its continue to failed with mvn 3.x
Olivier Lamy made changes -
Status Open [ 1 ] Closed [ 6 ]
Resolution Fixed [ 1 ]
Simon Brandhof made changes -
Link This issue is depended upon by SONAR-1265 [ SONAR-1265 ]

People

  • Assignee:
    Olivier Lamy
    Reporter:
    Olivier Lamy
Vote (1)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: