Maven 2.x Checkstyle Plugin

remove use of Serviceable (to be compatible wih maven 3.x)

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Critical Critical
  • Resolution: Fixed
  • Affects Version/s: 2.3
  • Fix Version/s: 2.5
  • Component/s: None
  • Labels:
    None
  • Number of attachments :
    0

Description

the current version use interface Serviceable which won't work with maven 3.x.

Issue Links

This issue is related to:
MCHECKSTYLE-101 Skip should skip everything including the Velocity initialization Major Closed
This issue is depended upon by:
SONAR-1265 Compatibility with Maven 3.0 Major Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Olivier Lamy added a comment -

reverting MCHECKSTYLE-101 ?
In fact I don't really understand why people attached checkstyle check in a normal build.
IMHO this must be only in a dedicated reporting profile.

Show
Olivier Lamy added a comment - reverting MCHECKSTYLE-101 ? In fact I don't really understand why people attached checkstyle check in a normal build. IMHO this must be only in a dedicated reporting profile.
Hide
Permalink
Olivier Lamy added a comment -

The question is :
Restoring this in plexus ? or reverting MCHECKSTYLE-101 ?

Show
Olivier Lamy added a comment - The question is : Restoring this in plexus ? or reverting MCHECKSTYLE-101 ?
Hide
Permalink
Benjamin Bentmann added a comment -

The Velocity component appears to be used only for generation of RSS however the generation of RSS is surely not needed for the checkstyle:check goal. I.e. the issue reported in MCHECKSTYLE-101 could be addressed by some refactoring of the plugin, that would need to aim at removing @execute goal="checkstyle" from the check goal.

Show
Benjamin Bentmann added a comment - The Velocity component appears to be used only for generation of RSS however the generation of RSS is surely not needed for the checkstyle:check goal. I.e. the issue reported in MCHECKSTYLE-101 could be addressed by some refactoring of the plugin, that would need to aim at removing @execute goal="checkstyle" from the check goal.
Hide
Permalink
Olivier Lamy added a comment -

first commit in rev 836274
Leave it open as some its continue to failed with mvn 3.x

Show
Olivier Lamy added a comment - first commit in rev 836274 Leave it open as some its continue to failed with mvn 3.x

People

Vote (1)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.