Maven Checkstyle Plugin
  1. Maven Checkstyle Plugin
  2. MCHECKSTYLE-123

remove use of Serviceable (to be compatible wih maven 3.x)

    Details

    • Type: Bug Bug
    • Status: Closed Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.5
    • Component/s: None
    • Labels:
      None
    • Number of attachments :
      0

      Description

      the current version use interface Serviceable which won't work with maven 3.x.

        Issue Links

          Activity

          Hide
          Olivier Lamy added a comment -

          reverting MCHECKSTYLE-101 ?
          In fact I don't really understand why people attached checkstyle check in a normal build.
          IMHO this must be only in a dedicated reporting profile.

          Show
          Olivier Lamy added a comment - reverting MCHECKSTYLE-101 ? In fact I don't really understand why people attached checkstyle check in a normal build. IMHO this must be only in a dedicated reporting profile.
          Hide
          Olivier Lamy added a comment -

          The question is :
          Restoring this in plexus ? or reverting MCHECKSTYLE-101 ?

          Show
          Olivier Lamy added a comment - The question is : Restoring this in plexus ? or reverting MCHECKSTYLE-101 ?
          Hide
          Benjamin Bentmann added a comment -

          The Velocity component appears to be used only for generation of RSS however the generation of RSS is surely not needed for the checkstyle:check goal. I.e. the issue reported in MCHECKSTYLE-101 could be addressed by some refactoring of the plugin, that would need to aim at removing @execute goal="checkstyle" from the check goal.

          Show
          Benjamin Bentmann added a comment - The Velocity component appears to be used only for generation of RSS however the generation of RSS is surely not needed for the checkstyle:check goal. I.e. the issue reported in MCHECKSTYLE-101 could be addressed by some refactoring of the plugin, that would need to aim at removing @execute goal="checkstyle" from the check goal.
          Hide
          Olivier Lamy added a comment -

          first commit in rev 836274
          Leave it open as some its continue to failed with mvn 3.x

          Show
          Olivier Lamy added a comment - first commit in rev 836274 Leave it open as some its continue to failed with mvn 3.x

            People

            • Assignee:
              Olivier Lamy
              Reporter:
              Olivier Lamy
            • Votes:
              1 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: