Maven 2.x Changes Plugin

The changes plugin should not hard code the "team-list.html" file

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.0-beta-2, 2.0-beta-3
  • Fix Version/s: 2.4
  • Component/s: changes.xml
  • Labels:
    None
  • Number of attachments :
    2

Description

Projects that do not have a team-list file or use a different file will have a number of broken links on the changes-plugin report page.

The attached patch makes the URL of the team-list file configurable with the default being the "team-list.html" file. This can be changed by setting the

<configuration>
<teamlist>foo.html</teamlist>
</configuration>

parameter. When this parameter is set to empty (e.g.

<configuration>
<teamlist/>
</configuration>

then no link is generated and just the names are reported.

  1. Text File
    changes5.patch
    28/Jan/07 9:41 AM
    4 kB
    Henning Schmiedehausen
  2. Text File
    MCHANGES-67.patch
    17/Dec/10 5:42 PM
    3 kB
    Dennis Lundberg

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Henning Schmiedehausen added a comment -

Any news on this? I am using this patch in building a site where the team members are listed on a different page and it works well.

Show
Henning Schmiedehausen added a comment - Any news on this? I am using this patch in building a site where the team members are listed on a different page and it works well.
Hide
Permalink
Dennis Lundberg added a comment -

Henning, is there a standard Maven way to change the team-list file? I had a look at maven-project-info-reports-plugin and couldn't find a way to change it.

Show
Dennis Lundberg added a comment - Henning, is there a standard Maven way to change the team-list file? I had a look at maven-project-info-reports-plugin and couldn't find a way to change it.
Hide
Permalink
Dennis Lundberg added a comment -

Here is an updated patch that can be applied to the current trunk.

Unfortunately it doesn't work as Henning wanted it to. It is not possible to set a parameter to empty. If the configuration element is empty, like this <teamlist></teamlist>, then the default-value kicks in. This means that you cannot use this patch to get rid of the links to team members.

Show
Dennis Lundberg added a comment - Here is an updated patch that can be applied to the current trunk. Unfortunately it doesn't work as Henning wanted it to. It is not possible to set a parameter to empty. If the configuration element is empty, like this <teamlist></teamlist>, then the default-value kicks in. This means that you cannot use this patch to get rid of the links to team members.
Hide
Permalink
Henning Schmiedehausen added a comment -

wow, 3 1/2 years in and someone is already looking at the issue?

Show
Henning Schmiedehausen added a comment - wow, 3 1/2 years in and someone is already looking at the issue?
Hide
Permalink
Dennis Lundberg added a comment -

Yep, better late than never.

I have recently realized that being able to not link to the team-list is a nice feature to have.

We could solve it by adding a special token "none". If you do this:

<configuration>
 <teamlist>none</teamlist>
</configuration>

no links would be generated.

Does that sound OK?

Show
Dennis Lundberg added a comment - Yep, better late than never. I have recently realized that being able to not link to the team-list is a nice feature to have. We could solve it by adding a special token "none". If you do this: <configuration> <teamlist>none</teamlist> </configuration> no links would be generated. Does that sound OK?
Hide
Permalink
Dennis Lundberg added a comment -

Patch applied with modifications in r1050310.
New 2.4-SNAPSHOT deployed.
Thanks!

Show
Dennis Lundberg added a comment - Patch applied with modifications in r1050310 . New 2.4-SNAPSHOT deployed. Thanks!

People

  • Assignee:
    Dennis Lundberg
    Reporter:
    Henning Schmiedehausen
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: