Maven 2.x Changes Plugin

The jira report should handle the nonProxyHosts specified in settings.xml

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.0-beta-2
  • Fix Version/s: 2.4
  • Component/s: jira
  • Labels:
    None
  • Environment:
    A network with a proxy to access the outside, and a JIRA inside the network.
  • Number of attachments :
    1

Description

These nonProxyHosts can be retrieved with the settings.getActiveProxy().getNonProxyHosts();
This returns a String containing a (usually?)comma-separated list of nonProxyHosts.
If the jira URL matches one of these hosts, it should not use any proxy of course .

I haven't found a nonProxyHosts concept in commons-httpclient, so it should be checked in the determineProxy Method of AbstractJiraDownloader.

This is quickly fixed and would be very useful

Thanks in advance

Issue Links

is duplicated by

Bug - A problem which impairs or prevents the functions of the product. MCHANGES-200 Problem with login to jira over https and proxy

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Marcus Schulte added a comment -

Separator character should be the pipe (|). Wildcards should be supported. See http://maven.apache.org/guides/mini/guide-proxies.html .

This Bug (yes it is a bug ) renders the plugin unusable for us, because our proxy refuses to proxy internal servers.

Show
Marcus Schulte added a comment - Separator character should be the pipe (|). Wildcards should be supported. See http://maven.apache.org/guides/mini/guide-proxies.html . This Bug (yes it is a bug ) renders the plugin unusable for us, because our proxy refuses to proxy internal servers.
Hide
Permalink
Dennis Lundberg added a comment -

I don't have access to a proxy, so it's difficult for me to test this. Patches are always welcome. I can apply them and push out new SNAPSHOTS.

To me this is an improvement, but that's a matter of opinion
In my book a bug is an advertised feature that doesn't work as advertised.

Show
Dennis Lundberg added a comment - I don't have access to a proxy, so it's difficult for me to test this. Patches are always welcome. I can apply them and push out new SNAPSHOTS. To me this is an improvement, but that's a matter of opinion In my book a bug is an advertised feature that doesn't work as advertised.
Hide
Permalink
Andy Geach added a comment -

This patch fixes the issue - if JIRA is hosted on a non-proxy host as specified in settings.xml, then the request is not routed via the proxy. The helper method that matches the JIRA host with non-proxy hosts is copied from org.apache.maven.wagon.proxy.ProxyUtils (which is in project wagon-provider-api version 1.0-beta-4). In the future, when maven-changes-plugin updates its dependency on maven-project to a more recent version, then the method can be removed.

Note that this patch also fixes issue MCHANGES-123

Show
Andy Geach added a comment - This patch fixes the issue - if JIRA is hosted on a non-proxy host as specified in settings.xml, then the request is not routed via the proxy. The helper method that matches the JIRA host with non-proxy hosts is copied from org.apache.maven.wagon.proxy.ProxyUtils (which is in project wagon-provider-api version 1.0-beta-4). In the future, when maven-changes-plugin updates its dependency on maven-project to a more recent version, then the method can be removed. Note that this patch also fixes issue MCHANGES-123
Hide
Permalink
Dennis Lundberg added a comment -

Patch applied in r1050910.
Thanks!

New 2.4-SNAPSHOT deployed - please help us test it if you have a proxy available.

Show
Dennis Lundberg added a comment - Patch applied in r1050910 . Thanks! New 2.4-SNAPSHOT deployed - please help us test it if you have a proxy available.

People

  • Assignee:
    Dennis Lundberg
    Reporter:
    Pierre-Antoine Grégoire
Vote (5)
Watch (5)

Dates

  • Created:
    Updated:
    Resolved: