Details

    • Type: Improvement Improvement
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.8
    • Fix Version/s: 2.10
    • Component/s: announcement
    • Labels:
      None
    • Patch Submitted:
      Yes
    • Number of attachments :
      1

      Description

      Add an option to set ProjectJavamailMailSender.tlsEnabled to true, to allow to use as an example GMail to send announcement emails

        Activity

        Hide
        Dennis Lundberg added a comment -

        Hello Benoit,

        Thank you for your patch. I've had a look at it and it looks good, but I have a question.

        In the ProjectJavamailMailSender.java file you set the startTls property if TLS is enabled. Shouldn't that code be inside the try/catch just above it? I.e. inside the if( isSslMode() ) statement? I imagine that SSL is required to be able to use TLS.

        Show
        Dennis Lundberg added a comment - Hello Benoit, Thank you for your patch. I've had a look at it and it looks good, but I have a question. In the ProjectJavamailMailSender.java file you set the startTls property if TLS is enabled. Shouldn't that code be inside the try/catch just above it? I.e. inside the if( isSslMode() ) statement? I imagine that SSL is required to be able to use TLS.
        Hide
        Dennis Lundberg added a comment -

        Never mind, after doing some testing I realized that SSL and TLS are mutually exclusive. I was able to send a test announcement using gmail as smtp server.

        I applied your patch in r1578534 with minor adjustments. Thanks!

        Show
        Dennis Lundberg added a comment - Never mind, after doing some testing I realized that SSL and TLS are mutually exclusive. I was able to send a test announcement using gmail as smtp server. I applied your patch in r1578534 with minor adjustments. Thanks!
        Hide
        Benoit Guerin added a comment -

        Great ! thanks !

        Show
        Benoit Guerin added a comment - Great ! thanks !

          People

          • Assignee:
            Dennis Lundberg
            Reporter:
            Benoit Guerin
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: