Maven Changes Plugin
  1. Maven Changes Plugin
  2. MCHANGES-253

Documentation bug - "Closed" is not a resolutionID

    Details

    • Number of attachments :
      0

      Description

      The page http://maven.apache.org/plugins/maven-changes-plugin/examples/customizing-jira-report.html says:

      Using Maven syntax

      In the following example we are only including issues that have Closed as their resolution.

      However, as far as I can tell, Closed is not a valid Resolution type.

      It should probably be "Fixed".

        Activity

        Hide
        SebbASF added a comment -

        http://maven.apache.org/plugins/maven-changes-plugin/jira-report-mojo.html says:

        Valid resolutions are: Unresolved, Fixed, Won't Fix, Duplicate, Incomplete and Cannot Reproduce.

        which does not include "Closed".

        Show
        SebbASF added a comment - http://maven.apache.org/plugins/maven-changes-plugin/jira-report-mojo.html says: Valid resolutions are: Unresolved, Fixed, Won't Fix, Duplicate, Incomplete and Cannot Reproduce. which does not include "Closed".
        Hide
        Benson Margulies added a comment -

        1131414

        Show
        Benson Margulies added a comment - 1131414
        Hide
        SebbASF added a comment -

        AFAICT the following text has not been fixed:

        In the following example we are only including issues that have Closed as their resolution.

        Closed should be Fixed here as well

        Show
        SebbASF added a comment - AFAICT the following text has not been fixed: In the following example we are only including issues that have Closed as their resolution. Closed should be Fixed here as well
        Hide
        Benson Margulies added a comment -

        Once more with feeling.

        Show
        Benson Margulies added a comment - Once more with feeling.
        Hide
        SebbASF added a comment -

        Sorry, but there is still an incorrect mention of closed - I've just checked in the current source, i.e.

        http://svn.apache.org/viewvc/maven/plugins/trunk/maven-changes-plugin/src/site/apt/examples/customizing-jira-report.apt.vm?revision=1131414

          • Using Maven syntax

        In the following example we are only including issues that have <Closed> as
        their resolution. The status must be either <Resolved> or <Closed>. Only
        ...
        <configuration>
        <resolutionIds>Fixed</resolutionIds>
        <statusIds>Resolved, Closed</statusIds>
        ...

        Closed is not valid as a resolution.

        Show
        SebbASF added a comment - Sorry, but there is still an incorrect mention of closed - I've just checked in the current source, i.e. http://svn.apache.org/viewvc/maven/plugins/trunk/maven-changes-plugin/src/site/apt/examples/customizing-jira-report.apt.vm?revision=1131414 Using Maven syntax In the following example we are only including issues that have <Closed> as their resolution. The status must be either <Resolved> or <Closed>. Only ... <configuration> <resolutionIds>Fixed</resolutionIds> <statusIds>Resolved, Closed</statusIds> ... Closed is not valid as a resolution.
        Hide
        Benson Margulies added a comment -

        Sebb, I fixed it in 1131454 after your last reopen.

          • Using Maven syntax

        In the following example we are only including issues that have <Fixed> as
        their resolution. The status must be either <Resolved> or <Closed>. Only
        issues with one of the types <Bug>, <New Feature>, <Improvement> or <Wish> are
        included in the report.

        -----------------

        Show
        Benson Margulies added a comment - Sebb, I fixed it in 1131454 after your last reopen. Using Maven syntax In the following example we are only including issues that have <Fixed> as their resolution. The status must be either <Resolved> or <Closed>. Only issues with one of the types <Bug>, <New Feature>, <Improvement> or <Wish> are included in the report. -----------------
        Hide
        Benson Margulies added a comment -

        Really, I did fix it.

        Show
        Benson Margulies added a comment - Really, I did fix it.
        Hide
        SebbASF added a comment -

        Sorry, that was not clear to me from your comment - it did not mention a further SVN update
        (and then I messed up by not looking at the HEAD version which would have shown what had happened).

        Show
        SebbASF added a comment - Sorry, that was not clear to me from your comment - it did not mention a further SVN update (and then I messed up by not looking at the HEAD version which would have shown what had happened).
        Hide
        Benson Margulies added a comment - - edited

        r1131414 | bimargulies | 2011-06-04 11:17:46 -0400 (Sat, 04 Jun 2011) | 4 lines

        [MCHANGES-254, MCHANGES-253] add more calls to trim, fix doc.

        Also fix some warnings in site generation.

        r1131445 | bimargulies | 2011-06-04 13:22:54 -0400 (Sat, 04 Jun 2011) | 1 line

        MCHANGES-253 leftover

        Show
        Benson Margulies added a comment - - edited r1131414 | bimargulies | 2011-06-04 11:17:46 -0400 (Sat, 04 Jun 2011) | 4 lines [MCHANGES-254, MCHANGES-253] add more calls to trim, fix doc. Also fix some warnings in site generation. r1131445 | bimargulies | 2011-06-04 13:22:54 -0400 (Sat, 04 Jun 2011) | 1 line MCHANGES-253 leftover

          People

          • Assignee:
            Benson Margulies
            Reporter:
            SebbASF
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: