Maven 2.x Changes Plugin

ccAddresses and bccAddresses should not be 'required'

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.5
  • Fix Version/s: 2.6
  • Component/s: announcement
  • Labels:
    None
  • Number of attachments :
    1

Description

It seems unkind and unnecessary to require the cc and bcc. If one doesn't need them, why require them?

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Dennis Lundberg added a comment -

Was it necessary to add default values fro the parameters?
I imagine that it would be enough to just remove the @required annotations.

Show
Dennis Lundberg added a comment - Was it necessary to add default values fro the parameters? I imagine that it would be enough to just remove the @required annotations.
Hide
Permalink
Benson Margulies added a comment -

The code would crash without them. This looked neater than a bunch of checks for null.

Unless by default maven injects empty lists

Show
Benson Margulies added a comment - The code would crash without them. This looked neater than a bunch of checks for null. Unless by default maven injects empty lists
Hide
Permalink
Dennis Lundberg added a comment -

Fixed in r1129881.

I went with the null check.

Show
Dennis Lundberg added a comment - Fixed in r1129881 . I went with the null check.

People

  • Assignee:
    Dennis Lundberg
    Reporter:
    Benson Margulies
Vote (1)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: