Maven Changes Plugin
  1. Maven Changes Plugin
  2. MCHANGES-250

ccAddresses and bccAddresses should not be 'required'

    Details

    • Type: Improvement Improvement
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.6
    • Component/s: announcement
    • Labels:
      None
    • Number of attachments :
      1

      Description

      It seems unkind and unnecessary to require the cc and bcc. If one doesn't need them, why require them?

        Activity

        Hide
        Dennis Lundberg added a comment -

        Was it necessary to add default values fro the parameters?
        I imagine that it would be enough to just remove the @required annotations.

        Show
        Dennis Lundberg added a comment - Was it necessary to add default values fro the parameters? I imagine that it would be enough to just remove the @required annotations.
        Hide
        Benson Margulies added a comment -

        The code would crash without them. This looked neater than a bunch of checks for null.

        Unless by default maven injects empty lists

        Show
        Benson Margulies added a comment - The code would crash without them. This looked neater than a bunch of checks for null. Unless by default maven injects empty lists
        Hide
        Dennis Lundberg added a comment -

        Fixed in r1129881.

        I went with the null check.

        Show
        Dennis Lundberg added a comment - Fixed in r1129881 . I went with the null check.

          People

          • Assignee:
            Dennis Lundberg
            Reporter:
            Benson Margulies
          • Votes:
            1 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: