Maven Changes Plugin
  1. Maven Changes Plugin
  2. MCHANGES-249

The jira downloaded used for announcements only supports 'closed'

    Details

    • Type: Bug Bug
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.6
    • Component/s: announcement
    • Labels:
      None
    • Number of attachments :
      1

      Description

      org.apache.maven.plugin.announcement.JiraDownloader only puts 'Closed' in the statusMap, so it's not possible to specify, say, Resolved,Closed.

      Why are there two of these, anyhow?

        Issue Links

          Activity

          Hide
          Benson Margulies added a comment -

          Remove the extra JiraDownloader that has no effect except to prevent announcements of unclosed issues.

          Show
          Benson Margulies added a comment - Remove the extra JiraDownloader that has no effect except to prevent announcements of unclosed issues.
          Hide
          Dennis Lundberg added a comment -

          I don't know the history behind why there are two of them. I'll run some tests to see what effect it has to remove one of them.

          Show
          Dennis Lundberg added a comment - I don't know the history behind why there are two of them. I'll run some tests to see what effect it has to remove one of them.
          Hide
          Benson Margulies added a comment -

          Dennis,

          I should have edited out the question of 'why two?'

          There are two because someone wanted to prevent anyone from making announcements on any issues other than closed. My patch is to abolish that restriction.

          Show
          Benson Margulies added a comment - Dennis, I should have edited out the question of 'why two?' There are two because someone wanted to prevent anyone from making announcements on any issues other than closed. My patch is to abolish that restriction.
          Hide
          Dennis Lundberg added a comment -

          So with a suitable default value, nobody will ever know the difference unless they start changing the parameters.

          Show
          Dennis Lundberg added a comment - So with a suitable default value, nobody will ever know the difference unless they start changing the parameters.
          Hide
          Benson Margulies added a comment -

          Yes. If the default is Closed, then my change is backward-compatible except .. the old behavior was to silently discard unrecognized statusses. Anyone who wrote, say, 'Closed,Resolved' will now find themselves looking more issues in their announcement.

          Show
          Benson Margulies added a comment - Yes. If the default is Closed, then my change is backward-compatible except .. the old behavior was to silently discard unrecognized statusses. Anyone who wrote, say, 'Closed,Resolved' will now find themselves looking more issues in their announcement.
          Hide
          Dennis Lundberg added a comment -

          Patch applied in r1129889.
          Thanks!

          Show
          Dennis Lundberg added a comment - Patch applied in r1129889 . Thanks!

            People

            • Assignee:
              Dennis Lundberg
              Reporter:
              Benson Margulies
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: