Maven 2.x Changes Plugin

The jira downloaded used for announcements only supports 'closed'

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.5
  • Fix Version/s: 2.6
  • Component/s: announcement
  • Labels:
    None
  • Number of attachments :
    1

Description

org.apache.maven.plugin.announcement.JiraDownloader only puts 'Closed' in the statusMap, so it's not possible to specify, say, Resolved,Closed.

Why are there two of these, anyhow?

Issue Links

is duplicated by

Bug - A problem which impairs or prevents the functions of the product. MCHANGES-247 StatusIds don't end up in the URL

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Benson Margulies added a comment -

Remove the extra JiraDownloader that has no effect except to prevent announcements of unclosed issues.

Show
Benson Margulies added a comment - Remove the extra JiraDownloader that has no effect except to prevent announcements of unclosed issues.
Hide
Permalink
Dennis Lundberg added a comment -

I don't know the history behind why there are two of them. I'll run some tests to see what effect it has to remove one of them.

Show
Dennis Lundberg added a comment - I don't know the history behind why there are two of them. I'll run some tests to see what effect it has to remove one of them.
Hide
Permalink
Benson Margulies added a comment -

Dennis,

I should have edited out the question of 'why two?'

There are two because someone wanted to prevent anyone from making announcements on any issues other than closed. My patch is to abolish that restriction.

Show
Benson Margulies added a comment - Dennis, I should have edited out the question of 'why two?' There are two because someone wanted to prevent anyone from making announcements on any issues other than closed. My patch is to abolish that restriction.
Hide
Permalink
Dennis Lundberg added a comment -

So with a suitable default value, nobody will ever know the difference unless they start changing the parameters.

Show
Dennis Lundberg added a comment - So with a suitable default value, nobody will ever know the difference unless they start changing the parameters.
Hide
Permalink
Benson Margulies added a comment -

Yes. If the default is Closed, then my change is backward-compatible except .. the old behavior was to silently discard unrecognized statusses. Anyone who wrote, say, 'Closed,Resolved' will now find themselves looking more issues in their announcement.

Show
Benson Margulies added a comment - Yes. If the default is Closed, then my change is backward-compatible except .. the old behavior was to silently discard unrecognized statusses. Anyone who wrote, say, 'Closed,Resolved' will now find themselves looking more issues in their announcement.
Hide
Permalink
Dennis Lundberg added a comment -

Patch applied in r1129889.
Thanks!

Show
Dennis Lundberg added a comment - Patch applied in r1129889 . Thanks!

People

  • Assignee:
    Dennis Lundberg
    Reporter:
    Benson Margulies
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: